Re: Review Request 23211: Fix TaskObserver for json endpoint usage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 2, 2014, 6:01 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- Addressed comments. Repository: aurora Description --- Fix TaskObserver for json endpoint usage. Diffs (updated) - src/main/python/apache/thermos/observer/http/json.py b81232c2236a42416148c323fa77ee61976a92c9 src/main/python/apache/thermos/observer/task_observer.py b2114db1173ab52cc5c9ef41a53012d9a9b99cc7 Diff: https://reviews.apache.org/r/23211/diff/ Testing --- The `/j/task?task_id=id1,id2,...` endpoint now works. Thanks, Kevin Burg
Review Request 23211: Fix TaskObserver for json endpoint usage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- Review request for Aurora. Repository: aurora Description --- Fix TaskObserver for json endpoint usage. Diffs - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 2c827fe9ae5bfc941dcf3fd23e4f88d152342f1d src/main/java/org/apache/aurora/scheduler/Driver.java ffedfc313bec4671f95fa4d83ad0a1df58a5fd1f src/main/java/org/apache/aurora/scheduler/DriverFactory.java 0f40112c48c64300f35106a8a2f81d10b2ff8673 src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 0dce5c4a914a8e541815117064b046659e3a60df src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 979b4bb8103634d11885ca8cdf82de8543a61cd3 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 48b4404590d393cda393b8cc7bc0619934a75223 src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java d96e34a5d9c1b8839f2d1e8c74fd65d7107443ac src/main/java/org/apache/aurora/scheduler/TaskVars.java a58696ba094619ca130c4b8f5287696856d7c1e7 src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java f79b0fa507d0b8e0f8f333cd026df73f95c4319f src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0b37442efcc006f9d231c1f9751dc23483af815 src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java dc99ddc89f16642588670538b478099f69cd2ca7 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2 src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 1fff2b3a9e50e88a94c69beed7ab312c0fc8d711 src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f29ad7fe1a0d388b6d9558df7b9b01accd433fe5 src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 6ad733c71adb0220fa0c73279871b09265359881 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 57ed758b537f8fdcc1ccf04236cfb5e9c201e628 src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java d21856f6bf5e5dbd4f3daffeee7a2b3f797e573f src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 0b637216fe1ccff9841684913152ed8e036f795a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 48b36c28b67866d45bcd29354c80429e36102bd4 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 47cb70bb092a20971e81c867218836d8bd9fbdef src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 17ac2860ba00f031cde68f1e177c8d1072402af3 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 57d874baf57732b1b78c12773f1c0b984a284836 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java 311bcb3cac883c8c0429ddf9f6bac8366e35f5ec src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 9eda3b7baafd81bd8535a73df74131cedc0797eb src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 02ba94a81633a210a69064fd7ac7f71d3559d734 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java a2f099a27e2da73ae2ac9ded04fa258e4f5846c4 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 5b24b31a59ef602baae1f7a6e6c7ce2a2165b507 src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 25c81b9695692b5c4402ebb95c5e5c36594a29b9 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 29fe32b469068e8850b71ac71f7b77294e1b7121 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java d29fbd4f9a3d7fe813f2f105669cf63322efe758 src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 71620d70a5bd7c6c309281c3e59bc53f04af781b src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 860a240a6d185ce8fa63ca6e0525219794c9c865 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java b206830a38f3f6e2265f6d742c891f4cf85094b6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java a336b47a652965fa76d65bb8eb415d6d5bd26982 src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 070c7da75a1d4f8541ec26880b4bdcb0e75255aa
Re: Review Request 23211: Fix TaskObserver for json endpoint usage
On July 1, 2014, 1:51 p.m., Kevin Sweeney wrote: Hi Kevin, Can you please rebase this patch against master. Thanks, Kevin (You can preview the diff that will be sent with ./rbt patch or by using the draft feature.) - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/#review47141 --- On July 1, 2014, 1:46 p.m., Kevin Burg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 1:46 p.m.) Review request for Aurora. Repository: aurora Description --- Fix TaskObserver for json endpoint usage. Diffs - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 2c827fe9ae5bfc941dcf3fd23e4f88d152342f1d src/main/java/org/apache/aurora/scheduler/Driver.java ffedfc313bec4671f95fa4d83ad0a1df58a5fd1f src/main/java/org/apache/aurora/scheduler/DriverFactory.java 0f40112c48c64300f35106a8a2f81d10b2ff8673 src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 0dce5c4a914a8e541815117064b046659e3a60df src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 979b4bb8103634d11885ca8cdf82de8543a61cd3 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 48b4404590d393cda393b8cc7bc0619934a75223 src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java d96e34a5d9c1b8839f2d1e8c74fd65d7107443ac src/main/java/org/apache/aurora/scheduler/TaskVars.java a58696ba094619ca130c4b8f5287696856d7c1e7 src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java f79b0fa507d0b8e0f8f333cd026df73f95c4319f src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0b37442efcc006f9d231c1f9751dc23483af815 src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java dc99ddc89f16642588670538b478099f69cd2ca7 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2 src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 1fff2b3a9e50e88a94c69beed7ab312c0fc8d711 src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f29ad7fe1a0d388b6d9558df7b9b01accd433fe5 src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 6ad733c71adb0220fa0c73279871b09265359881 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 57ed758b537f8fdcc1ccf04236cfb5e9c201e628 src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java d21856f6bf5e5dbd4f3daffeee7a2b3f797e573f src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 0b637216fe1ccff9841684913152ed8e036f795a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 48b36c28b67866d45bcd29354c80429e36102bd4 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 47cb70bb092a20971e81c867218836d8bd9fbdef src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 17ac2860ba00f031cde68f1e177c8d1072402af3 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 57d874baf57732b1b78c12773f1c0b984a284836 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java 311bcb3cac883c8c0429ddf9f6bac8366e35f5ec src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 9eda3b7baafd81bd8535a73df74131cedc0797eb src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 02ba94a81633a210a69064fd7ac7f71d3559d734 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java a2f099a27e2da73ae2ac9ded04fa258e4f5846c4 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 5b24b31a59ef602baae1f7a6e6c7ce2a2165b507 src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 25c81b9695692b5c4402ebb95c5e5c36594a29b9 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 29fe32b469068e8850b71ac71f7b77294e1b7121 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31
Re: Review Request 23211: Fix TaskObserver for json endpoint usage
On July 1, 2014, 8:51 p.m., Kevin Sweeney wrote: Hi Kevin, Can you please rebase this patch against master. Thanks, Kevin Kevin Sweeney wrote: (You can preview the diff that will be sent with ./rbt patch or by using the draft feature.) Sorry about that, i just snuck in a commit since you posted the pull request :-/ - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/#review47141 --- On July 1, 2014, 8:46 p.m., Kevin Burg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 8:46 p.m.) Review request for Aurora. Repository: aurora Description --- Fix TaskObserver for json endpoint usage. Diffs - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 2c827fe9ae5bfc941dcf3fd23e4f88d152342f1d src/main/java/org/apache/aurora/scheduler/Driver.java ffedfc313bec4671f95fa4d83ad0a1df58a5fd1f src/main/java/org/apache/aurora/scheduler/DriverFactory.java 0f40112c48c64300f35106a8a2f81d10b2ff8673 src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 0dce5c4a914a8e541815117064b046659e3a60df src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 979b4bb8103634d11885ca8cdf82de8543a61cd3 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 48b4404590d393cda393b8cc7bc0619934a75223 src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java d96e34a5d9c1b8839f2d1e8c74fd65d7107443ac src/main/java/org/apache/aurora/scheduler/TaskVars.java a58696ba094619ca130c4b8f5287696856d7c1e7 src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java f79b0fa507d0b8e0f8f333cd026df73f95c4319f src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0b37442efcc006f9d231c1f9751dc23483af815 src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java dc99ddc89f16642588670538b478099f69cd2ca7 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2 src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 1fff2b3a9e50e88a94c69beed7ab312c0fc8d711 src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f29ad7fe1a0d388b6d9558df7b9b01accd433fe5 src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 6ad733c71adb0220fa0c73279871b09265359881 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 57ed758b537f8fdcc1ccf04236cfb5e9c201e628 src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java d21856f6bf5e5dbd4f3daffeee7a2b3f797e573f src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 0b637216fe1ccff9841684913152ed8e036f795a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 48b36c28b67866d45bcd29354c80429e36102bd4 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 47cb70bb092a20971e81c867218836d8bd9fbdef src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 17ac2860ba00f031cde68f1e177c8d1072402af3 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 57d874baf57732b1b78c12773f1c0b984a284836 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java 311bcb3cac883c8c0429ddf9f6bac8366e35f5ec src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 9eda3b7baafd81bd8535a73df74131cedc0797eb src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 02ba94a81633a210a69064fd7ac7f71d3559d734 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java a2f099a27e2da73ae2ac9ded04fa258e4f5846c4 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 5b24b31a59ef602baae1f7a6e6c7ce2a2165b507 src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 25c81b9695692b5c4402ebb95c5e5c36594a29b9 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 29fe32b469068e8850b71ac71f7b77294e1b7121
Re: Review Request 23211: Fix TaskObserver for json endpoint usage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 9:02 p.m.) Review request for Aurora. Changes --- Ok. Just took me a while to find that --tracking-branch option Repository: aurora Description --- Fix TaskObserver for json endpoint usage. Diffs (updated) - src/main/python/apache/thermos/observer/task_observer.py b2114db1173ab52cc5c9ef41a53012d9a9b99cc7 Diff: https://reviews.apache.org/r/23211/diff/ Testing --- The `/j/task?task_id=id1,id2,...` endpoint now works. Thanks, Kevin Burg
Re: Review Request 23211: Fix TaskObserver for json endpoint usage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 9:07 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- People += kevints Repository: aurora Description --- Fix TaskObserver for json endpoint usage. Diffs - src/main/python/apache/thermos/observer/task_observer.py b2114db1173ab52cc5c9ef41a53012d9a9b99cc7 Diff: https://reviews.apache.org/r/23211/diff/ Testing --- The `/j/task?task_id=id1,id2,...` endpoint now works. Thanks, Kevin Burg
Re: Review Request 23211: Fix TaskObserver for json endpoint usage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 2:23 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- +wickman Repository: aurora Description --- Fix TaskObserver for json endpoint usage. Diffs - src/main/python/apache/thermos/observer/task_observer.py b2114db1173ab52cc5c9ef41a53012d9a9b99cc7 Diff: https://reviews.apache.org/r/23211/diff/ Testing --- The `/j/task?task_id=id1,id2,...` endpoint now works. Thanks, Kevin Burg
Re: Review Request 23211: Fix TaskObserver for json endpoint usage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/#review47152 --- Ship it! Ship It! - Kevin Burg On July 1, 2014, 9:23 p.m., Kevin Burg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 9:23 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Fix TaskObserver for json endpoint usage. Diffs - src/main/python/apache/thermos/observer/task_observer.py b2114db1173ab52cc5c9ef41a53012d9a9b99cc7 Diff: https://reviews.apache.org/r/23211/diff/ Testing --- The `/j/task?task_id=id1,id2,...` endpoint now works. Thanks, Kevin Burg
Re: Review Request 23211: Fix TaskObserver for json endpoint usage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/#review47159 --- src/main/python/apache/thermos/observer/task_observer.py https://reviews.apache.org/r/23211/#comment82754 This should probably be called 'tasks' since it takes an iterable of task_ids. Probably also merits a docstring to be consistent with the rest. - Brian Wickman On July 1, 2014, 9:23 p.m., Kevin Burg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 9:23 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora Description --- Fix TaskObserver for json endpoint usage. Diffs - src/main/python/apache/thermos/observer/task_observer.py b2114db1173ab52cc5c9ef41a53012d9a9b99cc7 Diff: https://reviews.apache.org/r/23211/diff/ Testing --- The `/j/task?task_id=id1,id2,...` endpoint now works. Thanks, Kevin Burg