Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)

2014-07-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23595/#review48022 --- 'Fat jars' are inherently problematic. Some libraries expect

Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)

2014-07-17 Thread Jake Farrell
On July 17, 2014, 5:33 p.m., Bill Farner wrote: 'Fat jars' are inherently problematic. Some libraries expect resources at well-known locations, which would be candidate for brittleness when there are collisions. Jar signing is also broken by this approach. Unless there's a

Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)

2014-07-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23595/#review48027 --- Thanks for the gut check, discarding this review. - Kevin Sweeney

Review Request 23595: Add the gradle shadow plugin (for fat jar support)

2014-07-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23595/ --- Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora