Re: Review Request 23872: Fix problem with deschedule command.

2014-07-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23872/#review48574 --- Does this point out lack of unit test coverage, or were unit tests

Re: Review Request 23872: Fix problem with deschedule command.

2014-07-23 Thread Mark Chu-Carroll
It's a bit sneaky - unit tests pass, because they mock the call to the API, and the way that the API is implemented in Python, the usual spec mechanism doesn't work for the thrift proxy. So the unit test couldn't catch this. The end-to-end test should have caught it - I'm not sure why it didn't.

Re: Review Request 23872: Fix problem with deschedule command.

2014-07-23 Thread Bill Farner
wired up to thrift. The generated thrift object (AuroraAdmin.Client) has these signatures, though, right? -=Bill On Wed, Jul 23, 2014 at 4:54 PM, Mark Chu-Carroll mchucarr...@apache.org wrote: Unfortunately, no. Because the python code that calls through thrift is using a dynamic

Re: Review Request 23872: Fix problem with deschedule command.

2014-07-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23872/#review48611 --- Ship it! Ship It! - Maxim Khutornenko On July 23, 2014, 11:54