Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23949/
---

(Updated July 29, 2014, 2:53 p.m.)


Review request for Aurora, David McLaughlin and David Robinson.


Changes
---

Modify "people" list, since Joe is away.


Bugs: aurora-603
https://issues.apache.org/jira/browse/aurora-603


Repository: aurora


Description
---

Make testing of v1 command hooks easier.

In order to be able to test v1 command hooks on real commands, it would
be helpful to be able to mock out the body of the commands. In order to
do this, I've separated the commands into an invocation frame, and
the actual command implementation.


Diffs
-

  src/main/python/apache/aurora/client/commands/core.py 
b4169995e996b17dda3dc09f2e5961d77e045d87 

Diff: https://reviews.apache.org/r/23949/diff/


Testing
---

?  incubator-aurora git:(extract_killall) ? git commit -a --amend
[extract_killall 570bd1e] Make testing of v1 command hooks easier.
 2 files changed, 105 insertions(+), 73 deletions(-)
?  incubator-aurora git:(extract_killall) ./pants 
src/test/python/apache/aurora/client:all
Build operating on top level addresses: 
set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 4 items

src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 

=== 4 passed in 0.58 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 3 items

src/test/python/apache/aurora/client/cli/test_config_noun.py ...

=== 3 passed in 0.88 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 28 items

src/test/python/apache/aurora/client/api/test_updater.py 


== 28 passed in 0.94 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .

=== 5 passed in 0.76 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 3 items

src/test/python/apache/aurora/client/cli/test_task_run.py ...

=== 3 passed in 0.72 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 10 items

src/test/python/apache/aurora/client/test_config.py ..

== 10 passed in 0.51 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 7 items

src/test/python/apache/aurora/client/cli/test_cron.py ...

=== 7 passed in 1.21 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 44 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ..
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py .
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 44 passed in 7.74 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 2 items

src/test/python/apache/aurora/client/tes

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread David Robinson 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23949/#review49009
---

Ship it!


Ship It!

- David Robinson


On July 25, 2014, 8:50 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23949/
> ---
> 
> (Updated July 25, 2014, 8:50 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joe Smith.
> 
> 
> Bugs: aurora-603
> https://issues.apache.org/jira/browse/aurora-603
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make testing of v1 command hooks easier.
> 
> In order to be able to test v1 command hooks on real commands, it would
> be helpful to be able to mock out the body of the commands. In order to
> do this, I've separated the commands into an invocation frame, and
> the actual command implementation.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/core.py 
> b4169995e996b17dda3dc09f2e5961d77e045d87 
> 
> Diff: https://reviews.apache.org/r/23949/diff/
> 
> 
> Testing
> ---
> 
> ?  incubator-aurora git:(extract_killall) ? git commit -a --amend
> [extract_killall 570bd1e] Make testing of v1 command hooks easier.
>  2 files changed, 105 insertions(+), 73 deletions(-)
> ?  incubator-aurora git:(extract_killall) ./pants 
> src/test/python/apache/aurora/client:all
> Build operating on top level addresses: 
> set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 4 items
> 
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> === 3 passed in 0.88 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 28 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> 
> 
> == 28 passed in 0.94 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .
> 
> === 5 passed in 0.76 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.02 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
> 
> === 3 passed in 0.72 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 10 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> == 10 passed in 0.51 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 7 items
> 
> src/test/python/apache/aurora/client/cli/test_cron.py ...
> 
> === 7 passed in 1.21 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 44 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ..
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ...

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23949/#review48992
---

Ship it!


Ship It!

- David McLaughlin


On July 25, 2014, 8:50 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23949/
> ---
> 
> (Updated July 25, 2014, 8:50 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joe Smith.
> 
> 
> Bugs: aurora-603
> https://issues.apache.org/jira/browse/aurora-603
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make testing of v1 command hooks easier.
> 
> In order to be able to test v1 command hooks on real commands, it would
> be helpful to be able to mock out the body of the commands. In order to
> do this, I've separated the commands into an invocation frame, and
> the actual command implementation.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/core.py 
> b4169995e996b17dda3dc09f2e5961d77e045d87 
> 
> Diff: https://reviews.apache.org/r/23949/diff/
> 
> 
> Testing
> ---
> 
> ?  incubator-aurora git:(extract_killall) ? git commit -a --amend
> [extract_killall 570bd1e] Make testing of v1 command hooks easier.
>  2 files changed, 105 insertions(+), 73 deletions(-)
> ?  incubator-aurora git:(extract_killall) ./pants 
> src/test/python/apache/aurora/client:all
> Build operating on top level addresses: 
> set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 4 items
> 
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> === 3 passed in 0.88 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 28 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> 
> 
> == 28 passed in 0.94 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .
> 
> === 5 passed in 0.76 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.02 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
> 
> === 3 passed in 0.72 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 10 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> == 10 passed in 0.51 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 7 items
> 
> src/test/python/apache/aurora/client/cli/test_cron.py ...
> 
> === 7 passed in 1.21 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 44 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ..
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread Mark Chu-Carroll 
Ping, again? David, Joe? This is a really easy one!

 -Mark


On Mon, Jul 28, 2014 at 2:07 PM, Mark Chu-Carroll 
wrote:

> ping?
>
>
> On Fri, Jul 25, 2014 at 4:50 PM, Mark Chu-Carroll <
> mchucarr...@twopensource.com> wrote:
>
>>This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/23949/
>>   Review request for Aurora, David McLaughlin and Joe Smith.
>> By Mark Chu-Carroll.
>>
>> *Updated July 25, 2014, 4:50 p.m.*
>>  *Bugs: * aurora-603 
>>  *Repository: * aurora
>> Description
>>
>> Make testing of v1 command hooks easier.
>>
>> In order to be able to test v1 command hooks on real commands, it would
>> be helpful to be able to mock out the body of the commands. In order to
>> do this, I've separated the commands into an invocation frame, and
>> the actual command implementation.
>>
>>   Testing
>>
>> ?  incubator-aurora git:(extract_killall) ? git commit -a --amend
>> [extract_killall 570bd1e] Make testing of v1 command hooks easier.
>>  2 files changed, 105 insertions(+), 73 deletions(-)
>> ?  incubator-aurora git:(extract_killall) ./pants 
>> src/test/python/apache/aurora/client:all
>> Build operating on top level addresses: 
>> set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)])
>> = test session starts 
>> ==
>> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
>> plugins: cov, timeout
>> collected 4 items
>>
>> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
>>
>> === 4 passed in 0.58 seconds 
>> ===
>> = test session starts 
>> ==
>> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
>> plugins: cov, timeout
>> collected 3 items
>>
>> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
>>
>> === 3 passed in 0.88 seconds 
>> ===
>> = test session starts 
>> ==
>> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
>> plugins: cov, timeout
>> collected 28 items
>>
>> src/test/python/apache/aurora/client/api/test_updater.py 
>> 
>>
>> == 28 passed in 0.94 seconds 
>> ===
>> = test session starts 
>> ==
>> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
>> plugins: cov, timeout
>> collected 5 items
>>
>> src/test/python/apache/aurora/client/cli/test_sla.py .
>>
>> === 5 passed in 0.76 seconds 
>> ===
>> = test session starts 
>> ==
>> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
>> plugins: cov, timeout
>> collected 4 items
>>
>> src/test/python/apache/aurora/client/cli/test_bridge.py 
>>
>> === 4 passed in 0.02 seconds 
>> ===
>> = test session starts 
>> ==
>> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
>> plugins: cov, timeout
>> collected 3 items
>>
>> src/test/python/apache/aurora/client/cli/test_task_run.py ...
>>
>> === 3 passed in 0.72 seconds 
>> ===
>> = test session starts 
>> ==
>> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
>> plugins: cov, timeout
>> collected 10 items
>>
>> src/test/python/apache/aurora/client/test_config.py ..
>>
>> == 10 passed in 0.51 seconds 
>> ===
>> = test session starts 
>> ==
>> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
>> plugins: cov, timeout
>> collected 7 items
>>
>> src/test/python/apache/aurora/client/cli/test_cron.py ...
>>
>> === 7 passed in 1.21 seconds 
>> ===
>> = test session starts 
>> ==
>> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
>> plugins: cov, timeout
>> collected 44 items
>>
>> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
>> src/test/python/apache/aurora/client/cli/test_create.py ..
>> src/test/python/apache/aurora/client/cli/test_diff.py ...
>> src/test/python/apache/aurora/client/cli/test_kill.py .
>> src/test/python/apache/aurora/client/cli/test_open.py .
>> src/test/python/apache/aurora/client/cli/test_restart.py .
>> src/test/python/apache/aurora/client/cli/test_status.py ...
>> src/test/python/apache/aurora/client/cli/test_update.py ...
>>
>> == 44 passed in 7.74 sec

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-28 Thread Mark Chu-Carroll 
ping?


On Fri, Jul 25, 2014 at 4:50 PM, Mark Chu-Carroll <
mchucarr...@twopensource.com> wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23949/
>   Review request for Aurora, David McLaughlin and Joe Smith.
> By Mark Chu-Carroll.
>
> *Updated July 25, 2014, 4:50 p.m.*
>  *Bugs: * aurora-603 
>  *Repository: * aurora
> Description
>
> Make testing of v1 command hooks easier.
>
> In order to be able to test v1 command hooks on real commands, it would
> be helpful to be able to mock out the body of the commands. In order to
> do this, I've separated the commands into an invocation frame, and
> the actual command implementation.
>
>   Testing
>
> ?  incubator-aurora git:(extract_killall) ? git commit -a --amend
> [extract_killall 570bd1e] Make testing of v1 command hooks easier.
>  2 files changed, 105 insertions(+), 73 deletions(-)
> ?  incubator-aurora git:(extract_killall) ./pants 
> src/test/python/apache/aurora/client:all
> Build operating on top level addresses: 
> set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
>
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
>
> === 3 passed in 0.88 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 28 items
>
> src/test/python/apache/aurora/client/api/test_updater.py 
> 
>
> == 28 passed in 0.94 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .
>
> === 5 passed in 0.76 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py 
>
> === 4 passed in 0.02 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
>
> === 3 passed in 0.72 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 10 items
>
> src/test/python/apache/aurora/client/test_config.py ..
>
> == 10 passed in 0.51 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 7 items
>
> src/test/python/apache/aurora/client/cli/test_cron.py ...
>
> === 7 passed in 1.21 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 44 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ..
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py .
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> == 44 passed in 7.74 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
> plugins: cov, timeout
> collected 2 items
>
> src/test/python/apache/a

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-25 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23949/
---

(Updated July 25, 2014, 4:50 p.m.)


Review request for Aurora, David McLaughlin and Joe Smith.


Bugs: aurora-603
https://issues.apache.org/jira/browse/aurora-603


Repository: aurora


Description
---

Make testing of v1 command hooks easier.

In order to be able to test v1 command hooks on real commands, it would
be helpful to be able to mock out the body of the commands. In order to
do this, I've separated the commands into an invocation frame, and
the actual command implementation.


Diffs
-

  src/main/python/apache/aurora/client/commands/core.py 
b4169995e996b17dda3dc09f2e5961d77e045d87 

Diff: https://reviews.apache.org/r/23949/diff/


Testing
---

?  incubator-aurora git:(extract_killall) ? git commit -a --amend
[extract_killall 570bd1e] Make testing of v1 command hooks easier.
 2 files changed, 105 insertions(+), 73 deletions(-)
?  incubator-aurora git:(extract_killall) ./pants 
src/test/python/apache/aurora/client:all
Build operating on top level addresses: 
set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 4 items

src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 

=== 4 passed in 0.58 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 3 items

src/test/python/apache/aurora/client/cli/test_config_noun.py ...

=== 3 passed in 0.88 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 28 items

src/test/python/apache/aurora/client/api/test_updater.py 


== 28 passed in 0.94 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .

=== 5 passed in 0.76 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 3 items

src/test/python/apache/aurora/client/cli/test_task_run.py ...

=== 3 passed in 0.72 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 10 items

src/test/python/apache/aurora/client/test_config.py ..

== 10 passed in 0.51 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 7 items

src/test/python/apache/aurora/client/cli/test_cron.py ...

=== 7 passed in 1.21 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 44 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ..
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py .
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 44 passed in 7.74 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

=== 2 passed in 0

Review Request 23949: Make testing of v1 command hooks easier.

2014-07-25 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23949/
---

Review request for Aurora, Joe Smith and Maxim Khutornenko.


Bugs: aurora-603
https://issues.apache.org/jira/browse/aurora-603


Repository: aurora


Description
---

Make testing of v1 command hooks easier.

In order to be able to test v1 command hooks on real commands, it would
be helpful to be able to mock out the body of the commands. In order to
do this, I've separated the commands into an invocation frame, and
the actual command implementation.


Diffs
-

  src/main/python/apache/aurora/client/commands/core.py 
b4169995e996b17dda3dc09f2e5961d77e045d87 

Diff: https://reviews.apache.org/r/23949/diff/


Testing
---

?  incubator-aurora git:(extract_killall) ? git commit -a --amend
[extract_killall 570bd1e] Make testing of v1 command hooks easier.
 2 files changed, 105 insertions(+), 73 deletions(-)
?  incubator-aurora git:(extract_killall) ./pants 
src/test/python/apache/aurora/client:all
Build operating on top level addresses: 
set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 4 items

src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 

=== 4 passed in 0.58 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 3 items

src/test/python/apache/aurora/client/cli/test_config_noun.py ...

=== 3 passed in 0.88 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 28 items

src/test/python/apache/aurora/client/api/test_updater.py 


== 28 passed in 0.94 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .

=== 5 passed in 0.76 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 3 items

src/test/python/apache/aurora/client/cli/test_task_run.py ...

=== 3 passed in 0.72 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 10 items

src/test/python/apache/aurora/client/test_config.py ..

== 10 passed in 0.51 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 7 items

src/test/python/apache/aurora/client/cli/test_cron.py ...

=== 7 passed in 1.21 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 44 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ..
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py .
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 44 passed in 7.74 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0
plugins: cov, timeout
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

=== 2 passed in 0.39 seconds