Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

2014-08-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24281/ --- Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.

Re: Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

2014-08-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24281/#review49530 ---

Re: Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

2014-08-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24281/#review49533 --- Ship it! Ship It! - Kevin Sweeney On Aug. 4, 2014, 4:30 p.m.,

Re: Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

2014-08-04 Thread Maxim Khutornenko
On Aug. 4, 2014, 11:34 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java, line 44 https://reviews.apache.org/r/24281/diff/1/?file=651305#file651305line44 Does this compile? Maxim Khutornenko wrote: Everything build and checks

Re: Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

2014-08-04 Thread Bill Farner
On Aug. 4, 2014, 11:34 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java, line 44 https://reviews.apache.org/r/24281/diff/1/?file=651305#file651305line44 Does this compile? Maxim Khutornenko wrote: Everything build and checks

Re: Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

2014-08-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24281/#review49537 --- Ship it! LGTM mod naming

Re: Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

2014-08-04 Thread Maxim Khutornenko
On Aug. 4, 2014, 11:53 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/UpdateStore.java, line 21 https://reviews.apache.org/r/24281/diff/1/?file=651307#file651307line21 Before this continues much futher, i'd love to see s/Update/JobUpdate/ to