Re: Review Request 24953: Fix bug in handling of pystachio bindings.

2014-08-21 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24953/#review51226
---

Ship it!


Ship It!

- David McLaughlin


On Aug. 21, 2014, 8:44 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24953/
> ---
> 
> (Updated Aug. 21, 2014, 8:44 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-659
> https://issues.apache.org/jira/browse/aurora-659
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Also, add new unit test to prevent regressions.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 0e10589c2e8ab6decedb12122a0d8c7a81285e18 
>   src/main/python/apache/aurora/client/cli/options.py 
> bb61dbe14e46cfab609e26e36e4e7e176d9d0e50 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> ca635bd49acec9596db67839451101a59ba4d761 
>   src/test/python/apache/aurora/client/cli/util.py 
> 552537add91a76b17736b456c78034a38940fa67 
> 
> Diff: https://reviews.apache.org/r/24953/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (fix_bindings)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD,
>  all)])
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> === 3 passed in 0.97 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .
> 
> === 5 passed in 0.95 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
> 
> === 3 passed in 0.91 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 7 items
> 
> src/test/python/apache/aurora/client/cli/test_cron.py ...
> 
> === 7 passed in 1.26 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 45 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ...
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py .
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 45 passed in 7.91 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_inspect.py .
> 
> === 1 passed in 0.73 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py 
> 
> === 4 passed in 0.79 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5

Re: Review Request 24953: Fix bug in handling of pystachio bindings.

2014-08-21 Thread Mark Chu-Carroll 


> On Aug. 21, 2014, 4:52 p.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/cli/test_create.py, lines 256-257
> > 
> >
> > Any change to add some asserts here that would verify instances_binding 
> > and cluster_binding values?

Those actually do: without the binds, the config would have invalid strings in 
it; with the binds, the config ends up complete, and the mock_query checks that 
the right values were used.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24953/#review51218
---


On Aug. 21, 2014, 4:44 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24953/
> ---
> 
> (Updated Aug. 21, 2014, 4:44 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-659
> https://issues.apache.org/jira/browse/aurora-659
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Also, add new unit test to prevent regressions.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 0e10589c2e8ab6decedb12122a0d8c7a81285e18 
>   src/main/python/apache/aurora/client/cli/options.py 
> bb61dbe14e46cfab609e26e36e4e7e176d9d0e50 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> ca635bd49acec9596db67839451101a59ba4d761 
>   src/test/python/apache/aurora/client/cli/util.py 
> 552537add91a76b17736b456c78034a38940fa67 
> 
> Diff: https://reviews.apache.org/r/24953/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (fix_bindings)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD,
>  all)])
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> === 3 passed in 0.97 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .
> 
> === 5 passed in 0.95 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
> 
> === 3 passed in 0.91 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 7 items
> 
> src/test/python/apache/aurora/client/cli/test_cron.py ...
> 
> === 7 passed in 1.26 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 45 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ...
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py .
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 45 passed in 7.91 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_inspect.py .
> 
> === 1 passed in 0.73 seconds 
> ==

Re: Review Request 24953: Fix bug in handling of pystachio bindings.

2014-08-21 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24953/#review51218
---

Ship it!



src/main/python/apache/aurora/client/cli/context.py


trailing space



src/test/python/apache/aurora/client/cli/test_create.py


Any change to add some asserts here that would verify instances_binding and 
cluster_binding values?


- Maxim Khutornenko


On Aug. 21, 2014, 8:44 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24953/
> ---
> 
> (Updated Aug. 21, 2014, 8:44 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-659
> https://issues.apache.org/jira/browse/aurora-659
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Also, add new unit test to prevent regressions.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 0e10589c2e8ab6decedb12122a0d8c7a81285e18 
>   src/main/python/apache/aurora/client/cli/options.py 
> bb61dbe14e46cfab609e26e36e4e7e176d9d0e50 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> ca635bd49acec9596db67839451101a59ba4d761 
>   src/test/python/apache/aurora/client/cli/util.py 
> 552537add91a76b17736b456c78034a38940fa67 
> 
> Diff: https://reviews.apache.org/r/24953/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (fix_bindings)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD,
>  all)])
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> 
> === 3 passed in 0.97 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .
> 
> === 5 passed in 0.95 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
> 
> === 3 passed in 0.91 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 7 items
> 
> src/test/python/apache/aurora/client/cli/test_cron.py ...
> 
> === 7 passed in 1.26 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 45 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ...
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py .
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 45 passed in 7.91 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_inspect.py .
> 
> === 1 passed in 0.73 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.23

Review Request 24953: Fix bug in handling of pystachio bindings.

2014-08-21 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24953/
---

Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Bugs: aurora-659
https://issues.apache.org/jira/browse/aurora-659


Repository: aurora


Description
---

Also, add new unit test to prevent regressions.


Diffs
-

  src/main/python/apache/aurora/client/cli/context.py 
0e10589c2e8ab6decedb12122a0d8c7a81285e18 
  src/main/python/apache/aurora/client/cli/options.py 
bb61dbe14e46cfab609e26e36e4e7e176d9d0e50 
  src/test/python/apache/aurora/client/cli/test_create.py 
ca635bd49acec9596db67839451101a59ba4d761 
  src/test/python/apache/aurora/client/cli/util.py 
552537add91a76b17736b456c78034a38940fa67 

Diff: https://reviews.apache.org/r/24953/diff/


Testing
---

[sun-wukong incubator-aurora (fix_bindings)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on top level addresses: 
set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD,
 all)])
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 3 items

src/test/python/apache/aurora/client/cli/test_config_noun.py ...

=== 3 passed in 0.97 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .

=== 5 passed in 0.95 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.03 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 3 items

src/test/python/apache/aurora/client/cli/test_task_run.py ...

=== 3 passed in 0.91 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 7 items

src/test/python/apache/aurora/client/cli/test_cron.py ...

=== 7 passed in 1.26 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 45 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ...
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py .
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ...

== 45 passed in 7.91 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 1 items

src/test/python/apache/aurora/client/cli/test_inspect.py .

=== 1 passed in 0.73 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py 

=== 4 passed in 0.79 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 4 items

src/test/python/apache/aurora/client/cli/test_plugins.py 

=== 4 passed in 0.86 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 2 items

src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..

=== 2 passed in 0.75 seconds ===
= test session starts ==
platform darwin -- Python 2.7