Re: Review Request 25309: Fix output formatting error in "job status".

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/#review52311
---

Ship it!


Ship It!

- Maxim Khutornenko


On Sept. 4, 2014, 1:24 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25309/
> ---
> 
> (Updated Sept. 4, 2014, 1:24 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-672
> https://issues.apache.org/jira/browse/aurora-672
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix output formatting error in "job status".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 311fac02af32e0ed687489a2352164effb4dba96 
> 
> Diff: https://reviews.apache.org/r/25309/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests; added new test cases.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25309: Fix output formatting error in "job status".

[Mark Chu-Carroll]

> On Sept. 4, 2014, 11:42 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 543
> > 
> >
> > Curious, why not using multiple '\t' instead of spacing?

Looking at the output with standard terminal tab settings, it was ugly. The use 
of multiple tabs just ate up too much horizontal space.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/#review52308
---


On Sept. 4, 2014, 9:24 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25309/
> ---
> 
> (Updated Sept. 4, 2014, 9:24 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-672
> https://issues.apache.org/jira/browse/aurora-672
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix output formatting error in "job status".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 311fac02af32e0ed687489a2352164effb4dba96 
> 
> Diff: https://reviews.apache.org/r/25309/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests; added new test cases.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25309: Fix output formatting error in "job status".

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/#review52308
---



src/main/python/apache/aurora/client/cli/jobs.py


Curious, why not using multiple '\t' instead of spacing?


- Maxim Khutornenko


On Sept. 4, 2014, 1:24 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25309/
> ---
> 
> (Updated Sept. 4, 2014, 1:24 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-672
> https://issues.apache.org/jira/browse/aurora-672
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix output formatting error in "job status".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 311fac02af32e0ed687489a2352164effb4dba96 
> 
> Diff: https://reviews.apache.org/r/25309/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests; added new test cases.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25309: Fix output formatting error in "job status".

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/
---

(Updated Sept. 4, 2014, 9:24 a.m.)


Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Changes
---

Poking around, I noticed several more glitches in the output formatting, and 
corrected them. Take another quick look please?


Bugs: aurora-672
https://issues.apache.org/jira/browse/aurora-672


Repository: aurora


Description
---

Fix output formatting error in "job status".


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/jobs.py 
ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
  src/test/python/apache/aurora/client/cli/test_status.py 
311fac02af32e0ed687489a2352164effb4dba96 

Diff: https://reviews.apache.org/r/25309/diff/


Testing
---

Ran unit tests; added new test cases.


Thanks,

Mark Chu-Carroll

Re: Review Request 25309: Fix output formatting error in "job status".

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/#review52257
---

Ship it!


Ship It!

- David McLaughlin


On Sept. 3, 2014, 6:17 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25309/
> ---
> 
> (Updated Sept. 3, 2014, 6:17 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-672
> https://issues.apache.org/jira/browse/aurora-672
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix output formatting error in "job status".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 311fac02af32e0ed687489a2352164effb4dba96 
> 
> Diff: https://reviews.apache.org/r/25309/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests; added new test cases.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25309: Fix output formatting error in "job status".

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/#review52212
---

Ship it!


Ship It!

- Maxim Khutornenko


On Sept. 3, 2014, 6:17 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25309/
> ---
> 
> (Updated Sept. 3, 2014, 6:17 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-672
> https://issues.apache.org/jira/browse/aurora-672
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix output formatting error in "job status".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 311fac02af32e0ed687489a2352164effb4dba96 
> 
> Diff: https://reviews.apache.org/r/25309/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests; added new test cases.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Review Request 25309: Fix output formatting error in "job status".

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/
---

Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Bugs: aurora-672
https://issues.apache.org/jira/browse/aurora-672


Repository: aurora


Description
---

Fix output formatting error in "job status".


Diffs
-

  src/main/python/apache/aurora/client/cli/jobs.py 
ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
  src/test/python/apache/aurora/client/cli/test_status.py 
311fac02af32e0ed687489a2352164effb4dba96 

Diff: https://reviews.apache.org/r/25309/diff/


Testing
---

Ran unit tests; added new test cases.


Thanks,

Mark Chu-Carroll