Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-05 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/#review52497
---

Ship it!


Ship It!

- Bill Farner


On Sept. 5, 2014, 6:47 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25357/
> ---
> 
> (Updated Sept. 5, 2014, 6:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-685
> https://issues.apache.org/jira/browse/AURORA-685
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Currently tracking LOST and FAILED states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> 6654c1675ac9f5f7d481e115cea7c224fb212467 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> d02714c846a521ff9ac3e53d991731314e714ae2 
> 
> Diff: https://reviews.apache.org/r/25357/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-05 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/
---

(Updated Sept. 5, 2014, 6:47 p.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-685
https://issues.apache.org/jira/browse/AURORA-685


Repository: aurora


Description
---

Currently tracking LOST and FAILED states.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
6654c1675ac9f5f7d481e115cea7c224fb212467 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
d02714c846a521ff9ac3e53d991731314e714ae2 

Diff: https://reviews.apache.org/r/25357/diff/


Testing
---

gradle -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-05 Thread Maxim Khutornenko 


> On Sept. 5, 2014, 3:01 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 71
> > 
> >
> > I should have been more explicit.  I would prefer that only the 
> > job-scoped vars be `untracked()`.  The others are bounded, and useful to 
> > have tracked.

I see, so you still want to view other metrics in graphview. Fine with me.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/#review52453
---


On Sept. 5, 2014, 12:23 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25357/
> ---
> 
> (Updated Sept. 5, 2014, 12:23 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-685
> https://issues.apache.org/jira/browse/AURORA-685
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Currently tracking LOST and FAILED states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> 6654c1675ac9f5f7d481e115cea7c224fb212467 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> d02714c846a521ff9ac3e53d991731314e714ae2 
> 
> Diff: https://reviews.apache.org/r/25357/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-05 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/#review52453
---



src/main/java/org/apache/aurora/scheduler/TaskVars.java


I should have been more explicit.  I would prefer that only the job-scoped 
vars be `untracked()`.  The others are bounded, and useful to have tracked.


- Bill Farner


On Sept. 5, 2014, 12:23 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25357/
> ---
> 
> (Updated Sept. 5, 2014, 12:23 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-685
> https://issues.apache.org/jira/browse/AURORA-685
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Currently tracking LOST and FAILED states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> 6654c1675ac9f5f7d481e115cea7c224fb212467 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> d02714c846a521ff9ac3e53d991731314e714ae2 
> 
> Diff: https://reviews.apache.org/r/25357/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Maxim Khutornenko 


> On Sept. 4, 2014, 11:59 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 168
> > 
> >
> > To mitigate the risk of OOM in the scheduler's internal TSDB, we should 
> > use untracked stats, similar to what's done in MetricCalculator.java.

Great suggestion, done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/#review52382
---


On Sept. 4, 2014, 9:42 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25357/
> ---
> 
> (Updated Sept. 4, 2014, 9:42 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-685
> https://issues.apache.org/jira/browse/AURORA-685
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Currently tracking LOST and FAILED states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> 6654c1675ac9f5f7d481e115cea7c224fb212467 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> d02714c846a521ff9ac3e53d991731314e714ae2 
> 
> Diff: https://reviews.apache.org/r/25357/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/
---

(Updated Sept. 5, 2014, 12:23 a.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-685
https://issues.apache.org/jira/browse/AURORA-685


Repository: aurora


Description
---

Currently tracking LOST and FAILED states.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
6654c1675ac9f5f7d481e115cea7c224fb212467 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
d02714c846a521ff9ac3e53d991731314e714ae2 

Diff: https://reviews.apache.org/r/25357/diff/


Testing
---

gradle -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/#review52382
---



src/main/java/org/apache/aurora/scheduler/TaskVars.java


To mitigate the risk of OOM in the scheduler's internal TSDB, we should use 
untracked stats, similar to what's done in MetricCalculator.java.


- Bill Farner


On Sept. 4, 2014, 9:42 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25357/
> ---
> 
> (Updated Sept. 4, 2014, 9:42 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-685
> https://issues.apache.org/jira/browse/AURORA-685
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Currently tracking LOST and FAILED states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> 6654c1675ac9f5f7d481e115cea7c224fb212467 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> d02714c846a521ff9ac3e53d991731314e714ae2 
> 
> Diff: https://reviews.apache.org/r/25357/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/#review52379
---

Ship it!


Ship It!

- David McLaughlin


On Sept. 4, 2014, 9:42 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25357/
> ---
> 
> (Updated Sept. 4, 2014, 9:42 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-685
> https://issues.apache.org/jira/browse/AURORA-685
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Currently tracking LOST and FAILED states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> 6654c1675ac9f5f7d481e115cea7c224fb212467 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> d02714c846a521ff9ac3e53d991731314e714ae2 
> 
> Diff: https://reviews.apache.org/r/25357/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/#review52362
---

Ship it!


lgtm(y still scheduler-naive eyes).


src/main/java/org/apache/aurora/scheduler/TaskVars.java


use host (declared above) here in place of 
task.getAssignedTask().getSlaveHost()?


- Joshua Cohen


On Sept. 4, 2014, 9:42 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25357/
> ---
> 
> (Updated Sept. 4, 2014, 9:42 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-685
> https://issues.apache.org/jira/browse/AURORA-685
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Currently tracking LOST and FAILED states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> 6654c1675ac9f5f7d481e115cea7c224fb212467 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> d02714c846a521ff9ac3e53d991731314e714ae2 
> 
> Diff: https://reviews.apache.org/r/25357/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357/
---

Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: AURORA-685
https://issues.apache.org/jira/browse/AURORA-685


Repository: aurora


Description
---

Currently tracking LOST and FAILED states.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
6654c1675ac9f5f7d481e115cea7c224fb212467 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
d02714c846a521ff9ac3e53d991731314e714ae2 

Diff: https://reviews.apache.org/r/25357/diff/


Testing
---

gradle -Pq build


Thanks,

Maxim Khutornenko