Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-11 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review53071 --- Ship it! Ship It! - Mark Chu-Carroll On Sept. 10, 2014, 6:43

Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/ --- Review request for Aurora, Mark Chu-Carroll and Zameer Manji. Bugs: AURORA-692

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52929 --- Ship it! Thanks for doing this so quickly. - Zameer Manji On

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52945 --- can you also add e2e test coverage? - Joe Smith On Sept. 10,

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Maxim Khutornenko
On Sept. 10, 2014, 9:09 p.m., Joe Smith wrote: can you also add e2e test coverage? Great idea. We need to start adding admin integration tests at some point and why not now: ```... == Testing Aurora Admin commands... + echo '== Getting leading scheduler' == Getting leading scheduler +

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52968 --- Ship it! Ship It! - Joe Smith On Sept. 10, 2014, 3:43 p.m.,