Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review55864 --- Patch fails to apply: % ./rbt patch -c 25835 Patch is being applied

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review55862 --- Patch fails to apply: % ./rbt patch -c 25835 Patch is being applied

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-08 Thread Bill Farner
> On Oct. 3, 2014, 4:43 p.m., Bill Farner wrote: > > Anything left to do here before Kevin commits? > > Joshua Cohen wrote: > Nope, he tried to commit but was blocked by checkstyle flagging 3rdparty > python (https://issues.apache.org/jira/browse/AURORA-780). I sent a review > out to addre

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-03 Thread Joshua Cohen
> On Oct. 3, 2014, 4:43 p.m., Bill Farner wrote: > > Anything left to do here before Kevin commits? Nope, he tried to commit but was blocked by checkstyle flagging 3rdparty python (https://issues.apache.org/jira/browse/AURORA-780). I sent a review out to address that this morning, so once that

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review55353 --- Anything left to do here before Kevin commits? - Bill Farner On S

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54996 --- Kevin pointed out in https://issues.apache.org/jira/browse/AURORA-76

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54915 --- Ship it! Ship It! - Kevin Sweeney On Sept. 19, 2014, 2:39 p.m.,

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54859 --- Ship it! Ship It! - Bill Farner On Sept. 19, 2014, 9:39 p.m., Jo

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-29 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54854 --- Ship it! Ship It! - David McLaughlin On Sept. 19, 2014, 9:39 p.m

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54825 --- I've got an updated diff for this, but reviewboard is choking when I

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54220 --- Tried this out locally and realized /graphview isn't working (404).

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
gradle and intellij actually use different classpaths to begin with. The problem was just that some of the js sources were not being included in the test classpath. On Fri, Sep 19, 2014 at 2:29 PM, Zameer Manji wrote: > This happens when gradle and IntelliJ write class files to the same > direct

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 9:39 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Zameer Manji
This happens when gradle and IntelliJ write class files to the same directory. You need to do a git clean and try again. On Fri, Sep 19, 2014 at 2:24 PM, Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54031 --- waaat... ServletFilterTest.testGzipEncoding is failing via command l

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54022 --- Ship it! Ship It! - David McLaughlin On Sept. 19, 2014, 8:45 p.m

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 8:45 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Bill Farner
> On Sept. 19, 2014, 7:41 p.m., David McLaughlin wrote: > > Reviewboard keeps crashing when I try to go back. But I was a little > > confused as to why we still need a mapping for some of the static assets? > > > > Also, for the goal of faster development iteration on the UI - it would be > >

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
> On Sept. 19, 2014, 7:41 p.m., David McLaughlin wrote: > > Reviewboard keeps crashing when I try to go back. But I was a little > > confused as to why we still need a mapping for some of the static assets? > > > > Also, for the goal of faster development iteration on the UI - it would be > >

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54002 --- Reviewboard keeps crashing when I try to go back. But I was a little

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
> On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: > > Ran locally, looks like assets are no longer gzip-encoded. Does that repro > > for you? > > Joshua Cohen wrote: > Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, > so I assumed we were ok on that front. I'll

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Bill Farner
> On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: > > Ran locally, looks like assets are no longer gzip-encoded. Does that repro > > for you? > > Joshua Cohen wrote: > Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, > so I assumed we were ok on that front. I'll

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
> On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: > > Ran locally, looks like assets are no longer gzip-encoded. Does that repro > > for you? Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, so I assumed we were ok on that front. I'll take a look once my vagrant imag

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review53990 --- Ran locally, looks like assets are no longer gzip-encoded. Does tha

Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bu