Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-08 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review55864
---


Patch fails to apply:

% ./rbt patch -c 25835
Patch is being applied from request 25835 with diff revision  4.
Failed to execute command: ['git', 'commit', '-m', u"Serve HTTP assets out of a 
standard classpath root.\n\nTesting Done:\n./gradlew build -Pq\n\nConfirmed 
everything works in scheduler UI in vagrant image.\n\nOne thing I've seen 
locally is lost tasks in vagrant, but I *think*\nthat's just due to my image 
being somehow misconfigured, and not\nthese changes. I'm going to destroy and 
rebuild the image to see if\nthat cleans things up.\n\nBugs closed: 
AURORA-678\n\nReviewed at https://reviews.apache.org/r/25835/\n";, 
u'--author="Joshua Cohen "']
Performing Python import order check.
SUCCESS
Performing Python checkstyle.
SUCCESS
On branch master

- Kevin Sweeney


On Sept. 19, 2014, 2:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 2:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/boots

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-08 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review55862
---


Patch fails to apply:

% ./rbt patch -c 25835
Patch is being applied from request 25835 with diff revision  4.
Failed to execute command: ['git', 'commit', '-m', u"Serve HTTP assets out of a 
standard classpath root.\n\nTesting Done:\n./gradlew build -Pq\n\nConfirmed 
everything works in scheduler UI in vagrant image.\n\nOne thing I've seen 
locally is lost tasks in vagrant, but I *think*\nthat's just due to my image 
being somehow misconfigured, and not\nthese changes. I'm going to destroy and 
rebuild the image to see if\nthat cleans things up.\n\nBugs closed: 
AURORA-678\n\nReviewed at https://reviews.apache.org/r/25835/\n";, 
u'--author="Joshua Cohen "']
Performing Python import order check.
SUCCESS
Performing Python checkstyle.
SUCCESS
On branch master

- Kevin Sweeney


On Sept. 19, 2014, 2:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 2:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/boots

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-08 Thread Bill Farner


> On Oct. 3, 2014, 4:43 p.m., Bill Farner wrote:
> > Anything left to do here before Kevin commits?
> 
> Joshua Cohen wrote:
> Nope, he tried to commit but was blocked by checkstyle flagging 3rdparty 
> python (https://issues.apache.org/jira/browse/AURORA-780). I sent a review 
> out to address that this morning, so once that ships he should be able to 
> merge this.

Kevin - anything else blocking this?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review55353
---


On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 9:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/g

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-03 Thread Joshua Cohen


> On Oct. 3, 2014, 4:43 p.m., Bill Farner wrote:
> > Anything left to do here before Kevin commits?

Nope, he tried to commit but was blocked by checkstyle flagging 3rdparty python 
(https://issues.apache.org/jira/browse/AURORA-780). I sent a review out to 
address that this morning, so once that ships he should be able to merge this.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review55353
---


On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 9:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_com

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-03 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review55353
---


Anything left to do here before Kevin commits?

- Bill Farner


On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 9:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>   
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  
>   
> 3rdparty/javascript/bower_components/boo

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-30 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54996
---


Kevin pointed out in https://issues.apache.org/jira/browse/AURORA-762 that the 
LICENSE file should be updated to include the dygraphs license. That seemed to 
make sense as part of this change, so I added them there and additionally 
updated the paths for all of the third party assets that were moved as part of 
this change: 
https://github.com/jcohen/incubator-aurora/commit/e5d9194992b2789b0ebfc7ac0495b575604ccc6b

- Joshua Cohen


On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 9:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/boo

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-29 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54915
---

Ship it!


Ship It!

- Kevin Sweeney


On Sept. 19, 2014, 2:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 2:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>   
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-29 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54859
---

Ship it!


Ship It!

- Bill Farner


On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 9:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>   
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-ge

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-29 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54854
---

Ship it!


Ship It!

- David McLaughlin


On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 9:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>   
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-fil

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-29 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54825
---


I've got an updated diff for this, but reviewboard is choking when I try to 
publish it. In the meantime I set up a branch at githib that should make these 
changes easier to review:

https://github.com/jcohen/incubator-aurora/commits/jcohen/static-assets

The first two commits contain all the renames (the initial mass-rename and the 
subsequent smaller rename for assets that were added mid-development).
The third commit is us forking the graphview resources from twitter commons
The fourth/final commit is the bulk of the actual code changes to get 
everything working.

- Joshua Cohen


On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 9:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-22 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54220
---


Tried this out locally and realized /graphview isn't working (404).  Can you 
look into that?

- Bill Farner


On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 9:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>   
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
gradle and intellij actually use different classpaths to begin with. The
problem was just that some of the js sources were not being included in the
test classpath.

On Fri, Sep 19, 2014 at 2:29 PM, Zameer Manji 
wrote:

> This happens when gradle and IntelliJ write class files to the same
> directory. You need to do a git clean and try again.
>
> On Fri, Sep 19, 2014 at 2:24 PM, Joshua Cohen 
> wrote:
>
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/25835/#review54031
>> ---
>>
>>
>> waaat... ServletFilterTest.testGzipEncoding is failing via command line
>> (request for /js/angular.js returns a 404) even though it's passing in
>> IntelliJ. So that's neat.
>>
>> - Joshua Cohen
>>
>>
>> On Sept. 19, 2014, 8:45 p.m., Joshua Cohen wrote:
>> >
>> > ---
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/25835/
>> > ---
>> >
>> > (Updated Sept. 19, 2014, 8:45 p.m.)
>> >
>> >
>> > Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill
>> Farner.
>> >
>> >
>> > Bugs: AURORA-678
>> > https://issues.apache.org/jira/browse/AURORA-678
>> >
>> >
>> > Repository: aurora
>> >
>> >
>> > Description
>> > ---
>> >
>> > Serve HTTP assets out of a standard claspath root.
>> >
>> > There's a lot of moved files in this diff, so apologies for it being
>> essentially unreadable. ReviewBoard actually seems to choke about half the
>> time just loading the individual pages.
>> >
>> > For the sake of convenience/sanity, the actual meat of the changes can
>> be found in:
>> >
>> > build.gradle: https://reviews.apache.org/r/25835/diff/#336
>> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java:
>> https://reviews.apache.org/r/25835/diff/1/?page=17#338
>> > src/main/resources/scheduler/assets/index.html:
>> https://reviews.apache.org/r/25835/diff/1/?page=18#363
>> >
>> > Everything else is just a rename/move.
>> >
>> >
>> > Diffs
>> > -
>> >
>> >   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json
>> >   3rdparty/javascript/bower_components/angular-bootstrap/bower.json
>> >
>>  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js
>> >
>>  
>> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>> >   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js
>> >
>>  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js
>> >   3rdparty/javascript/bower_components/angular-route/.bower.json
>> >   3rdparty/javascript/bower_components/angular-route/README.md
>> >   3rdparty/javascript/bower_components/angular-route/angular-route.js
>> >
>>  3rdparty/javascript/bower_components/angular-route/angular-route.min.js
>> >
>>  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map
>> >   3rdparty/javascript/bower_components/angular-route/bower.json
>> >   3rdparty/javascript/bower_components/angular/.bower.json
>> >   3rdparty/javascript/bower_components/angular/README.md
>> >   3rdparty/javascript/bower_components/angular/angular-csp.css
>> >   3rdparty/javascript/bower_components/angular/angular.js
>> >   3rdparty/javascript/bower_components/angular/angular.min.js
>> >   3rdparty/javascript/bower_components/angular/angular.min.js.gzip
>> >   3rdparty/javascript/bower_components/angular/angular.min.js.map
>> >   3rdparty/javascript/bower_components/angular/bower.json
>> >   3rdparty/javascript/bower_components/bootstrap/.bower.json
>> >   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js
>> >   3rdparty/javascript/bower_components/bootstrap/LICENSE
>> >   3rdparty/javascript/bower_components/bootstrap/README.md
>> >   3rdparty/javascript/bower_components/bootstrap/bower.json
>> >
>>  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css
>> >
>>  
>> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>> >
>>  
>> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>> >   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css
>> >
>>  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map
>> >
>>  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css
>> >
>>  
>> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>> >
>>  
>> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>> >
>>  
>> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>> >
>>  
>> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>> >   3rdparty/javascript/bower_components/bootstrap/dist/j

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/
---

(Updated Sept. 19, 2014, 9:39 p.m.)


Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.


Changes
---

Added generated/3rdparty js to test classpath.


Bugs: AURORA-678
https://issues.apache.org/jira/browse/AURORA-678


Repository: aurora


Description
---

Serve HTTP assets out of a standard claspath root.

There's a lot of moved files in this diff, so apologies for it being 
essentially unreadable. ReviewBoard actually seems to choke about half the time 
just loading the individual pages.

For the sake of convenience/sanity, the actual meat of the changes can be found 
in:

build.gradle: https://reviews.apache.org/r/25835/diff/#336
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
https://reviews.apache.org/r/25835/diff/1/?page=17#338
src/main/resources/scheduler/assets/index.html: 
https://reviews.apache.org/r/25835/diff/1/?page=18#363

Everything else is just a rename/move.


Diffs (updated)
-

  3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
  3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js  
  
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 
 
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
  3rdparty/javascript/bower_components/angular-route/.bower.json  
  3rdparty/javascript/bower_components/angular-route/README.md  
  3rdparty/javascript/bower_components/angular-route/angular-route.js  
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map  
  3rdparty/javascript/bower_components/angular-route/bower.json  
  3rdparty/javascript/bower_components/angular/.bower.json  
  3rdparty/javascript/bower_components/angular/README.md  
  3rdparty/javascript/bower_components/angular/angular-csp.css  
  3rdparty/javascript/bower_components/angular/angular.js  
  3rdparty/javascript/bower_components/angular/angular.min.js  
  3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
  3rdparty/javascript/bower_components/angular/angular.min.js.map  
  3rdparty/javascript/bower_components/angular/bower.json  
  3rdparty/javascript/bower_components/bootstrap/.bower.json  
  3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
  3rdparty/javascript/bower_components/bootstrap/LICENSE  
  3rdparty/javascript/bower_components/bootstrap/README.md  
  3rdparty/javascript/bower_components/bootstrap/bower.json  
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css  
  
3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 
 
  
3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 
 
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
  
  3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
  3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
  
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
  
  3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js  
  3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js  
  3rdparty/javascript/bower_components/bootstrap/js/affix.js  
  3rdparty/javascript/bower_components/bootstrap/js/alert.js  
  3rdparty/javascript/bower_components/bootstrap/js/button.js  
  3rdparty/javascript/bower_components/bootstrap/js/carousel.js  
  3rdparty/javascript/bower_components/bootstrap/js/collapse.js  
  3rdparty/javascript/bower_components/bootstrap/js/dropdown.js  
  

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Zameer Manji
This happens when gradle and IntelliJ write class files to the same
directory. You need to do a git clean and try again.

On Fri, Sep 19, 2014 at 2:24 PM, Joshua Cohen 
wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/#review54031
> ---
>
>
> waaat... ServletFilterTest.testGzipEncoding is failing via command line
> (request for /js/angular.js returns a 404) even though it's passing in
> IntelliJ. So that's neat.
>
> - Joshua Cohen
>
>
> On Sept. 19, 2014, 8:45 p.m., Joshua Cohen wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/25835/
> > ---
> >
> > (Updated Sept. 19, 2014, 8:45 p.m.)
> >
> >
> > Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill
> Farner.
> >
> >
> > Bugs: AURORA-678
> > https://issues.apache.org/jira/browse/AURORA-678
> >
> >
> > Repository: aurora
> >
> >
> > Description
> > ---
> >
> > Serve HTTP assets out of a standard claspath root.
> >
> > There's a lot of moved files in this diff, so apologies for it being
> essentially unreadable. ReviewBoard actually seems to choke about half the
> time just loading the individual pages.
> >
> > For the sake of convenience/sanity, the actual meat of the changes can
> be found in:
> >
> > build.gradle: https://reviews.apache.org/r/25835/diff/#336
> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java:
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> > src/main/resources/scheduler/assets/index.html:
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> >
> > Everything else is just a rename/move.
> >
> >
> > Diffs
> > -
> >
> >   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json
> >   3rdparty/javascript/bower_components/angular-bootstrap/bower.json
> >
>  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js
> >
>  
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
> >   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js
> >
>  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js
> >   3rdparty/javascript/bower_components/angular-route/.bower.json
> >   3rdparty/javascript/bower_components/angular-route/README.md
> >   3rdparty/javascript/bower_components/angular-route/angular-route.js
> >   3rdparty/javascript/bower_components/angular-route/angular-route.min.js
> >
>  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map
> >   3rdparty/javascript/bower_components/angular-route/bower.json
> >   3rdparty/javascript/bower_components/angular/.bower.json
> >   3rdparty/javascript/bower_components/angular/README.md
> >   3rdparty/javascript/bower_components/angular/angular-csp.css
> >   3rdparty/javascript/bower_components/angular/angular.js
> >   3rdparty/javascript/bower_components/angular/angular.min.js
> >   3rdparty/javascript/bower_components/angular/angular.min.js.gzip
> >   3rdparty/javascript/bower_components/angular/angular.min.js.map
> >   3rdparty/javascript/bower_components/angular/bower.json
> >   3rdparty/javascript/bower_components/bootstrap/.bower.json
> >   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js
> >   3rdparty/javascript/bower_components/bootstrap/LICENSE
> >   3rdparty/javascript/bower_components/bootstrap/README.md
> >   3rdparty/javascript/bower_components/bootstrap/bower.json
> >
>  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css
> >
>  
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
> >
>  
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
> >   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css
> >
>  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map
> >
>  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css
> >
>  
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
> >
>  
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
> >
>  
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
> >
>  
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
> >   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js
> >   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js
> >
>  
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
> >
>  
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
> >
>  
> 3rdparty/javascript/bower_components/bootstrap/fonts/

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54031
---


waaat... ServletFilterTest.testGzipEncoding is failing via command line 
(request for /js/angular.js returns a 404) even though it's passing in 
IntelliJ. So that's neat.

- Joshua Cohen


On Sept. 19, 2014, 8:45 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 8:45 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>   
> 

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54022
---

Ship it!


Ship It!

- David McLaughlin


On Sept. 19, 2014, 8:45 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 8:45 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>   
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-fil

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/
---

(Updated Sept. 19, 2014, 8:45 p.m.)


Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.


Changes
---

Apply gzip to static assets.


Bugs: AURORA-678
https://issues.apache.org/jira/browse/AURORA-678


Repository: aurora


Description
---

Serve HTTP assets out of a standard claspath root.

There's a lot of moved files in this diff, so apologies for it being 
essentially unreadable. ReviewBoard actually seems to choke about half the time 
just loading the individual pages.

For the sake of convenience/sanity, the actual meat of the changes can be found 
in:

build.gradle: https://reviews.apache.org/r/25835/diff/#336
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
https://reviews.apache.org/r/25835/diff/1/?page=17#338
src/main/resources/scheduler/assets/index.html: 
https://reviews.apache.org/r/25835/diff/1/?page=18#363

Everything else is just a rename/move.


Diffs (updated)
-

  3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
  3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js  
  
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 
 
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
  3rdparty/javascript/bower_components/angular-route/.bower.json  
  3rdparty/javascript/bower_components/angular-route/README.md  
  3rdparty/javascript/bower_components/angular-route/angular-route.js  
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map  
  3rdparty/javascript/bower_components/angular-route/bower.json  
  3rdparty/javascript/bower_components/angular/.bower.json  
  3rdparty/javascript/bower_components/angular/README.md  
  3rdparty/javascript/bower_components/angular/angular-csp.css  
  3rdparty/javascript/bower_components/angular/angular.js  
  3rdparty/javascript/bower_components/angular/angular.min.js  
  3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
  3rdparty/javascript/bower_components/angular/angular.min.js.map  
  3rdparty/javascript/bower_components/angular/bower.json  
  3rdparty/javascript/bower_components/bootstrap/.bower.json  
  3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
  3rdparty/javascript/bower_components/bootstrap/LICENSE  
  3rdparty/javascript/bower_components/bootstrap/README.md  
  3rdparty/javascript/bower_components/bootstrap/bower.json  
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css  
  
3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 
 
  
3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 
 
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
  
  3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
  3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
  
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
  
  3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js  
  3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js  
  3rdparty/javascript/bower_components/bootstrap/js/affix.js  
  3rdparty/javascript/bower_components/bootstrap/js/alert.js  
  3rdparty/javascript/bower_components/bootstrap/js/button.js  
  3rdparty/javascript/bower_components/bootstrap/js/carousel.js  
  3rdparty/javascript/bower_components/bootstrap/js/collapse.js  
  3rdparty/javascript/bower_components/bootstrap/js/dropdown.js  
  3rdparty/javascrip

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Bill Farner


> On Sept. 19, 2014, 7:41 p.m., David McLaughlin wrote:
> > Reviewboard keeps crashing when I try to go back. But I was a little 
> > confused as to why we still need a mapping for some of the static assets? 
> > 
> > Also, for the goal of faster development iteration on the UI - it would be 
> > good to get some docs on expected steps when hacking on the UI in the 
> > vagrant image.
> 
> Joshua Cohen wrote:
> The mapping is just an intermediate stage, because some files are 
> referenced at names/paths that don't match their actual location under the 
> resource root. We'll need to either change the UI to reference them at their 
> actual name/path, or change the name/path from which they are served.
> 
> I'm honestly not sure *what* the steps are for faster development cycle 
> after this change though. The resources are still served out of a jar, which 
> means that jarfile needs to be rebuilt to pick up changes...
> 
> I haven't had a chance to investigate what's involved in actually serving 
> live assets yet, but Bill, I think you had some future changes in mind to get 
> us there?

My primary goal here was to simplify HTTP server configuration code.  I see 
this as a stepping-stone to simpler UI development, but surrounding tooling is 
probably not quite ready for it yet.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54002
---


On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 6:41 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen


> On Sept. 19, 2014, 7:41 p.m., David McLaughlin wrote:
> > Reviewboard keeps crashing when I try to go back. But I was a little 
> > confused as to why we still need a mapping for some of the static assets? 
> > 
> > Also, for the goal of faster development iteration on the UI - it would be 
> > good to get some docs on expected steps when hacking on the UI in the 
> > vagrant image.

The mapping is just an intermediate stage, because some files are referenced at 
names/paths that don't match their actual location under the resource root. 
We'll need to either change the UI to reference them at their actual name/path, 
or change the name/path from which they are served.

I'm honestly not sure *what* the steps are for faster development cycle after 
this change though. The resources are still served out of a jar, which means 
that jarfile needs to be rebuilt to pick up changes...

I haven't had a chance to investigate what's involved in actually serving live 
assets yet, but Bill, I think you had some future changes in mind to get us 
there?


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54002
---


On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 6:41 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphi

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review54002
---


Reviewboard keeps crashing when I try to go back. But I was a little confused 
as to why we still need a mapping for some of the static assets? 

Also, for the goal of faster development iteration on the UI - it would be good 
to get some docs on expected steps when hacking on the UI in the vagrant image.

- David McLaughlin


On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 6:41 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/font

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen


> On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote:
> > Ran locally, looks like assets are no longer gzip-encoded.  Does that repro 
> > for you?
> 
> Joshua Cohen wrote:
> Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, 
> so I assumed we were ok on that front. I'll take a look once my vagrant image 
> is back up and running.
> 
> Bill Farner wrote:
> Looks like we don't have a test case that fetches an asset.  Can you add 
> a test case that fetches /js/angular.js, verifying gzip?

Yep, will do.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review53990
---


On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 6:41 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Bill Farner


> On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote:
> > Ran locally, looks like assets are no longer gzip-encoded.  Does that repro 
> > for you?
> 
> Joshua Cohen wrote:
> Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, 
> so I assumed we were ok on that front. I'll take a look once my vagrant image 
> is back up and running.

Looks like we don't have a test case that fetches an asset.  Can you add a test 
case that fetches /js/angular.js, verifying gzip?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review53990
---


On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 6:41 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen


> On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote:
> > Ran locally, looks like assets are no longer gzip-encoded.  Does that repro 
> > for you?

Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, so I 
assumed we were ok on that front. I'll take a look once my vagrant image is 
back up and running.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review53990
---


On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 6:41 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/boots

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review53990
---


Ran locally, looks like assets are no longer gzip-encoded.  Does that repro for 
you?

- Bill Farner


On Sept. 19, 2014, 6:41 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25835/
> ---
> 
> (Updated Sept. 19, 2014, 6:41 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-678
> https://issues.apache.org/jira/browse/AURORA-678
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Serve HTTP assets out of a standard claspath root.
> 
> There's a lot of moved files in this diff, so apologies for it being 
> essentially unreadable. ReviewBoard actually seems to choke about half the 
> time just loading the individual pages.
> 
> For the sake of convenience/sanity, the actual meat of the changes can be 
> found in:
> 
> build.gradle: https://reviews.apache.org/r/25835/diff/#336
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
> https://reviews.apache.org/r/25835/diff/1/?page=17#338
> src/main/resources/scheduler/assets/index.html: 
> https://reviews.apache.org/r/25835/diff/1/?page=18#363
> 
> Everything else is just a rename/move.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 
>  
>   
> 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js
>   
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
>   3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
>   3rdparty/javascript/bower_components/angular-route/.bower.json  
>   3rdparty/javascript/bower_components/angular-route/README.md  
>   3rdparty/javascript/bower_components/angular-route/angular-route.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 
>  
>   3rdparty/javascript/bower_components/angular-route/bower.json  
>   3rdparty/javascript/bower_components/angular/.bower.json  
>   3rdparty/javascript/bower_components/angular/README.md  
>   3rdparty/javascript/bower_components/angular/angular-csp.css  
>   3rdparty/javascript/bower_components/angular/angular.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js  
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
>   3rdparty/javascript/bower_components/angular/angular.min.js.map  
>   3rdparty/javascript/bower_components/angular/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/.bower.json  
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
>   3rdparty/javascript/bower_components/bootstrap/LICENSE  
>   3rdparty/javascript/bower_components/bootstrap/README.md  
>   3rdparty/javascript/bower_components/bootstrap/bower.json  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 
>  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
>   3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
>   
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
>   3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>   
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  
>   
> 3

Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/
---

Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.


Bugs: AURORA-678
https://issues.apache.org/jira/browse/AURORA-678


Repository: aurora


Description
---

Serve HTTP assets out of a standard claspath root.

There's a lot of moved files in this diff, so apologies for it being 
essentially unreadable. ReviewBoard actually seems to choke about half the time 
just loading the individual pages.

For the sake of convenience/sanity, the actual meat of the changes can be found 
in:

build.gradle: https://reviews.apache.org/r/25835/diff/#336
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: 
https://reviews.apache.org/r/25835/diff/1/?page=17#338
src/main/resources/scheduler/assets/index.html: 
https://reviews.apache.org/r/25835/diff/1/?page=18#363

Everything else is just a rename/move.


Diffs
-

  3rdparty/javascript/bower_components/angular-bootstrap/.bower.json  
  3rdparty/javascript/bower_components/angular-bootstrap/bower.json  
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js  
  
3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 
 
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js  
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js  
  3rdparty/javascript/bower_components/angular-route/.bower.json  
  3rdparty/javascript/bower_components/angular-route/README.md  
  3rdparty/javascript/bower_components/angular-route/angular-route.js  
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js  
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map  
  3rdparty/javascript/bower_components/angular-route/bower.json  
  3rdparty/javascript/bower_components/angular/.bower.json  
  3rdparty/javascript/bower_components/angular/README.md  
  3rdparty/javascript/bower_components/angular/angular-csp.css  
  3rdparty/javascript/bower_components/angular/angular.js  
  3rdparty/javascript/bower_components/angular/angular.min.js  
  3rdparty/javascript/bower_components/angular/angular.min.js.gzip  
  3rdparty/javascript/bower_components/angular/angular.min.js.map  
  3rdparty/javascript/bower_components/angular/bower.json  
  3rdparty/javascript/bower_components/bootstrap/.bower.json  
  3rdparty/javascript/bower_components/bootstrap/Gruntfile.js  
  3rdparty/javascript/bower_components/bootstrap/LICENSE  
  3rdparty/javascript/bower_components/bootstrap/README.md  
  3rdparty/javascript/bower_components/bootstrap/bower.json  
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css  
  
3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 
 
  
3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 
 
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css  
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map  
  3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg
  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf
  
  
3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff
  
  3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js  
  3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
  
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
  
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
  
  3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js  
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js  
  3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js  
  3rdparty/javascript/bower_components/bootstrap/js/affix.js  
  3rdparty/javascript/bower_components/bootstrap/js/alert.js  
  3rdparty/javascript/bower_components/bootstrap/js/button.js  
  3rdparty/javascript/bower_components/bootstrap/js/carousel.js  
  3rdparty/javascript/bower_components/bootstrap/js/collapse.js  
  3rdparty/javascript/bower_components/bootstrap/js/dropdown.js  
  3rdparty/javascript/bower_components/bootstrap/js/modal.js  
  3rdparty/javascript/bower_components/bootstrap/js/p