Re: Review Request 25857: Disable updater by default in prod.

2014-09-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 23, 2014, 1:12 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25857: Disable updater by default in prod.

2014-09-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/#review54216 --- Ship it! Thanks! - Bill Farner On Sept. 22, 2014, 8:41 p.m., Max

Re: Review Request 25857: Disable updater by default in prod.

2014-09-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 22, 2014, 8:41 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25857: Disable updater by default in prod.

2014-09-22 Thread Maxim Khutornenko
> On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1375 > > > > > > How about: > > > > return addMessage( > >

Re: Review Request 25857: Disable updater by default in prod.

2014-09-22 Thread Bill Farner
> On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 286 > > > > > > I see why you went this route, but it's a precedent i

Re: Review Request 25857: Disable updater by default in prod.

2014-09-22 Thread Maxim Khutornenko
> On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 286 > > > > > > I see why you went this route, but it's a precedent i

Re: Review Request 25857: Disable updater by default in prod.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/#review54071 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Re: Review Request 25857: Disable updater by default in prod.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 19, 2014, 11:10 p.m.) Review request for Aurora and Bill Farner.

Review Request 25857: Disable updater by default in prod.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-732 https://issues.