---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/
---
(Updated Sept. 29, 2014, 8:04 p.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/
---
(Updated Sept. 29, 2014, 10:57 p.m.)
Review request for Aurora and Bill
On Sept. 29, 2014, 8:12 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java, line 88
https://reviews.apache.org/r/26102/diff/2/?file=708338#file708338line88
Your call on whether this makes things more readable, but i could
imagine some cleanup
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54911
---
Ship it!
On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java, line 197
https://reviews.apache.org/r/26102/diff/3/?file=708816#file708816line197
Adding optional here seems circuitous. Why not avoid calling `asMap`
if `config` is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/
---
(Updated Sept. 29, 2014, 11:32 p.m.)
Review request for Aurora and Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54919
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-756
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54751
---
On Sept. 26, 2014, 11:35 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java, line
724
https://reviews.apache.org/r/26102/diff/1/?file=706432#file706432line724
IIUC you could also trip this with an update that reduces the instance
count
10 matches
Mail list logo
