subject:"Review Request 26123\: Fail the build on lack of test coverage."

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-29 Thread Bill Farner

On Sept. 28, 2014, 4:05 a.m., Joshua Cohen wrote: build.gradle, line 571 https://reviews.apache.org/r/26123/diff/1/?file=707768#file707768line571 This seems like a potentially harsh penalty for good behavior if someone has to go from 0 to $MIN_COVERAGE in one go... I

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-29 Thread Bill Farner

On Sept. 27, 2014, 11:38 p.m., Zameer Manji wrote: Once this is commited, please make tickets for adding tests to these classes. I'm not sure how to best do this without either creating a ton of tickets that are bound to be forgotten, or a monster ticket that is difficult to track. Any

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-29 Thread Zameer Manji

On Sept. 27, 2014, 4:38 p.m., Zameer Manji wrote: Once this is commited, please make tickets for adding tests to these classes. Bill Farner wrote: I'm not sure how to best do this without either creating a ton of tickets that are bound to be forgotten, or a monster ticket that is

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-29 Thread Bill Farner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 29, 2014, 9:10 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-29 Thread Kevin Sweeney

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54902 --- Ship it! Ship It! - Kevin Sweeney On Sept. 29, 2014, 2:10 p.m.,

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-29 Thread Joshua Cohen

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54908 --- Ship it! Thanks for clarifying the assert message. - Joshua Cohen

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-29 Thread Bill Farner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 29, 2014, 11:33 p.m.) Review request for Aurora, Joshua Cohen,

Review Request 26123: Fail the build on lack of test coverage.

2014-09-27 Thread Bill Farner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko.

Re: Review Request 26123: Fail the build on lack of test coverage.

2014-09-27 Thread Zameer Manji

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54771 --- Once this is commited, please make tickets for adding tests to