Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/ --- (Updated Oct. 17, 2014, 8:02 p.m.) Review request for Aurora, Joe Smith and Mar

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-17 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/#review57177 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 8, 2014, 7:46 p.m.,

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/#review56561 --- Mark? - Maxim Khutornenko On Oct. 8, 2014, 11:46 p.m., Maxim Khut

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/#review56076 --- Ping, Mark. - Maxim Khutornenko On Oct. 8, 2014, 11:46 p.m., Maxi

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/#review55911 --- Ship it! Thanks! - Joe Smith On Oct. 8, 2014, 4:46 p.m., Maxim K

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/ --- (Updated Oct. 8, 2014, 11:46 p.m.) Review request for Aurora, Joe Smith and Mar

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-08 Thread Maxim Khutornenko
> On Oct. 8, 2014, 7:08 p.m., Joe Smith wrote: > > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 117 > > > > > > can this be a mock that we assert gets called 3 times? > > > > (This t

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/#review55859 --- src/test/python/apache/aurora/client/commands/test_maintenance.py <

Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/ --- Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-806