Re: Review Request 26849: Remove LogModule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26849/ --- (Updated Oct. 17, 2014, 2 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- This gets rid of the confusing the `log_dir` command line argument. Diffs (updated) - build.gradle 26925df93f357824efe260eeedb43a6ee4ec5161 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 40b652c679d8e340f585e28cbed066335d9d760d src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java e24de79f81fab526f3d647768310cf3c070ab226 Diff: https://reviews.apache.org/r/26849/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26849: Remove LogModule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26849/#review57095 --- Ship it! Ship It! - Kevin Sweeney On Oct. 16, 2014, 6:51 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26849/ > --- > > (Updated Oct. 16, 2014, 6:51 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > --- > > This gets rid of the confusing the `log_dir` command line argument. > > > Diffs > - > > build.gradle 26925df93f357824efe260eeedb43a6ee4ec5161 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 40b652c679d8e340f585e28cbed066335d9d760d > src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java > e24de79f81fab526f3d647768310cf3c070ab226 > > Diff: https://reviews.apache.org/r/26849/diff/ > > > Testing > --- > > ./gradlew build -Pq > > > Thanks, > > Bill Farner > >
Re: Review Request 26849: Remove LogModule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26849/ --- (Updated Oct. 17, 2014, 1:51 a.m.) Review request for Aurora and Kevin Sweeney. Changes --- Ready for review. Repository: aurora Description (updated) --- This gets rid of the confusing the `log_dir` command line argument. Diffs (updated) - build.gradle 26925df93f357824efe260eeedb43a6ee4ec5161 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 40b652c679d8e340f585e28cbed066335d9d760d src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java e24de79f81fab526f3d647768310cf3c070ab226 Diff: https://reviews.apache.org/r/26849/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26849: Remove LogModule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26849/ --- (Updated Oct. 17, 2014, 1:40 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description (updated) --- This gets rid of the confusing the `log_dir` command line argument. TODO: just noticed this changed the log format when running in vagrant, need to fix before doing anything with this diff. Diffs - build.gradle 26925df93f357824efe260eeedb43a6ee4ec5161 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 40b652c679d8e340f585e28cbed066335d9d760d src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java e24de79f81fab526f3d647768310cf3c070ab226 Diff: https://reviews.apache.org/r/26849/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Review Request 26849: Remove LogModule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26849/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- This gets rid of the confusing the `log_dir` command line argument. Diffs - build.gradle 26925df93f357824efe260eeedb43a6ee4ec5161 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 40b652c679d8e340f585e28cbed066335d9d760d src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java e24de79f81fab526f3d647768310cf3c070ab226 Diff: https://reviews.apache.org/r/26849/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
