Re: Review Request 27145: Add a script that publishes build results to review board.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58299 --- Does it make sense to use the ReviewBoard Python client from rbtools? https://www.reviewboard.org/docs/rbtools/0.5/api/overview/ What is the plan to actually run this script? Is it safe to assume that it will be executed from an up to date git repo, or will it need to git pull? build-support/jenkins/review_feedback.py https://reviews.apache.org/r/27145/#comment99248 Our Python continuation indent style is generally the same as our Java style, so these should be indented 4 past the parent, not aligned? - Joshua Cohen On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 5:32 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58301 --- Ship it! build-support/jenkins/review_feedback.py https://reviews.apache.org/r/27145/#comment99252 replace with ternary? build-support/jenkins/review_feedback.py https://reviews.apache.org/r/27145/#comment99253 Is there a legitimate case to allow non 200 response code here? build-support/jenkins/review_feedback.py https://reviews.apache.org/r/27145/#comment99254 Combine with the above print? - Maxim Khutornenko On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 5:32 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
On Oct. 24, 2014, 5:57 p.m., Joshua Cohen wrote: Does it make sense to use the ReviewBoard Python client from rbtools? https://www.reviewboard.org/docs/rbtools/0.5/api/overview/ What is the plan to actually run this script? Is it safe to assume that it will be executed from an up to date git repo, or will it need to git pull? I'm hesitant, mostly because i don't think the code savings is worth the cost of adding build infrastructure around this script. I could be swayed, though. On Oct. 24, 2014, 5:57 p.m., Joshua Cohen wrote: build-support/jenkins/review_feedback.py, lines 98-100 https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line98 Our Python continuation indent style is generally the same as our Java style, so these should be indented 4 past the parent, not aligned? Fixed. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58299 --- On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 5:32 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
On Oct. 24, 2014, 5:57 p.m., Joshua Cohen wrote: Does it make sense to use the ReviewBoard Python client from rbtools? https://www.reviewboard.org/docs/rbtools/0.5/api/overview/ What is the plan to actually run this script? Is it safe to assume that it will be executed from an up to date git repo, or will it need to git pull? Bill Farner wrote: I'm hesitant, mostly because i don't think the code savings is worth the cost of adding build infrastructure around this script. I could be swayed, though. Yeah, I'm not sure it's worth it either, but figured it's worth mentioning. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58299 --- On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 5:32 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote: build-support/jenkins/review_feedback.py, line 39 https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line39 Use print() as a function, here and throughout Done. On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote: build-support/jenkins/review_feedback.py, line 94 https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line94 as we're on python2.7 you can use argparse now (which removes some boilerplate and gives nicer errors) Thanks, done. On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote: build-support/jenkins/review_feedback.py, line 97 https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line97 read this from a file? argparse makes this easy Sure, done. On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote: build-support/jenkins/review_feedback.py, line 116 https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line116 with argparse you can just do required=True Done, thanks again. On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote: build-support/jenkins/review_feedback.py, line 149 https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line149 Would the correct Apache exclaimation be +1 here? Sure, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58338 --- On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 5:32 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
On Oct. 24, 2014, 8:57 p.m., Maxim Khutornenko wrote: build-support/jenkins/review_feedback.py, lines 37-38 https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line37 replace with ternary? Done. On Oct. 24, 2014, 8:57 p.m., Maxim Khutornenko wrote: build-support/jenkins/review_feedback.py, line 45 https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line45 Is there a legitimate case to allow non 200 response code here? 201 for POST. On Oct. 24, 2014, 8:57 p.m., Maxim Khutornenko wrote: build-support/jenkins/review_feedback.py, line 47 https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line47 Combine with the above print? Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58301 --- On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 5:32 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 9:42 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs (updated) - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58391 --- Ship it! Can you document your exit codes somewhere? - Zameer Manji On Oct. 24, 2014, 2:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 2:42 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58392 --- +1: Master (5be667f) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Oct. 24, 2014, 9:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 9:42 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58396 --- Ship it! Ship It! - Joshua Cohen On Oct. 24, 2014, 9:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 9:42 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
On Oct. 24, 2014, 2:49 p.m., Zameer Manji wrote: Can you document your exit codes somewhere? Bill Farner wrote: Is that worthwhile? If it means documenting, i'd rather not vary them at all. I don't think this is something that should be scripted against. I asumed you varried them for a reason. If you are not scripting against them then just do sys.exit(1) otherwise it is confusing IMHO. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58391 --- On Oct. 24, 2014, 2:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 2:42 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
On Oct. 24, 2014, 9:49 p.m., Zameer Manji wrote: Can you document your exit codes somewhere? Bill Farner wrote: Is that worthwhile? If it means documenting, i'd rather not vary them at all. I don't think this is something that should be scripted against. Zameer Manji wrote: I asumed you varried them for a reason. If you are not scripting against them then just do sys.exit(1) otherwise it is confusing IMHO. Agreed, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58391 --- On Oct. 24, 2014, 9:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 9:42 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 10:42 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs (updated) - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
Re: Review Request 27145: Add a script that publishes build results to review board.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58423 --- +1: Master (f98bec7) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Oct. 24, 2014, 10:42 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/ --- (Updated Oct. 24, 2014, 10:42 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-883 https://issues.apache.org/jira/browse/AURORA-883 Repository: aurora Description --- I also removed `--stacktrace` from the gradle command. This makes for better tail output. I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/ Diffs - build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 build-support/jenkins/review_feedback.py PRE-CREATION Diff: https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner
