Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59223 --- Ship it! Master (d85e616) is green with this patch. ./build-suppo

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 30, 2014, 4:39 p.m.) Review request for Aurora, Jake Farrell and

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-30 Thread Bill Farner
> On Oct. 29, 2014, 11:49 p.m., Kevin Sweeney wrote: > > Would this be a good time to suggest moving these to src/test/resources to > > match other conventions? As far as I can tell it should be a quick sed > > one-liner. > > Jake Farrell wrote: > +1 Good call, done. - Bill --

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59111 --- Ship it! Ship It! - Jake Farrell On Oct. 29, 2014, 11:38 p.m., B

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Jake Farrell
> On Oct. 29, 2014, 11:49 p.m., Kevin Sweeney wrote: > > Would this be a good time to suggest moving these to src/test/resources to > > match other conventions? As far as I can tell it should be a quick sed > > one-liner. +1 - Jake --

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59081 --- Ship it! Master (6b30cf7) is green with this patch. ./build-suppo

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59080 --- Would this be a good time to suggest moving these to src/test/resour

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 11:38 p.m.) Review request for Aurora, Jake Farrell and

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Bill Farner
> On Oct. 29, 2014, 11:32 p.m., Maxim Khutornenko wrote: > > Consider adding a README file under > > /src/resources/org/apache/thermos/root/checkpoints with the link to this > > document to improve discoverablity. Good call, done. - Bill

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59076 --- Ship it! Master (6b30cf7) is green with this patch. ./build-suppo

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59074 --- Ship it! Consider adding a README file under /src/resources/org/ap

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59072 --- Ship it! Ship It! - Kevin Sweeney On Oct. 29, 2014, 4:19 p.m., B

Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711