Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs:

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60402 --- Ship it! Master (03cb0d1) is green with this patch.

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60398 --- src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60400 --- Ship it!

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
On Nov. 7, 2014, 10:39 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java, line 123 https://reviews.apache.org/r/27746/diff/1/?file=754888#file754888line123 LOG.info(Retrying for ... in ...) Done. On Nov. 7, 2014, 10:39 p.m., Maxim

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
On Nov. 7, 2014, 10:47 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java, line 326 https://reviews.apache.org/r/27746/diff/1/?file=754879#file754879line326 typo in blockUntilStopped Fixed. On Nov. 7, 2014, 10:47 p.m., Kevin Sweeney

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/ --- (Updated Nov. 7, 2014, 11:05 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60413 --- Master (03cb0d1) is red with this patch.

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/ --- (Updated Nov. 7, 2014, 10:59 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60414 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 7, 2014, 11:05

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Kevin Sweeney
On Nov. 7, 2014, 2:39 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java, line 123 https://reviews.apache.org/r/27746/diff/1/?file=754888#file754888line123 LOG.info(Retrying for ... in ...) Bill Farner wrote: Done. Not worth such

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
On Nov. 7, 2014, 10:39 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java, line 123 https://reviews.apache.org/r/27746/diff/1/?file=754888#file754888line123 LOG.info(Retrying for ... in ...) Bill Farner wrote: Done. Kevin