Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Kevin Sweeney
> On Dec. 2, 2014, 11:30 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java, > > line 67 > > > > > > Citation needed? Iterables.transform generates a lazy vie

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63574 --- Ship it! Ship It! - Kevin Sweeney On Dec. 2, 2014, 11:04 a.m., B

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Bill Farner
> On Dec. 2, 2014, 7:30 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java, > > line 67 > > > > > > Citation needed? Iterables.transform generates a lazy view

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63566 --- src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClust

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63562 --- Ship it! Master (d476e2a) is green with this patch. ./build-suppo

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/ --- (Updated Dec. 2, 2014, 7:04 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Bill Farner
> On Dec. 2, 2014, 2:35 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java, > > line 71 > > > > > > Please, drop the now unused TASK_TO_SLAVE_ID. Thanks,

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63489 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/preemptor

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63446 --- Ship it! Ship It! - Zameer Manji On Dec. 1, 2014, 12:32 p.m., Bi

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63436 --- Ship it! Master (88baad6) is green with this patch. ./build-suppo

Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-121