Review Request 28621: Prevent Aurora from creating tasks with 0 disk.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-956 https://issues.apache.org/jira/browse/AURORA-956 Repository: aurora Description --- Prevent Aurora from creating tasks with 0 disk. Diffs - src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e0332c0729b3858d397d9f2c1497caf08daa3c2d src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28621/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/#review63628 --- Ship it! src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java https://reviews.apache.org/r/28621/#comment105907 can i get an oxford comma? :-) - Bill Farner On Dec. 3, 2014, 1:32 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/ --- (Updated Dec. 3, 2014, 1:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-956 https://issues.apache.org/jira/browse/AURORA-956 Repository: aurora Description --- Prevent Aurora from creating tasks with 0 disk. Diffs - src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e0332c0729b3858d397d9f2c1497caf08daa3c2d src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28621/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/ --- (Updated Dec. 2, 2014, 5:43 p.m.) Review request for Aurora and Bill Farner. Changes --- Add comma. Bugs: AURORA-956 https://issues.apache.org/jira/browse/AURORA-956 Repository: aurora Description --- Prevent Aurora from creating tasks with 0 disk. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e0332c0729b3858d397d9f2c1497caf08daa3c2d src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28621/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/ --- (Updated Dec. 2, 2014, 5:45 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-956 https://issues.apache.org/jira/browse/AURORA-956 Repository: aurora Description --- Prevent Aurora from creating tasks with 0 disk. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e0332c0729b3858d397d9f2c1497caf08daa3c2d src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28621/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/#review63633 --- Ship it! Master (552ae93) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 3, 2014, 1:45 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/ --- (Updated Dec. 3, 2014, 1:45 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-956 https://issues.apache.org/jira/browse/AURORA-956 Repository: aurora Description --- Prevent Aurora from creating tasks with 0 disk. Diffs - src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e0332c0729b3858d397d9f2c1497caf08daa3c2d src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28621/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/#review63634 --- Ship it! This is now on master: ``` $ git log -1 origin/master --abbrev-commit commit 8959b49 Author: Zameer Manji zma...@twopensource.com Date: Tue Dec 2 17:46:00 2014 -0800 Prevent Aurora from creating tasks with 0 disk. Bugs closed: AURORA-956 Reviewed at https://reviews.apache.org/r/28621/ ``` - Bill Farner On Dec. 3, 2014, 1:45 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/ --- (Updated Dec. 3, 2014, 1:45 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-956 https://issues.apache.org/jira/browse/AURORA-956 Repository: aurora Description --- Prevent Aurora from creating tasks with 0 disk. Diffs - src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e0332c0729b3858d397d9f2c1497caf08daa3c2d src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28621/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
