Re: Review Request 28771: Don't fall back to old command syntax in the new client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/#review64103 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 5, 2014, 9:12 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28771/ > --- > > (Updated Dec. 5, 2014, 9:12 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-782 > https://issues.apache.org/jira/browse/AURORA-782 > > > Repository: aurora > > > Description > --- > > The diff appears like a large delta to `cli/client.py`, but it is in fact a > pure `git mv` of standalone_client.py to client.py, since the qualification > no longer makes sense. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/BUILD > 8d34bf71a225210f1fef8b5a69bc9f14b49d17bb > src/main/python/apache/aurora/client/cli/client.py > a1df788adf2c8066d207e6b70d7694f6975b8edd > src/main/python/apache/aurora/client/cli/standalone_client.py > 93120a15f5e1967b4067d3c068b9bc564f3fb432 > > Diff: https://reviews.apache.org/r/28771/diff/ > > > Testing > --- > > ``` > ./pants build src/test/python/apache/aurora/client:all -vxs > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > Bill Farner > >
Re: Review Request 28771: Don't fall back to old command syntax in the new client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/#review64087 --- Master (40d2718) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 5, 2014, 9:12 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28771/ > --- > > (Updated Dec. 5, 2014, 9:12 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-782 > https://issues.apache.org/jira/browse/AURORA-782 > > > Repository: aurora > > > Description > --- > > The diff appears like a large delta to `cli/client.py`, but it is in fact a > pure `git mv` of standalone_client.py to client.py, since the qualification > no longer makes sense. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/BUILD > 8d34bf71a225210f1fef8b5a69bc9f14b49d17bb > src/main/python/apache/aurora/client/cli/client.py > a1df788adf2c8066d207e6b70d7694f6975b8edd > src/main/python/apache/aurora/client/cli/standalone_client.py > 93120a15f5e1967b4067d3c068b9bc564f3fb432 > > Diff: https://reviews.apache.org/r/28771/diff/ > > > Testing > --- > > ``` > ./pants build src/test/python/apache/aurora/client:all -vxs > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > Bill Farner > >
Re: Review Request 28771: Don't fall back to old command syntax in the new client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/#review64086 --- Ship it! Ship It! - Zameer Manji On Dec. 5, 2014, 1:12 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28771/ > --- > > (Updated Dec. 5, 2014, 1:12 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-782 > https://issues.apache.org/jira/browse/AURORA-782 > > > Repository: aurora > > > Description > --- > > The diff appears like a large delta to `cli/client.py`, but it is in fact a > pure `git mv` of standalone_client.py to client.py, since the qualification > no longer makes sense. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/BUILD > 8d34bf71a225210f1fef8b5a69bc9f14b49d17bb > src/main/python/apache/aurora/client/cli/client.py > a1df788adf2c8066d207e6b70d7694f6975b8edd > src/main/python/apache/aurora/client/cli/standalone_client.py > 93120a15f5e1967b4067d3c068b9bc564f3fb432 > > Diff: https://reviews.apache.org/r/28771/diff/ > > > Testing > --- > > ``` > ./pants build src/test/python/apache/aurora/client:all -vxs > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > Bill Farner > >
Review Request 28771: Don't fall back to old command syntax in the new client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-782 https://issues.apache.org/jira/browse/AURORA-782 Repository: aurora Description --- The diff appears like a large delta to `cli/client.py`, but it is in fact a pure `git mv` of standalone_client.py to client.py, since the qualification no longer makes sense. Diffs - src/main/python/apache/aurora/client/cli/BUILD 8d34bf71a225210f1fef8b5a69bc9f14b49d17bb src/main/python/apache/aurora/client/cli/client.py a1df788adf2c8066d207e6b70d7694f6975b8edd src/main/python/apache/aurora/client/cli/standalone_client.py 93120a15f5e1967b4067d3c068b9bc564f3fb432 Diff: https://reviews.apache.org/r/28771/diff/ Testing --- ``` ./pants build src/test/python/apache/aurora/client:all -vxs ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, Bill Farner
