Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-17 Thread Brian Wickman
On Dec. 17, 2014, 6:40 p.m., Joe Smith wrote: Maybe this is actually legitimate tho? Perhaps we do want to catch PEX-INFO formatting changes? True -- this is really a bug in pex. - Brian --- This is an automatically generated

Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-17 Thread Brian Wickman
On Dec. 17, 2014, 6:40 p.m., Joe Smith wrote: Maybe this is actually legitimate tho? Perhaps we do want to catch PEX-INFO formatting changes? Brian Wickman wrote: True -- this is really a bug in pex. that being said, it's *still* not testing the thing it should. it's testing

Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65406 --- Ship it! Ship It! - Kevin Sweeney On Dec. 16, 2014, 4:57 p.m.,

Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65430 --- Ship it! Ship It! - Joe Smith On Dec. 16, 2014, 4:57 p.m.,

Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/ --- Review request for Aurora. Repository: aurora Description ---

Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/ --- (Updated Dec. 17, 2014, 12:57 a.m.) Review request for Aurora and Kevin