Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65430 --- Ship it! Ship It! - Joe Smith On Dec. 16, 2014, 4:57 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29132/ > --- > > (Updated Dec. 16, 2014, 4:57 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > --- > > get_client_version should never be allowed to run unpatched in test. > > > Diffs > - > > src/test/python/apache/aurora/client/cli/test_help.py > 1576edcaf0f59911c1c7aec42052d5ebfe41caac > > Diff: https://reviews.apache.org/r/29132/diff/ > > > Testing > --- > > get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually > pants when running tests (!) if the format of PEX-INFO changes to a new > version of pants (as is the case for pants 0.0.25), then tests will start > failing with an inscrutible error. instead, just patch get_client_version to > something sensible. > > > Thanks, > > Brian Wickman > >
Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65406 --- Ship it! Ship It! - Kevin Sweeney On Dec. 16, 2014, 4:57 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29132/ > --- > > (Updated Dec. 16, 2014, 4:57 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > --- > > get_client_version should never be allowed to run unpatched in test. > > > Diffs > - > > src/test/python/apache/aurora/client/cli/test_help.py > 1576edcaf0f59911c1c7aec42052d5ebfe41caac > > Diff: https://reviews.apache.org/r/29132/diff/ > > > Testing > --- > > get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually > pants when running tests (!) if the format of PEX-INFO changes to a new > version of pants (as is the case for pants 0.0.25), then tests will start > failing with an inscrutible error. instead, just patch get_client_version to > something sensible. > > > Thanks, > > Brian Wickman > >
Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.
> On Dec. 17, 2014, 10:40 a.m., Joe Smith wrote: > > Maybe this is actually legitimate tho? Perhaps we do want to catch PEX-INFO > > formatting changes? > > Brian Wickman wrote: > True -- this is really a bug in pex. > > Brian Wickman wrote: > that being said, it's *still* not testing the thing it should. it's > testing whether it's compatible with the PEX-INFO in the pex in sys.argv[0] > (assuming it's a pex.) Yeah this method should definitely not be called outside of an integration test guaranteed to be running in a .pex. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65340 --- On Dec. 16, 2014, 4:57 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29132/ > --- > > (Updated Dec. 16, 2014, 4:57 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > --- > > get_client_version should never be allowed to run unpatched in test. > > > Diffs > - > > src/test/python/apache/aurora/client/cli/test_help.py > 1576edcaf0f59911c1c7aec42052d5ebfe41caac > > Diff: https://reviews.apache.org/r/29132/diff/ > > > Testing > --- > > get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually > pants when running tests (!) if the format of PEX-INFO changes to a new > version of pants (as is the case for pants 0.0.25), then tests will start > failing with an inscrutible error. instead, just patch get_client_version to > something sensible. > > > Thanks, > > Brian Wickman > >
Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.
> On Dec. 17, 2014, 6:40 p.m., Joe Smith wrote: > > Maybe this is actually legitimate tho? Perhaps we do want to catch PEX-INFO > > formatting changes? > > Brian Wickman wrote: > True -- this is really a bug in pex. that being said, it's *still* not testing the thing it should. it's testing whether it's compatible with the PEX-INFO in the pex in sys.argv[0] (assuming it's a pex.) - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65340 --- On Dec. 17, 2014, 12:57 a.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29132/ > --- > > (Updated Dec. 17, 2014, 12:57 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > --- > > get_client_version should never be allowed to run unpatched in test. > > > Diffs > - > > src/test/python/apache/aurora/client/cli/test_help.py > 1576edcaf0f59911c1c7aec42052d5ebfe41caac > > Diff: https://reviews.apache.org/r/29132/diff/ > > > Testing > --- > > get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually > pants when running tests (!) if the format of PEX-INFO changes to a new > version of pants (as is the case for pants 0.0.25), then tests will start > failing with an inscrutible error. instead, just patch get_client_version to > something sensible. > > > Thanks, > > Brian Wickman > >
Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.
> On Dec. 17, 2014, 6:40 p.m., Joe Smith wrote: > > Maybe this is actually legitimate tho? Perhaps we do want to catch PEX-INFO > > formatting changes? True -- this is really a bug in pex. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65340 --- On Dec. 17, 2014, 12:57 a.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29132/ > --- > > (Updated Dec. 17, 2014, 12:57 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > --- > > get_client_version should never be allowed to run unpatched in test. > > > Diffs > - > > src/test/python/apache/aurora/client/cli/test_help.py > 1576edcaf0f59911c1c7aec42052d5ebfe41caac > > Diff: https://reviews.apache.org/r/29132/diff/ > > > Testing > --- > > get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually > pants when running tests (!) if the format of PEX-INFO changes to a new > version of pants (as is the case for pants 0.0.25), then tests will start > failing with an inscrutible error. instead, just patch get_client_version to > something sensible. > > > Thanks, > > Brian Wickman > >
Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65340 --- Maybe this is actually legitimate tho? Perhaps we do want to catch PEX-INFO formatting changes? - Joe Smith On Dec. 16, 2014, 4:57 p.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29132/ > --- > > (Updated Dec. 16, 2014, 4:57 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > --- > > get_client_version should never be allowed to run unpatched in test. > > > Diffs > - > > src/test/python/apache/aurora/client/cli/test_help.py > 1576edcaf0f59911c1c7aec42052d5ebfe41caac > > Diff: https://reviews.apache.org/r/29132/diff/ > > > Testing > --- > > get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually > pants when running tests (!) if the format of PEX-INFO changes to a new > version of pants (as is the case for pants 0.0.25), then tests will start > failing with an inscrutible error. instead, just patch get_client_version to > something sensible. > > > Thanks, > > Brian Wickman > >
Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65273 --- Ship it! Master (ab18bd0) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 17, 2014, 12:57 a.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29132/ > --- > > (Updated Dec. 17, 2014, 12:57 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > --- > > get_client_version should never be allowed to run unpatched in test. > > > Diffs > - > > src/test/python/apache/aurora/client/cli/test_help.py > 1576edcaf0f59911c1c7aec42052d5ebfe41caac > > Diff: https://reviews.apache.org/r/29132/diff/ > > > Testing > --- > > get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually > pants when running tests (!) if the format of PEX-INFO changes to a new > version of pants (as is the case for pants 0.0.25), then tests will start > failing with an inscrutible error. instead, just patch get_client_version to > something sensible. > > > Thanks, > > Brian Wickman > >
Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/ --- (Updated Dec. 17, 2014, 12:57 a.m.) Review request for Aurora and Kevin Sweeney. Changes --- Add a reviewer. Repository: aurora Description --- get_client_version should never be allowed to run unpatched in test. Diffs - src/test/python/apache/aurora/client/cli/test_help.py 1576edcaf0f59911c1c7aec42052d5ebfe41caac Diff: https://reviews.apache.org/r/29132/diff/ Testing --- get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually pants when running tests (!) if the format of PEX-INFO changes to a new version of pants (as is the case for pants 0.0.25), then tests will start failing with an inscrutible error. instead, just patch get_client_version to something sensible. Thanks, Brian Wickman
Review Request 29132: get_client_version should never be allowed to run unpatched in test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/ --- Review request for Aurora. Repository: aurora Description --- get_client_version should never be allowed to run unpatched in test. Diffs - src/test/python/apache/aurora/client/cli/test_help.py 1576edcaf0f59911c1c7aec42052d5ebfe41caac Diff: https://reviews.apache.org/r/29132/diff/ Testing --- get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually pants when running tests (!) if the format of PEX-INFO changes to a new version of pants (as is the case for pants 0.0.25), then tests will start failing with an inscrutible error. instead, just patch get_client_version to something sensible. Thanks, Brian Wickman
