Re: Review Request 29271: Removing cron schedule support from createJob and killTasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/#review66895 --- Ship it! Ship It! - Bill Farner On Jan. 6, 2015, 7:56 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/ --- (Updated Jan. 6, 2015, 7:56 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-454 and AURORA-976 https://issues.apache.org/jira/browse/AURORA-454 https://issues.apache.org/jira/browse/AURORA-976 Repository: aurora Description --- While working on AURORA-454, realized we have a bigger problem with cron schedules killing non-cron jobs. Field AURORA-976, which is also addressed in this diff. Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java a6ff14a69a32965a87a7a3a6d73ef53f5bdf75c0 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 6e3caa164e4b98907e1a87460aab3afb9be95ef9 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 8d41e7011344aa6a9ba39feacc166dd3c3e64227 Diff: https://reviews.apache.org/r/29271/diff/ Testing --- ./gradlew -Pq build ``` $ aurora cron schedule devcluster/www-data/prod/hello aurora/examples/jobs/cron_hello_world.aurora INFO] Registering job hello with cron Error scheduling cron job devcluster/www-data/prod/hello: Job www-data/prod/hello already exists $ aurora job create devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora INFO] Creating job hello Job creation failed due to error: Job www-data/prod/hello already exists ``` Thanks, Maxim Khutornenko
Re: Review Request 29271: Removing cron schedule support from createJob and killTasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/ --- (Updated Jan. 6, 2015, 7:56 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- Fixed bug links. -wfarner Bugs: AURORA-454 and AURORA-976 https://issues.apache.org/jira/browse/AURORA-454 https://issues.apache.org/jira/browse/AURORA-976 Repository: aurora Description --- While working on AURORA-454, realized we have a bigger problem with cron schedules killing non-cron jobs. Field AURORA-976, which is also addressed in this diff. Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java a6ff14a69a32965a87a7a3a6d73ef53f5bdf75c0 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 6e3caa164e4b98907e1a87460aab3afb9be95ef9 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 8d41e7011344aa6a9ba39feacc166dd3c3e64227 Diff: https://reviews.apache.org/r/29271/diff/ Testing --- ./gradlew -Pq build ``` $ aurora cron schedule devcluster/www-data/prod/hello aurora/examples/jobs/cron_hello_world.aurora INFO] Registering job hello with cron Error scheduling cron job devcluster/www-data/prod/hello: Job www-data/prod/hello already exists $ aurora job create devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora INFO] Creating job hello Job creation failed due to error: Job www-data/prod/hello already exists ``` Thanks, Maxim Khutornenko
Review Request 29271: Removing cron schedule support from createJob and killTasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-454AURORA-976 https://issues.apache.org/jira/browse/AURORA-454AURORA-976 Repository: aurora Description --- While working on AURORA-454, realized we have a bigger problem with cron schedules killing non-cron jobs. Field AURORA-976, which is also addressed in this diff. Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java a6ff14a69a32965a87a7a3a6d73ef53f5bdf75c0 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 6e3caa164e4b98907e1a87460aab3afb9be95ef9 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 8d41e7011344aa6a9ba39feacc166dd3c3e64227 Diff: https://reviews.apache.org/r/29271/diff/ Testing --- ./gradlew -Pq build ``` $ aurora cron schedule devcluster/www-data/prod/hello aurora/examples/jobs/cron_hello_world.aurora INFO] Registering job hello with cron Error scheduling cron job devcluster/www-data/prod/hello: Job www-data/prod/hello already exists $ aurora job create devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora INFO] Creating job hello Job creation failed due to error: Job www-data/prod/hello already exists ``` Thanks, Maxim Khutornenko
Re: Review Request 29271: Removing cron schedule support from createJob and killTasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/#review65697 --- Ship it! Master (84ad650) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 19, 2014, 10:08 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/ --- (Updated Dec. 19, 2014, 10:08 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-454 AURORA-976 https://issues.apache.org/jira/browse/AURORA-454 AURORA-976 Repository: aurora Description --- While working on AURORA-454, realized we have a bigger problem with cron schedules killing non-cron jobs. Field AURORA-976, which is also addressed in this diff. Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java a6ff14a69a32965a87a7a3a6d73ef53f5bdf75c0 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 6e3caa164e4b98907e1a87460aab3afb9be95ef9 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 8d41e7011344aa6a9ba39feacc166dd3c3e64227 Diff: https://reviews.apache.org/r/29271/diff/ Testing --- ./gradlew -Pq build ``` $ aurora cron schedule devcluster/www-data/prod/hello aurora/examples/jobs/cron_hello_world.aurora INFO] Registering job hello with cron Error scheduling cron job devcluster/www-data/prod/hello: Job www-data/prod/hello already exists $ aurora job create devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora INFO] Creating job hello Job creation failed due to error: Job www-data/prod/hello already exists ``` Thanks, Maxim Khutornenko
