Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review70026 --- I am getting an error when running e2e tests with this patch: ``` + vagrant ssh -c 'cd /vagrant/src/test/sh/org/apache/aurora/e2e docker build -t http_example .' Sending build context to Docker daemon FATA[] Post http:///var/run/docker.sock/v1.16/build?rm=1t=http_example: dial unix /var/run/docker.sock: permission denied Connection to 127.0.0.1 closed. + collect_result + [[ 1 = 0 ]] + echo '!!!' !!! + echo 'FAIL (something returned non-zero)' FAIL (something returned non-zero) + echo '' ``` Anything I am missing? - Maxim Khutornenko On Jan. 27, 2015, 4:58 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 27, 2015, 4:58 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs - src/test/sh/org/apache/aurora/e2e/Dockerfile PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review70082 --- Ship it! Ship It! - Bill Farner On Jan. 28, 2015, 6:56 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 28, 2015, 6:56 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs - src/test/sh/org/apache/aurora/e2e/Dockerfile PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 28, 2015, 6:56 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs (updated) - src/test/sh/org/apache/aurora/e2e/Dockerfile PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review70055 --- Ship it! Master (46a0466) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 28, 2015, 6:56 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 28, 2015, 6:56 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs - src/test/sh/org/apache/aurora/e2e/Dockerfile PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 27, 2015, 4:58 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs (updated) - src/test/sh/org/apache/aurora/e2e/Dockerfile PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review69822 --- Master (0cb40d1) is red with this patch. ./build-support/jenkins/build.sh :assemble :compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7' 1 warning :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJava :processTestResources :testClasses :checkstyleTest :findbugsJmh :findbugsMain :findbugsTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage of 0.8918054225730366 exceeds minimum coverage of 0.89. :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Branch coverage is 0.8348623853211009, but must be greater than 0.835 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 3 mins 45.078 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 27, 2015, 4:58 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 27, 2015, 4:58 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs - src/test/sh/org/apache/aurora/e2e/Dockerfile PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- Review request for Aurora. Repository: aurora Description --- This adds an end to end test for docker. Diffs - examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh 31646425233470b5f87ab50ef4504264f235f48a src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 578662ccd1735ebf500d066b3cc17b30f635c15f Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 12, 2015, 11:44 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs - examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh 31646425233470b5f87ab50ef4504264f235f48a src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 578662ccd1735ebf500d066b3cc17b30f635c15f Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review67763 --- This patch does not apply cleanly on master (5ce076b), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 12, 2015, 11:44 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 12, 2015, 11:44 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs - examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh 31646425233470b5f87ab50ef4504264f235f48a src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 578662ccd1735ebf500d066b3cc17b30f635c15f Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 13, 2015, 12:32 a.m.) Review request for Aurora and Bill Farner. Changes --- Rebased from master. Repository: aurora Description --- This adds an end to end test for docker. Diffs (updated) - examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 13, 2015, 1:14 a.m.) Review request for Aurora and Bill Farner. Changes --- Rebased? Repository: aurora Description --- This adds an end to end test for docker. Diffs (updated) - examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review67778 --- This patch does not apply cleanly on master (c8154b2), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 13, 2015, 1:14 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 13, 2015, 1:14 a.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs - examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review67739 --- src/test/sh/org/apache/aurora/e2e/test_common.sh https://reviews.apache.org/r/29827/#comment111826 do you mind splitting this fix into a separate patch? If I'm reading correctly this is currently broken on master. - Kevin Sweeney On Jan. 12, 2015, 3:05 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 12, 2015, 3:05 p.m.) Review request for Aurora. Repository: aurora Description --- This adds an end to end test for docker. Diffs - examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh 31646425233470b5f87ab50ef4504264f235f48a src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 578662ccd1735ebf500d066b3cc17b30f635c15f Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
On Jan. 12, 2015, 11:25 p.m., Kevin Sweeney wrote: src/test/sh/org/apache/aurora/e2e/test_common.sh, lines 39-40 https://reviews.apache.org/r/29827/diff/1/?file=818226#file818226line39 do you mind splitting this fix into a separate patch? If I'm reading correctly this is currently broken on master. Sure, and yeah it's broken in master as well after removing the v1 client. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review67739 --- On Jan. 12, 2015, 11:05 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 12, 2015, 11:05 p.m.) Review request for Aurora. Repository: aurora Description --- This adds an end to end test for docker. Diffs - examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh 31646425233470b5f87ab50ef4504264f235f48a src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 578662ccd1735ebf500d066b3cc17b30f635c15f Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29827: End to end tests for docker in aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/#review67769 --- This patch does not apply cleanly on master (c8154b2), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 13, 2015, 12:32 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827/ --- (Updated Jan. 13, 2015, 12:32 a.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This adds an end to end test for docker. Diffs - examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz
