Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.
> On Jan. 16, 2015, 10:29 p.m., Bill Farner wrote: > > Ship It! This is now on master: ``` $ git log -1 origin/master commit da74e282befa2dcd9e2084120c31a60bcfc5ba33 Author: Joshua Cohen Date: Fri Jan 16 14:29:31 2015 -0800 Fix path to stylesheet in slaves and utilization templates. Bugs closed: AURORA-1019 Reviewed at https://reviews.apache.org/r/29971/ ``` - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29971/#review68489 --- On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29971/ > --- > > (Updated Jan. 16, 2015, 7:08 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1019 > https://issues.apache.org/jira/browse/AURORA-1019 > > > Repository: aurora > > > Description > --- > > Fix path to stylesheet in slaves and utilization templates. > > > Diffs > - > > src/main/resources/org/apache/aurora/scheduler/http/slaves.st > 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 > src/main/resources/org/apache/aurora/scheduler/http/utilization.st > 73f86d51e9bb0179b774554718ad49ce00ba5487 > > Diff: https://reviews.apache.org/r/29971/diff/ > > > Testing > --- > > Verified styles were present when hitting those endpoints in vagrant. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29971/#review68489 --- Ship it! Ship It! - Bill Farner On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29971/ > --- > > (Updated Jan. 16, 2015, 7:08 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1019 > https://issues.apache.org/jira/browse/AURORA-1019 > > > Repository: aurora > > > Description > --- > > Fix path to stylesheet in slaves and utilization templates. > > > Diffs > - > > src/main/resources/org/apache/aurora/scheduler/http/slaves.st > 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 > src/main/resources/org/apache/aurora/scheduler/http/utilization.st > 73f86d51e9bb0179b774554718ad49ce00ba5487 > > Diff: https://reviews.apache.org/r/29971/diff/ > > > Testing > --- > > Verified styles were present when hitting those endpoints in vagrant. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29971/#review68481 --- Master (1346c4f) is red with this patch. ./build-support/jenkins/build.sh :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///x1/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage of 0.8929194773338365 exceeds minimum coverage of 0.89. Branch coverage of 0.8393782383419689 exceeds minimum coverage of 0.835. :check :build :api:assemble :api:compileTestJava UP-TO-DATE :api:processTestResources UP-TO-DATE :api:testClasses UP-TO-DATE :api:test UP-TO-DATE :api:check UP-TO-DATE :api:build :buildSrc:compileJava UP-TO-DATE :buildSrc:processResources UP-TO-DATE :buildSrc:classes UP-TO-DATE :buildSrc:jar :buildSrc:assemble :buildSrc:compileTestJava UP-TO-DATE :buildSrc:processTestResources UP-TO-DATE :buildSrc:testClasses UP-TO-DATE :buildSrc:test UP-TO-DATE :buildSrc:check UP-TO-DATE :buildSrc:build BUILD SUCCESSFUL Total time: 2 mins 58.488 secs + export PIP_DEFAULT_TIMEOUT=60 + PIP_DEFAULT_TIMEOUT=60 + mkdir -p third_party + pip install -d third_party -r /dev/fd/63 ++ grep -v mesos.native 3rdparty/python/requirements.txt ./build-support/jenkins/build.sh: line 28: pip: command not found grep: write error: Broken pipe I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29971/ > --- > > (Updated Jan. 16, 2015, 7:08 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1019 > https://issues.apache.org/jira/browse/AURORA-1019 > > > Repository: aurora > > > Description > --- > > Fix path to stylesheet in slaves and utilization templates. > > > Diffs > - > > src/main/resources/org/apache/aurora/scheduler/http/slaves.st > 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 > src/main/resources/org/apache/aurora/scheduler/http/utilization.st > 73f86d51e9bb0179b774554718ad49ce00ba5487 > > Diff: https://reviews.apache.org/r/29971/diff/ > > > Testing > --- > > Verified styles were present when hitting those endpoints in vagrant. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29971/#review68477 --- @ReviewBot retry - Joshua Cohen On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29971/ > --- > > (Updated Jan. 16, 2015, 7:08 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1019 > https://issues.apache.org/jira/browse/AURORA-1019 > > > Repository: aurora > > > Description > --- > > Fix path to stylesheet in slaves and utilization templates. > > > Diffs > - > > src/main/resources/org/apache/aurora/scheduler/http/slaves.st > 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 > src/main/resources/org/apache/aurora/scheduler/http/utilization.st > 73f86d51e9bb0179b774554718ad49ce00ba5487 > > Diff: https://reviews.apache.org/r/29971/diff/ > > > Testing > --- > > Verified styles were present when hitting those endpoints in vagrant. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29971/#review68461 --- Master (1346c4f) is red with this patch. ./build-support/jenkins/build.sh File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder.py", line 43, in build debug=debug).run() File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 88, in run rv = self._run_tests([target], stdout, stderr) File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 316, in _run_tests with self._test_runner(targets, stdout, stderr) as (pex, test_args): File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__ return self.gen.next() File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 295, in _test_runner builder = chroot.dump() File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py", line 191, in dump conn_timeout=self._conn_timeout) File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py", line 100, in resolve_multi platform=platform) File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py", line 101, in resolve raise Unsatisfiable('Cannot satisfy requirements: %s' % requirement_set[requirement.key]) Unsatisfiable: Cannot satisfy requirements: [PythonRequirement(pytest-cov)] Usage: pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython>=2.6,<3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29971/ > --- > > (Updated Jan. 16, 2015, 7:08 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1019 > https://issues.apache.org/jira/browse/AURORA-1019 > > > Repository: aurora > > > Description > --- > > Fix path to stylesheet in slaves and utilization templates. > > > Diffs > - > > src/main/resources/org/apache/aurora/scheduler/http/slaves.st > 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 > src/main/resources/org/apache/aurora/scheduler/http/utilization.st > 73f86d51e9bb0179b774554718ad49ce00ba5487 > > Diff: https://reviews.apache.org/r/29971/diff/ > > > Testing > --- > > Verified styles were present when hitting those endpoints in vagrant. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29971/#review68457 --- Ship it! Ship It! - David McLaughlin On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29971/ > --- > > (Updated Jan. 16, 2015, 7:08 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1019 > https://issues.apache.org/jira/browse/AURORA-1019 > > > Repository: aurora > > > Description > --- > > Fix path to stylesheet in slaves and utilization templates. > > > Diffs > - > > src/main/resources/org/apache/aurora/scheduler/http/slaves.st > 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 > src/main/resources/org/apache/aurora/scheduler/http/utilization.st > 73f86d51e9bb0179b774554718ad49ce00ba5487 > > Diff: https://reviews.apache.org/r/29971/diff/ > > > Testing > --- > > Verified styles were present when hitting those endpoints in vagrant. > > > Thanks, > > Joshua Cohen > >
Review Request 29971: Fix path to stylesheet in slaves and utilization templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29971/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-1019 https://issues.apache.org/jira/browse/AURORA-1019 Repository: aurora Description --- Fix path to stylesheet in slaves and utilization templates. Diffs - src/main/resources/org/apache/aurora/scheduler/http/slaves.st 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 73f86d51e9bb0179b774554718ad49ce00ba5487 Diff: https://reviews.apache.org/r/29971/diff/ Testing --- Verified styles were present when hitting those endpoints in vagrant. Thanks, Joshua Cohen