Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72861 --- Ship it! Master (4b43305) is green with this patch. ./build-suppo

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/ --- (Updated Feb. 18, 2015, 1:12 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

> On Feb. 18, 2015, 1:03 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java, > > lines 88-90 > > > > > > Fits on one line? Done here and elsewhere. >

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72853 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/JobU

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/ --- (Updated Feb. 18, 2015, 12:53 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

> On Feb. 18, 2015, 12:38 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java, > > line 66 > > > > > > How about "updateKey" or "key" instead? The "update

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72828 --- src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetai

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72827 --- Ship it! Ship It! - Kevin Sweeney On Feb. 17, 2015, 3:06 p.m., B

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/ --- (Updated Feb. 17, 2015, 11:06 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

> On Feb. 17, 2015, 10:51 p.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 721 > > > > > > Should these be marked deprecated now (to be removed in 0.9.0?) The TODOs added will

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

> On Feb. 17, 2015, 10:51 p.m., Kevin Sweeney wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml, > > line 24 > > > > > > why the underscores here? > > Bill Farner wrote: >

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72815 --- Master (219c3ad) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72804 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift

Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-10