Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review75801 --- Master (e55113d) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/ --- (Updated March 9, 2015, 9:59 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review75591 --- Ship it! Ship It! - Kevin Sweeney On March 2, 2015, 3:40 p.m., M

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review75103 --- Ship it! Ship It! - Bill Farner On March 2, 2015, 11:40 p.m., Ma

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/ --- (Updated March 2, 2015, 11:40 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Maxim Khutornenko
> On March 2, 2015, 7:40 p.m., Bill Farner wrote: > > Can you elaborate on how this change would have addressed this scenario > > described in AURORA-1148? Seems like the confusion of only seeing > > 'Insufficient RAM' is not resolved by this change alone. Correct, it's an incremental quality

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74801 --- Can you elaborate on how this change would have addressed this scena

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Maxim Khutornenko
> On March 2, 2015, 7:14 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, > > line 64 > > > > > > I don't think the Math.pow approach is necessary - why not make sc

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74793 --- src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.j

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74594 --- Ship it! Master (e8a0a9f) is green with this patch. ./build-suppo

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/ --- (Updated Feb. 27, 2015, 9:05 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-27 Thread Maxim Khutornenko
> On Feb. 27, 2015, 7:30 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, > > lines 110-113 > > > > > > How about making score an EnumSet so that you can do a > >

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74554 --- src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.j

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74434 --- Master (766d1c9) is red with this patch. ./build-support/jenkins/b

Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-1148