Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31558/#review74593 --- Ship it! Master (e8a0a9f) is green with this patch. ./build-suppo

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31558/#review74586 --- @ReviewBot retry - Maxim Khutornenko On Feb. 27, 2015, 8:13 p.m.,

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31558/#review74581 --- Master (443f668) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Maxim Khutornenko
> On Feb. 27, 2015, 8:20 p.m., Zameer Manji wrote: > > Just to be clear, this is because it doesn't make sense to have rollback > > with restarts right? Yeah, there is nothing to rollback to in case of restarts that by definition use the same task config. - Maxim --

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31558/#review74573 --- Ship it! Just to be clear, this is because it doesn't make sense to

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31558/#review74571 --- Ship it! Ship It! - Bill Farner On Feb. 27, 2015, 8:13 p.m., Max

Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31558/ --- Review request for Aurora and Zameer Manji. Bugs: AURORA-1020 https://issue