Re: Review Request 31751: Adding missing service binding into UpdaterModule.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31751/#review75279
---

Ship it!


Ship It!

- Bill Farner


On March 5, 2015, 2:22 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31751/
> ---
> 
> (Updated March 5, 2015, 2:22 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1173
> https://issues.apache.org/jira/browse/AURORA-1173
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding missing binding and a e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
> 5733da3daeacd8cb726310e5d9933635e3993687 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 216849145fe681d05ed54ac7fbf385bb31d8cdea 
> 
> Diff: https://reviews.apache.org/r/31751/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31751: Adding missing service binding into UpdaterModule.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31751/
---

(Updated March 5, 2015, 2:22 a.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-1173
https://issues.apache.org/jira/browse/AURORA-1173


Repository: aurora


Description
---

Adding missing binding and a e2e test.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
5733da3daeacd8cb726310e5d9933635e3993687 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
216849145fe681d05ed54ac7fbf385bb31d8cdea 

Diff: https://reviews.apache.org/r/31751/diff/


Testing
---

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Maxim Khutornenko

Re: Review Request 31751: Adding missing service binding into UpdaterModule.

[Maxim Khutornenko]

> On March 5, 2015, 1:01 a.m., Bill Farner wrote:
> > It would be great to have coverage for this within the scheduler's tests.  
> > `JobUpdaterIT` already consumes `UpdaterModule`, pehaps this fix could be 
> > proven there?

AFAICT, to truly test that binding would require wiring up the SchedulerModule 
and all its dependent modules to simulate a DriverRegistered event. That would 
trigger SchedulerLifecycle handleRegistered() and all services annotated with 
@SchedulerActive. IMO, not worth the increased test complexity.


> On March 5, 2015, 1:01 a.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 169
> > 
> >
> > Any reason you chose `stop` and `start` over `restart`?

Did not notice restart command. Changed.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31751/#review75272
---


On March 5, 2015, 12:48 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31751/
> ---
> 
> (Updated March 5, 2015, 12:48 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1173
> https://issues.apache.org/jira/browse/AURORA-1173
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding missing binding and a e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
> 5733da3daeacd8cb726310e5d9933635e3993687 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 216849145fe681d05ed54ac7fbf385bb31d8cdea 
> 
> Diff: https://reviews.apache.org/r/31751/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31751: Adding missing service binding into UpdaterModule.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31751/
---

(Updated March 5, 2015, 2:20 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

Bill's comments.


Bugs: AURORA-1173
https://issues.apache.org/jira/browse/AURORA-1173


Repository: aurora


Description
---

Adding missing binding and a e2e test.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
5733da3daeacd8cb726310e5d9933635e3993687 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
216849145fe681d05ed54ac7fbf385bb31d8cdea 

Diff: https://reviews.apache.org/r/31751/diff/


Testing
---

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Maxim Khutornenko

Re: Review Request 31751: Adding missing service binding into UpdaterModule.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31751/#review75272
---


It would be great to have coverage for this within the scheduler's tests.  
`JobUpdaterIT` already consumes `UpdaterModule`, pehaps this fix could be 
proven there?


src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Any reason you chose `stop` and `start` over `restart`?


- Bill Farner


On March 5, 2015, 12:48 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31751/
> ---
> 
> (Updated March 5, 2015, 12:48 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1173
> https://issues.apache.org/jira/browse/AURORA-1173
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding missing binding and a e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
> 5733da3daeacd8cb726310e5d9933635e3993687 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 216849145fe681d05ed54ac7fbf385bb31d8cdea 
> 
> Diff: https://reviews.apache.org/r/31751/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 31751: Adding missing service binding into UpdaterModule.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31751/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1173
https://issues.apache.org/jira/browse/AURORA-1173


Repository: aurora


Description
---

Adding missing binding and a e2e test.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
5733da3daeacd8cb726310e5d9933635e3993687 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
216849145fe681d05ed54ac7fbf385bb31d8cdea 

Diff: https://reviews.apache.org/r/31751/diff/


Testing
---

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Maxim Khutornenko