---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/
---
(Updated March 10, 2015, 5:26 p.m.)
Review request for Aurora, Bill Farner and
On March 7, 2015, 5:30 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java,
line 326
https://reviews.apache.org/r/31821/diff/1/?file=888148#file888148line326
Not yours, but it seems odd that we would call a function and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75901
---
Ship it!
Master (1b1931c) is green with this patch.
On March 7, 2015, 9:30 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java,
line 90
https://reviews.apache.org/r/31821/diff/1/?file=888148#file888148line90
Nothing forces the backing Set to be immutable, consider changing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75743
---
Ship it!
On March 7, 2015, 9:30 a.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/async/preemptor/TestUtil.java,
line 34
https://reviews.apache.org/r/31821/diff/1/?file=888158#file888158line34
I'm highly skeptical of the shelf life of test fixtures like this.
Here we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/
---
(Updated March 9, 2015, 11:34 p.m.)
Review request for Aurora, Bill Farner and
On March 7, 2015, 5:30 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 97
https://reviews.apache.org/r/31821/diff/1/?file=888146#file888146line97
Can you leave a TODO(wfarner) to reuse existing modules here? The DRY
violation
On March 9, 2015, 6:59 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java,
line 135
https://reviews.apache.org/r/31821/diff/1/?file=888148#file888148line135
To keep the implementation package private, could you move it to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75816
---
@ReviewBot retry
- Maxim Khutornenko
On March 9, 2015, 11:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75815
---
Master (e55113d) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75819
---
Ship it!
Master (e55113d) is green with this patch.
On March 7, 2015, 5:30 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java,
line 326
https://reviews.apache.org/r/31821/diff/1/?file=888148#file888148line326
Not yours, but it seems odd that we would call a function and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75603
---
Ship it!
Master (fdc11e3) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/
---
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1158
15 matches
Mail list logo
