Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-17 Thread Brian Wickman
On March 17, 2015, 7:49 p.m., Zameer Manji wrote: src/main/python/apache/aurora/executor/common/path_detector.py, line 34 https://reviews.apache.org/r/32013/diff/3/?file=896451#file896451line34 What's the rationale behind this change? I think the callers should be doing the

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76800 --- Ship it! Master (4b39d26) is green with this patch.

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-17 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/ --- (Updated March 17, 2015, 8:24 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76794 --- Ship it! Ship It! - Joe Smith On March 17, 2015, 1:24 p.m.,

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76667 --- This patch does not apply cleanly on master (1b2a343), do you need

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/ --- (Updated March 16, 2015, 9:47 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76658 --- Master (1b2a343) is red with this patch.

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/ --- (Updated March 16, 2015, 10:37 p.m.) Review request for Aurora, Joe Smith and

Review Request 32013: Cache TaskDetectors for reuse.

2015-03-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/ --- Review request for Aurora, Joe Smith and Zameer Manji. Repository: aurora

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76318 --- Master (ee1a13a) is red with this patch.

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76319 --- whoops, forgot that I added os.path.exists filtering -- will update