Review Request 32164: Moving pending task search into PreemptorImpl

2015-03-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32164/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 32164: Moving pending task search into PreemptorImpl

2015-03-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32164/#review76747 --- Ship it! Master (b847bbf) is green with this patch.

Re: Review Request 32164: Moving pending task search into PreemptorImpl

2015-03-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32164/#review76753 --- I actually meant this should be outside the preemptor altogether.

Re: Review Request 32164: Moving pending task search into PreemptorImpl

2015-03-17 Thread Bill Farner
On March 17, 2015, 6:05 p.m., Bill Farner wrote: I actually meant this should be outside the preemptor altogether. The preemptor is being called, and then internally deciding the caller should have not called in the first place. I claim this is odd behavior. I think it would make

Re: Review Request 32164: Moving pending task search into PreemptorImpl

2015-03-17 Thread Maxim Khutornenko
On March 17, 2015, 6:05 p.m., Bill Farner wrote: I actually meant this should be outside the preemptor altogether. The preemptor is being called, and then internally deciding the caller should have not called in the first place. I claim this is odd behavior. I think it would make

Re: Review Request 32164: Moving pending task search into PreemptorImpl

2015-03-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32164/#review76766 --- Ship it! Ship It! - Bill Farner On March 17, 2015, 5:19 p.m.,