Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/8#discussion_r89286832
--- Diff: flink-connector-akka/README.md ---
@@ -0,0 +1,45 @@
+# Flink Akka connector
+
+This connector provides a sink to [Akka](http
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/8#discussion_r89061030
--- Diff:
flink-connector-akka/src/main/java/org/apache/flink/streaming/connectors/akka/utils/ReceiverActor.java
---
@@ -0,0 +1,122
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/8#discussion_r89061655
--- Diff:
flink-connector-akka/src/main/java/org/apache/flink/streaming/connectors/akka/AkkaSource.java
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/8
Great, I'm going to merge this PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/8
Thank you for opening this pull request.
I'll review it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/13
I think the reason why `ZREM` was not added is because this is the
`RedisSink`, which implies that you are writing data to redis, not removing it.
I'm not sure if it makes sense semantically
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/13
Thank you for updating the PR.
I'll merge it.
I'm planning to create the first bahir-flink release soon. Would you like
to first add more commands to the connector
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/17
Thank you for your pull request.
I'm sorry that I didn't have time yet to review it. It is on my TODO list.
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/17#discussion_r128921616
--- Diff:
flink-connector-kudu/src/main/java/es/accenture/flink/Sink/KuduOutputFormat.java
---
@@ -0,0 +1,186 @@
+/*
+ * Licensed
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/21#discussion_r139233921
--- Diff:
flink-connector-influxdb/src/main/java/org/apache/flink/streaming/connectors/influxdb/InfluxDBSink.java
---
@@ -0,0 +1,114
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/21#discussion_r139234041
--- Diff:
flink-connector-influxdb/src/main/java/org/apache/flink/streaming/connectors/influxdb/InfluxDBSink.java
---
@@ -0,0 +1,114
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/22
Thanks a lot for moving the PR over here!
---
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/22#discussion_r152103730
--- Diff: flink-library-siddhi/pom.xml ---
@@ -0,0 +1,113 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://w
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/24
Thanks a lot for improving the tests stability.
I'll review the PR and the merge it :)
---
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/24
I've filed https://issues.apache.org/jira/browse/BAHIR-156 to have a JIRA
id for this issue.
I'll now merge the PR
---
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/25
Thanks a lot for the pull request. Integrating checkpointing with external
connectors is usually a tricky topic. Before we can merge this change, I'd like
to fully understand the problem first
16 matches
Mail list logo