[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313051561 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r312999527 ## File path:

[GitHub] [helix] chenboat edited a comment on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

chenboat edited a comment on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-519807855 > @chenboat Please refer to HelixManagerProperties. We should be able to do something similar for the monitors.

[GitHub] [helix] narendly closed issue #375: TASK: Drop all tasks whose requested states are DROPPED

narendly closed issue #375: TASK: Drop all tasks whose requested states are DROPPED URL: https://github.com/apache/helix/issues/375 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] narendly commented on issue #400: TASK: Drop all tasks whose requested states are DROPPED

narendly commented on issue #400: TASK: Drop all tasks whose requested states are DROPPED URL: https://github.com/apache/helix/pull/400#issuecomment-520526116 This PR is ready to be merged, approved by @dasahcc This is an

[GitHub] [helix] narendly merged pull request #400: TASK: Drop all tasks whose requested states are DROPPED

narendly merged pull request #400: TASK: Drop all tasks whose requested states are DROPPED URL: https://github.com/apache/helix/pull/400 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] narendly commented on issue #400: TASK: Drop all tasks whose requested states are DROPPED

narendly commented on issue #400: TASK: Drop all tasks whose requested states are DROPPED URL: https://github.com/apache/helix/pull/400#issuecomment-520519430 > I think you have the unit test to cover that. Can you add it in this PR? A unit test has been added:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313049887 ## File path:

[GitHub] [helix] jiajunwang merged pull request #395: Fix the CallbackHandler registration logic in DistributedLeaderElection

jiajunwang merged pull request #395: Fix the CallbackHandler registration logic in DistributedLeaderElection URL: https://github.com/apache/helix/pull/395 This is an automated message from the Apache Git Service. To respond

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313045054 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313046843 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313050451 ## File path:

[GitHub] [helix] jiajunwang closed issue #394: Leader controller loses all the callback handlers after leadership switch

jiajunwang closed issue #394: Leader controller loses all the callback handlers after leadership switch URL: https://github.com/apache/helix/issues/394 This is an automated message from the Apache Git Service. To respond to

[GitHub] [helix] i3wangyi closed pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi closed pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] jiajunwang commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

jiajunwang commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#discussion_r313065938 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313121637 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313132098 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313132294 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #392: Implement Cluster Model Provider.

dasahcc commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313176150 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java ##

[GitHub] [helix] dasahcc commented on a change in pull request #392: Implement Cluster Model Provider.

dasahcc commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313177061 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java ##

[GitHub] [helix] dasahcc commented on a change in pull request #392: Implement Cluster Model Provider.

dasahcc commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r312253959 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java ##

[GitHub] [helix] jiajunwang commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

jiajunwang commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313140478 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

jiajunwang commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313139991 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313105804 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313122133 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #392: Implement Cluster Model Provider.

i3wangyi commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313092620 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313132850 ## File path: