[GitHub] [helix] alirezazamani commented on issue #505: Fix the scenario for tasks being Dropped and Assigned to wrong instance in a loop

2019-10-08 Thread GitBox
alirezazamani commented on issue #505: Fix the scenario for tasks being Dropped and Assigned to wrong instance in a loop URL: https://github.com/apache/helix/pull/505#issuecomment-539654294 Closing this PR. Issue will be updated accordingly with new findings.

[GitHub] [helix] alirezazamani closed pull request #505: Fix the scenario for tasks being Dropped and Assigned to wrong instance in a loop

2019-10-08 Thread GitBox
alirezazamani closed pull request #505: Fix the scenario for tasks being Dropped and Assigned to wrong instance in a loop URL: https://github.com/apache/helix/pull/505 This is an automated message from the Apache Git

[GitHub] [helix] alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config

2019-10-08 Thread GitBox
alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config URL: https://github.com/apache/helix/pull/497#discussion_r332658421 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestPurgeJobWithoutConfig.java

[GitHub] [helix] alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config

2019-10-08 Thread GitBox
alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config URL: https://github.com/apache/helix/pull/497#discussion_r332658541 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -388,11 +389,19 @@

[GitHub] [helix] alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config

2019-10-08 Thread GitBox
alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config URL: https://github.com/apache/helix/pull/497#discussion_r332658622 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -388,11 +389,19 @@

[GitHub] [helix] alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config

2019-10-08 Thread GitBox
alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config URL: https://github.com/apache/helix/pull/497#discussion_r332659487 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -388,11 +389,19 @@

[GitHub] [helix] alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config

2019-10-08 Thread GitBox
alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config URL: https://github.com/apache/helix/pull/497#discussion_r332659308 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@ -989,47 +988,65 @@

[GitHub] [helix] alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config

2019-10-08 Thread GitBox
alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config URL: https://github.com/apache/helix/pull/497#discussion_r332659068 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@ -989,47 +988,65 @@

[GitHub] [helix] alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config

2019-10-08 Thread GitBox
alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config URL: https://github.com/apache/helix/pull/497#discussion_r332658821 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@ -717,41 +717,40 @@

[GitHub] [helix] alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config

2019-10-08 Thread GitBox
alirezazamani commented on a change in pull request #497: Fix job purge logic for job without config URL: https://github.com/apache/helix/pull/497#discussion_r33265 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@ -989,47 +988,65 @@

[GitHub] [helix] alirezazamani commented on issue #461: Investigate FixedTargetTaskAssignmentCalculator

2019-10-08 Thread GitBox
alirezazamani commented on issue #461: Investigate FixedTargetTaskAssignmentCalculator URL: https://github.com/apache/helix/issues/461#issuecomment-539685233 Here is the outcome of the investigation on FixedTargetedTasks: 1- These tasks will be assigned to the instances based on the on