[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313526164 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] jiajunwang commented on issue #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on issue #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#issuecomment-520947396 Addressed comments. For the format related issues, @pkuwm will be working on refining the format file. We can fix the style after that.

[GitHub] [helix] jiajunwang merged pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang merged pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [helix] jiajunwang commented on issue #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on issue #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#issuecomment-520951227 Approved by @dasahcc and I will merge it to our working branch soon. This is an

[GitHub] [helix] jiajunwang commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

2019-08-13 Thread GitBox
jiajunwang commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-520933866 One more thing, please also revisit the previous comments and resolve them if the problem has been fixed or no

[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313540444 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313526817 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313526888 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-12 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313051561 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-12 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r312999527 ## File path:

[GitHub] [helix] narendly edited a comment on issue #400: TASK: Drop all tasks whose requested states are DROPPED

2019-08-12 Thread GitBox
narendly edited a comment on issue #400: TASK: Drop all tasks whose requested states are DROPPED URL: https://github.com/apache/helix/pull/400#issuecomment-520519430 > I think you have the unit test to cover that. Can you add it in this PR? A unit test has been added:

[GitHub] [helix] chenboat edited a comment on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

2019-08-12 Thread GitBox
chenboat edited a comment on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-519807855 > @chenboat Please refer to HelixManagerProperties. We should be able to do something similar for the monitors.

[GitHub] [helix] narendly closed issue #375: TASK: Drop all tasks whose requested states are DROPPED

2019-08-12 Thread GitBox
narendly closed issue #375: TASK: Drop all tasks whose requested states are DROPPED URL: https://github.com/apache/helix/issues/375 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] narendly commented on issue #400: TASK: Drop all tasks whose requested states are DROPPED

2019-08-12 Thread GitBox
narendly commented on issue #400: TASK: Drop all tasks whose requested states are DROPPED URL: https://github.com/apache/helix/pull/400#issuecomment-520526116 This PR is ready to be merged, approved by @dasahcc This is an

[GitHub] [helix] narendly merged pull request #400: TASK: Drop all tasks whose requested states are DROPPED

2019-08-12 Thread GitBox
narendly merged pull request #400: TASK: Drop all tasks whose requested states are DROPPED URL: https://github.com/apache/helix/pull/400 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] narendly commented on issue #400: TASK: Drop all tasks whose requested states are DROPPED

2019-08-12 Thread GitBox
narendly commented on issue #400: TASK: Drop all tasks whose requested states are DROPPED URL: https://github.com/apache/helix/pull/400#issuecomment-520519430 > I think you have the unit test to cover that. Can you add it in this PR? A unit test has been added:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-12 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313049887 ## File path:

[GitHub] [helix] jiajunwang merged pull request #395: Fix the CallbackHandler registration logic in DistributedLeaderElection

2019-08-12 Thread GitBox
jiajunwang merged pull request #395: Fix the CallbackHandler registration logic in DistributedLeaderElection URL: https://github.com/apache/helix/pull/395 This is an automated message from the Apache Git Service. To respond

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-12 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313045054 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-12 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313046843 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-12 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313050451 ## File path:

[GitHub] [helix] jiajunwang closed issue #394: Leader controller loses all the callback handlers after leadership switch

2019-08-12 Thread GitBox
jiajunwang closed issue #394: Leader controller loses all the callback handlers after leadership switch URL: https://github.com/apache/helix/issues/394 This is an automated message from the Apache Git Service. To respond to

[GitHub] [helix] i3wangyi closed pull request #367: Add transient cache for CustomRestClient implementation

2019-08-12 Thread GitBox
i3wangyi closed pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] jiajunwang commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

2019-08-12 Thread GitBox
jiajunwang commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#discussion_r313065938 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313592714 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313594282 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313593380 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313596107 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313598334 ## File path:

[GitHub] [helix] i3wangyi commented on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue

2019-08-13 Thread GitBox
i3wangyi commented on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#issuecomment-52034 The PR is approved by @dasahcc, ready to be merged This

[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313600224 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] i3wangyi commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313598965 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] jiajunwang closed issue #372: Implement the Cluster Model data provider for the WAGED rebalancer

2019-08-13 Thread GitBox
jiajunwang closed issue #372: Implement the Cluster Model data provider for the WAGED rebalancer URL: https://github.com/apache/helix/issues/372 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] dasahcc merged pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

2019-08-13 Thread GitBox
dasahcc merged pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] jiajunwang opened a new issue #402: Implement the WAGED rebalancer

2019-08-13 Thread GitBox
jiajunwang opened a new issue #402: Implement the WAGED rebalancer URL: https://github.com/apache/helix/issues/402 Based on the existing components (or the interfaces), we can now implement the initial version of the WAGED rebalancer. AC: - Implement the rebalancer with unit

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313634598 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313636365 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313634204 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313634821 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313634758 ## File path:

[GitHub] [helix] dasahcc merged pull request #403: Bump up the snapshot version.

2019-08-13 Thread GitBox
dasahcc merged pull request #403: Bump up the snapshot version. URL: https://github.com/apache/helix/pull/403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [helix] jiajunwang opened a new pull request #403: Bump up the snapshot version.

2019-08-13 Thread GitBox
jiajunwang opened a new pull request #403: Bump up the snapshot version. URL: https://github.com/apache/helix/pull/403 Also fix the missing helix-agent snapshot update logic in the bump-up.comand. This is an automated message

[GitHub] [helix] jiajunwang commented on issue #404: Release note for 0.9.1.

2019-08-13 Thread GitBox
jiajunwang commented on issue #404: Release note for 0.9.1. URL: https://github.com/apache/helix/pull/404#issuecomment-521056458 ![Screenshot from 2019-08-13 17-11-59](https://user-images.githubusercontent.com/1803880/62986007-9ddec800-bdee-11e9-83ac-60b5e2dcca16.png)

[GitHub] [helix] i3wangyi commented on issue #381: Implement the POC work greedy constraint based algorithm

2019-08-13 Thread GitBox
i3wangyi commented on issue #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#issuecomment-521073125 don't read, I've messed up the commits and will get it reverted

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313637216 ## File path:

[GitHub] [helix] jiajunwang opened a new pull request #404: Release note for 0.9.1.

2019-08-13 Thread GitBox
jiajunwang opened a new pull request #404: Release note for 0.9.1. URL: https://github.com/apache/helix/pull/404 Release note for 0.9.1 Note: This is more like a bug fixing release. So no new features. This is an

[GitHub] [helix] i3wangyi closed issue #366: Performance issues in `InstancesAccessor#getParallelStoppableInstances`

2019-08-13 Thread GitBox
i3wangyi closed issue #366: Performance issues in `InstancesAccessor#getParallelStoppableInstances` URL: https://github.com/apache/helix/issues/366 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314758928 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java ## @@ -602,4 +590,28

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314766079 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314762163 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314760821 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java ## @@ -269,29 +271,15

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314763636 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314761529 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314762972 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314761291 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java ## @@ -602,4 +590,28

[GitHub] [helix] alirezazamani opened a new pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
alirezazamani opened a new pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410 **Issues** Fix the execution delay for the jobs #409. **Description** In the Task Framework part of helix, execution delay for the jobs is not

[GitHub] [helix] jiajunwang commented on issue #406: Revert "Reenable helix-front module for official release."

2019-08-14 Thread GitBox
jiajunwang commented on issue #406: Revert "Reenable helix-front module for official release." URL: https://github.com/apache/helix/pull/406#issuecomment-521416049 Thanks, I will do the merge. This is an automated message

[GitHub] [helix] jiajunwang merged pull request #406: Revert "Reenable helix-front module for official release."

2019-08-14 Thread GitBox
jiajunwang merged pull request #406: Revert "Reenable helix-front module for official release." URL: https://github.com/apache/helix/pull/406 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] alirezazamani opened a new issue #409: TASK: Execution delay is not respected for the jobs

2019-08-14 Thread GitBox
alirezazamani opened a new issue #409: TASK: Execution delay is not respected for the jobs URL: https://github.com/apache/helix/issues/409 Current implementation of Task Framework checks if a Job is ready for the scheduling or not. If not, the job is inserted in the inflight jobs without

[GitHub] [helix] narendly opened a new pull request #408: Improve equals() on config objects

2019-08-14 Thread GitBox
narendly opened a new pull request #408: Improve equals() on config objects URL: https://github.com/apache/helix/pull/408 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes $407 ### Description - [x] Here are

[GitHub] [helix] narendly opened a new issue #407: Fix config classes' equals()

2019-08-14 Thread GitBox
narendly opened a new issue #407: Fix config classes' equals() URL: https://github.com/apache/helix/issues/407 ClusterConfig, InstanceConfig, ResourceConfig's equals() methods were only comparing the IDs, which is not desirable because it is possible to have two instances of each with the

[GitHub] [helix] narendly commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-14 Thread GitBox
narendly commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r314149434 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] narendly commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-14 Thread GitBox
narendly commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r314149772 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] narendly commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-14 Thread GitBox
narendly commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r314149696 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] narendly commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-14 Thread GitBox
narendly commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r314149317 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] dasahcc merged pull request #405: Fix ZNode does not exist in HealthCheck

2019-08-14 Thread GitBox
dasahcc merged pull request #405: Fix ZNode does not exist in HealthCheck URL: https://github.com/apache/helix/pull/405 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [helix] dasahcc commented on issue #405: Fix ZNode does not exist in HealthCheck

2019-08-14 Thread GitBox
dasahcc commented on issue #405: Fix ZNode does not exist in HealthCheck URL: https://github.com/apache/helix/pull/405#issuecomment-521459782 This PR is ready to be merged, approved by @i3wangyi This is an automated message

[GitHub] [helix] dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer

2019-08-16 Thread GitBox
dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417#discussion_r314834007 ## File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java

[GitHub] [helix] jiajunwang commented on a change in pull request #413: Add cluster level default instance config.

2019-08-16 Thread GitBox
jiajunwang commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314870372 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #413: Add cluster level default instance config.

2019-08-16 Thread GitBox
narendly commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314527668 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -700,6 +703,48 @@

[GitHub] [helix] narendly commented on a change in pull request #413: Add cluster level default instance config.

2019-08-16 Thread GitBox
narendly commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314770784 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #413: Add cluster level default instance config.

2019-08-16 Thread GitBox
narendly commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314769226 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -700,6 +703,48 @@

[GitHub] [helix] narendly commented on a change in pull request #413: Add cluster level default instance config.

2019-08-16 Thread GitBox
narendly commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314527521 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -700,6 +703,48 @@

[GitHub] [helix] narendly commented on a change in pull request #413: Add cluster level default instance config.

2019-08-16 Thread GitBox
narendly commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314770359 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestAssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #413: Add cluster level default instance config.

2019-08-16 Thread GitBox
narendly commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314771903 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang commented on a change in pull request #413: Add cluster level default instance config.

2019-08-16 Thread GitBox
jiajunwang commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314870911 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] dasahcc commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
dasahcc commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314837500 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java ## @@ -602,4 +590,28 @@

[GitHub] [helix] dasahcc commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-16 Thread GitBox
dasahcc commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314838217 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java ## @@ -165,7 +165,9 @@

[GitHub] [helix] dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer

2019-08-16 Thread GitBox
dasahcc commented on a change in pull request #417: Move partition health check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417#discussion_r314836223 ## File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java

[GitHub] [helix] jiajunwang commented on a change in pull request #413: Add cluster level default instance config.

2019-08-16 Thread GitBox
jiajunwang commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314872913 ## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestAssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #417: Move partition health check method into dataAccessor layer

2019-08-16 Thread GitBox
i3wangyi commented on a change in pull request #417: Move partition health check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417#discussion_r314912447 ## File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java

[GitHub] [helix] narendly opened a new issue #411: Integrate ChangeDetector with the resource pipeline

2019-08-14 Thread GitBox
narendly opened a new issue #411: Integrate ChangeDetector with the resource pipeline URL: https://github.com/apache/helix/issues/411 Create a stage after ReadClusterDataStage for cluster change detection. This is an

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-14 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r314180370 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

2019-08-14 Thread GitBox
narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r314180856 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

2019-08-14 Thread GitBox
narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r314181444 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

2019-08-14 Thread GitBox
narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r314180937 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

2019-08-14 Thread GitBox
narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r314180593 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

2019-08-14 Thread GitBox
narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r314180887 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

2019-08-14 Thread GitBox
narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r314181390 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314176167 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314176056 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314176558 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314176632 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314176155 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314175964 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314175903 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314176396 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314177297 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java ## @@ -165,7 +165,9 @@

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314176671 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409)

2019-08-14 Thread GitBox
narendly commented on a change in pull request #410: Fix the execution delay for the jobs (409) URL: https://github.com/apache/helix/pull/410#discussion_r314176020 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestExecutionDelay.java ## @@ -0,0

  1   2   3   4   5   6   7   8   9   10   >