[GitHub] [helix] zhangmeng916 commented on issue #673: Add Helix Distributed lock module
zhangmeng916 commented on issue #673: Add Helix Distributed lock module URL: https://github.com/apache/helix/pull/673#issuecomment-574404289 This PR is ready to be merged, approved by @jiajunwang Final commit message "Add Helix Lock module" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on issue #673: Add Helix Distributed lock module
zhangmeng916 commented on issue #673: Add Helix Distributed lock module URL: https://github.com/apache/helix/pull/673#issuecomment-573820490 > What is this test result from? Did you run the test on the helix-lock module or helix-core? Yeah, this is helix-core. Just wanted to show that the new module doesn't break it. But you're right. It doesn't test new module. We will have test when we add implementation code in lock module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
