Re: [PR] Make SwapIn Instance respect its own disabled partitions list during swap operation [helix]
xyuanlu merged PR #2867: URL: https://github.com/apache/helix/pull/2867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
Re: [PR] Make SwapIn Instance respect its own disabled partitions list during swap operation [helix]
GrantPSpencer commented on PR #2867: URL: https://github.com/apache/helix/pull/2867#issuecomment-2265898577 Pull request approved @junkaixue, @zpinto Commit message: Make SwapIn Instance respect its own disabled partitions list during swap operation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
Re: [PR] Make SwapIn Instance respect its own disabled partitions list during swap operation [helix]
junkaixue commented on code in PR #2867:
URL: https://github.com/apache/helix/pull/2867#discussion_r1702133955
##
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java:
##
@@ -135,16 +135,21 @@ public void process(ClusterEvent event) throws Exception {
}
private String selectSwapInState(StateModelDefinition stateModelDef,
Map stateMap,
- String swapOutInstance) {
+ String swapOutInstance, String swapInInstance, String resource, String
partition, ResourceControllerDataProvider cache) {
// If the swap-in node is live, select state with the following logic:
// 1. If the swap-out instance's replica is in the stateMap:
+// - if the swap-in instance is disabled for the partition, select the
swap-in instance's replica to the initialState.
Review Comment:
NIT: "set" instead of "select"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
