[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9053 to look at the new patch set (#3). Change subject: IMPALA-6416: extend Thread::Create to track instance id

[Impala-ASF-CR] IMPALA-5717: Support for ORC data files

2018-02-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for ORC data files .. Patch Set 3: (24 comments) Thanks, Tim! Your comments are really useful!

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 6: Code-Review+1 LGTM! -- To view,

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-02 Thread Anonymous Coward (Code Review)
fwij...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9191 Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. IMPALA-5269: Fix issue with final line

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-02-02 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#2). Change subject: IMPALA-6204: Remove external DataSource .. IMPALA-6204:

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 8: (5 comments) Did you

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 2: Code-Review-1 Sorry, hold off on this please. I rebased and

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9192 Change subject: IMPALA-6204: Remove external DataSource .. IMPALA-6204: Remove external DataSource Removes DataSourceScanNode,

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 1: Code-Review+2 The conflict was boring, yes? I'd prefer

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-02 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9153 to look at the new patch set (#10). Change subject: IMPALA-5293: Turn insert clustering on by default ..

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 6: Build started:

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This patch reserves SQL:2016

[Impala-ASF-CR](2.x) IMPALA-3916: Change reserved words version to 2.11.0

2018-02-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9201 Change subject: IMPALA-3916: Change reserved_words_version to 2.11.0 .. IMPALA-3916: Change reserved_words_version to 2.11.0 Impala 2.x

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-02 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9164 to look at the new patch set (#3). Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC ..

[Impala-ASF-CR] IMPALA-6471: [docs] Corrected ALTER TABLE ADD PARTITION syntax for Kudu table

2018-02-02 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9187 Change subject: IMPALA-6471: [docs] Corrected ALTER TABLE ADD PARTITION syntax for Kudu table .. IMPALA-6471: [docs] Corrected ALTER

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 1: (4

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 10: Code-Review+2 PS10 is a final rebase before

[Impala-ASF-CR] IMPALA-6475: Enable running TPCH on Kudu

2018-02-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9206 ) Change subject: IMPALA-6475: Enable running TPCH on Kudu .. Patch Set 1: Code-Review+2 Yeah, this is basically the solution path I had

[Impala-ASF-CR] IMPALA-6476: Skip krpc mem test that uses stress options

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9207 ) Change subject: IMPALA-6476: Skip krpc mem test that uses stress options .. IMPALA-6476: Skip krpc mem test that uses

[Impala-ASF-CR] IMPALA-6476: Skip krpc mem test that uses stress options

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9207 ) Change subject: IMPALA-6476: Skip krpc mem test that uses stress options .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6475: Enable running TPCH on Kudu

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9206 ) Change subject: IMPALA-6475: Enable running TPCH on Kudu .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: Build failed:

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. IMPALA-6113: Skip row groups with

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: Build started:

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: oops the regex_escape change is already in this branch.

[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 ) Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9208 ) Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query .. IMPALA-4924 addendum: Change

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 11: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. IMPALA-5293: Turn insert clustering on by default

[Impala-ASF-CR] IMPALA-6337: Fix inifinte loop in Impala shell

2018-02-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9195 Change subject: IMPALA-6337: Fix inifinte loop in Impala shell .. IMPALA-6337: Fix inifinte loop in Impala shell The patch uses a

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-02-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. IMPALA-5990: End-to-end compression of metadata Currently the catalog

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 12: Build started:

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9198 Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This patch reserves SQL:2016

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 1: A conflict in AnalyzeStmtTest.java. I'm not sure if the

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 3: Code-Review+2 (1 comment) Rebase, carry +2.

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 3: Build started:

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. IMPALA-5269: Fix issue with final line of query

[Impala-ASF-CR] IMPALA-6369: Exchange node's memory usage should include its receiver's

2018-02-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9202 Change subject: IMPALA-6369: Exchange node's memory usage should include its receiver's .. IMPALA-6369: Exchange node's memory usage

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. IMPALA-6396: Exchange node's memory usage should

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 3: I think this is now reviewable. I ran core tests

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-02 Thread Alex Behm (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9139 to look at the new patch set (#4). Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. ..

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 4: Code-Review+2 Rebase and resolve conflicts -- To

[Impala-ASF-CR] IMPALA-6475: Enable running TPCH on Kudu

2018-02-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9206 Change subject: IMPALA-6475: Enable running TPCH on Kudu .. IMPALA-6475: Enable running TPCH on Kudu Change-Id:

[Impala-ASF-CR] IMPALA-6475: Enable running TPCH on Kudu

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9206 ) Change subject: IMPALA-6475: Enable running TPCH on Kudu .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-02 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9186 to look at the new patch set (#2). Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 1:

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: Build started:

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 2: Code-Review+2 Carry over Philip's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-02 Thread Alex Behm (Code Review)
Alex Behm has removed a vote on this change. Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Removed Code-Review+2 by Alex Behm -- To view, visit

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#3). Change subject: IMPALA-6204: Remove external DataSource .. IMPALA-6204:

[Impala-ASF-CR] IMPALA-6471: [docs] Corrected ALTER TABLE ADD PARTITION syntax for Kudu table

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9187 ) Change subject: IMPALA-6471: [docs] Corrected ALTER TABLE ADD PARTITION syntax for Kudu table .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. IMPALA-5990: End-to-end compression of metadata

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 12: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8997 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. IMPALA-6338: Fix flaky

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-3916: Change reserved words version to 2.11.0

2018-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9201 ) Change subject: IMPALA-3916: Change reserved_words_version to 2.11.0 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-02 Thread Bikramjeet Vig (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#9). Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

[Impala-ASF-CR] IMPALA-6475: Enable running TPCH on Kudu

2018-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9206 ) Change subject: IMPALA-6475: Enable running TPCH on Kudu .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6476: Skip krpc mem test that uses stress options

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9207 ) Change subject: IMPALA-6476: Skip krpc mem test that uses stress options .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9208 ) Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query .. IMPALA-4924 addendum: Change result type to

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. IMPALA-6337: Fix infinite loop in Impala shell The patch uses a

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. IMPALA-5269: Fix issue with final line of query

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 8: (5 comments) > (5 comments)

[Impala-ASF-CR] IMPALA-6476: Skip krpc mem test that uses stress options

2018-02-02 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9207 Change subject: IMPALA-6476: Skip krpc mem test that uses stress options .. IMPALA-6476: Skip krpc mem test that uses stress options Some

[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 ) Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 ) Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query .. Patch Set 2: Code-Review+2 For some reason

[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 ) Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6471: [docs] Corrected ALTER TABLE ADD PARTITION syntax for Kudu table

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9187 ) Change subject: IMPALA-6471: [docs] Corrected ALTER TABLE ADD PARTITION syntax for Kudu table .. IMPALA-6471: [docs]

[Impala-ASF-CR] IMPALA-6471: [docs] Corrected ALTER TABLE ADD PARTITION syntax for Kudu table

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9187 ) Change subject: IMPALA-6471: [docs] Corrected ALTER TABLE ADD PARTITION syntax for Kudu table .. Patch Set 1: Verified+1 --

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9208 Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query .. IMPALA-4924 addendum: Change result type to

[Impala-ASF-CR] IMPALA-6476: Skip krpc mem test that uses stress options

2018-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9207 ) Change subject: IMPALA-6476: Skip krpc mem test that uses stress options .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4924 addendum: Change result type to decimal in a TPCH query

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9208 ) Change subject: IMPALA-4924 addendum: Change result type to decimal in a TPCH query .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 11: Code-Review+2 Hit IMPALA-6472, rebased, carrying

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#6). Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 8: Code-Review+1 Thanks for taking care of this.

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 6: (2 comments)