[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 7: Any more comments? -- To view, visit

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-19 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9306 to look at the new patch set (#9). Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#8). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

[Impala-ASF-CR] KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2018-02-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9361 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] [security] test and fixes for TLS socket EINTR issues

2018-02-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9360 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6482: add QUERY TIME LIMIT S option

2018-02-19 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9227 to look at the new patch set (#6). Change subject: IMPALA-6482: add QUERY_TIME_LIMIT_S option ..

[Impala-ASF-CR] IMPALA-6482: add QUERY TIME LIMIT S option

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add QUERY_TIME_LIMIT_S option .. Patch Set 5: (2 comments) I also considered calling this something like

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 8: Code-Review+2 Carry Tim's +2

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#15). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 14: (4 comments) Thanks for the review. Please see PS15

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 8: Failing in "Waiting for HDFS replication" -- To

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 ) Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 15: Code-Review+2 (5 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. IMPALA-5518: Allocate

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 8: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9352 ) Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() .. IMPALA-6423: HDFS scanner

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 14: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 15: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#16). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#14). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: Code-Review+2 (2 comments) This seems like an

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 13: (6 comments) PS13 contains the rebase. PS14 should

[Impala-ASF-CR] IMPALA-6482: add QUERY TIME LIMIT S option

2018-02-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add QUERY_TIME_LIMIT_S option .. Patch Set 5: (2 comments) I just looked at how these two were

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: GVO failed due to infrastructure issue (IMPALA-6394)

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#17). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 17: (4 comments) Please see my inline comments and PS17.

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-02-19 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#11). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Laszlo Gaal, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#9). Change subject: IMPALA-5801: Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: (4 comments)

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-19 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9306 to look at the new patch set (#6). Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables

[Impala-ASF-CR] IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

2018-02-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9358 to look at the new patch set (#2). Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-19 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 ) Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

2018-02-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9358 Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN .. IMPALA-6538: Fix read path when Parquet

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9358 ) Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN .. Patch Set 2: (2 comments) Seems fine in

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-19 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9306 to look at the new patch set (#7). Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-19 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#31). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-19 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#29). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 30: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 29: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 23: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 28: (3 comments)

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 31: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 28: (1 comment)

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-19 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#17). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool ..

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 17: Rebased and fixed a couple of bugs with

[Impala-ASF-CR] IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9358 ) Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 ) Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 ) Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 ) Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 7: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-19 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9306 to look at the new patch set (#8). Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables

[Impala-ASF-CR] IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

2018-02-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9358 ) Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#12). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 11: (11 comments) Thanks for the review. Please see PS11

[Impala-ASF-CR] KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2018-02-19 Thread Michael Ho (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9361 to review the following change. Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev

[Impala-ASF-CR] [security] test and fixes for TLS socket EINTR issues

2018-02-19 Thread Michael Ho (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9360 to review the following change. Change subject: [security] test and fixes for TLS socket EINTR issues

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Michael Ho (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9359 to review the following change. Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() ..

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] [security] test and fixes for TLS socket EINTR issues

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9360 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Patch Set 1: Clean application of the original patch. -- To

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Clean application of the original patch. -- To

[Impala-ASF-CR] KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9361 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: Clean application of the

[Impala-ASF-CR] KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9361 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Removed reviewer Kudu Jenkins. -- To

[Impala-ASF-CR] [security] test and fixes for TLS socket EINTR issues

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9360 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#13). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage