[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#3). Change subject: IMPALA-2567: Enable KRPC by default .. IMPALA-2567:

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Gabor Kaszab, Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9381 to look at the new patch set (#5). Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 5: (2 comments) Thanks for

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 2: (3 comments) The existing jenkins jobs to test with KRPC enabled

[Impala-ASF-CR] Revert IMPALA-4835 and dependent changes

2018-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9480 ) Change subject: Revert IMPALA-4835 and dependent changes .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 10: (1 comment) Sorry for the slow turnaround

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 14: I've been neglecting reviews - need to get

[Impala-ASF-CR] IMPALA-6338: xfail test profile fragment instances

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9467 ) Change subject: IMPALA-6338: xfail test_profile_fragment_instances .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6338: xfail test profile fragment instances

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9467 ) Change subject: IMPALA-6338: xfail test_profile_fragment_instances .. IMPALA-6338: xfail

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-02 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9484 Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL .. IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

[Impala-ASF-CR] Revert IMPALA-4835 and dependent changes

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9480 ) Change subject: Revert IMPALA-4835 and dependent changes .. Revert IMPALA-4835 and dependent changes Revert

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 1: Code-Review+2 I'm ok with this

[Impala-ASF-CR] IMPALA-6338: xfail test profile fragment instances

2018-03-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9467 Change subject: IMPALA-6338: xfail test_profile_fragment_instances .. IMPALA-6338: xfail test_profile_fragment_instances

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9469 Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. IMPALA-6394: Restart HDFS when blocks are under replicated

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6547: [DOCS] Correct default encoding for INT

2018-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9402 ) Change subject: IMPALA-6547: [DOCS] Correct default encoding for INT .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6547: [DOCS] Correct default encoding for INT

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9402 ) Change subject: IMPALA-6547: [DOCS] Correct default encoding for INT .. Patch Set 1: Build started:

[Impala-ASF-CR] Revert IMPALA-4835 and dependent changes

2018-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9480 Change subject: Revert IMPALA-4835 and dependent changes .. Revert IMPALA-4835 and dependent changes Revert "IMPALA-6585: increase

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-03-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6338: xfail test profile fragment instances

2018-03-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9467 ) Change subject: IMPALA-6338: xfail test_profile_fragment_instances .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-02 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6547: [DOCS] Correct default encoding for INT

2018-03-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9402 ) Change subject: IMPALA-6547: [DOCS] Correct default encoding for INT .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] Revert IMPALA-4835 and dependent changes

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9480 ) Change subject: Revert IMPALA-4835 and dependent changes .. Patch Set 1: Build started:

[Impala-ASF-CR] Revert IMPALA-4835 and dependent changes

2018-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9480 ) Change subject: Revert IMPALA-4835 and dependent changes .. Patch Set 1: The reverts were mostly clean. I had to resolve some minor

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-03-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. IMPALA-5690: Part 1: Rename ostream operators for thrift

[Impala-ASF-CR] IMPALA-6338: xfail test profile fragment instances

2018-03-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9467 ) Change subject: IMPALA-6338: xfail test_profile_fragment_instances .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6338: xfail test profile fragment instances

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9467 ) Change subject: IMPALA-6338: xfail test_profile_fragment_instances .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#4). Change subject: IMPALA-2567: Enable KRPC by default .. IMPALA-2567:

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 Dependency changes: -

[Impala-ASF-CR] IMPALA-6547: [DOCS] Correct default encoding for INT

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9402 ) Change subject: IMPALA-6547: [DOCS] Correct default encoding for INT .. IMPALA-6547: [DOCS] Correct default encoding

[Impala-ASF-CR] IMPALA-6547: [DOCS] Correct default encoding for INT

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9402 ) Change subject: IMPALA-6547: [DOCS] Correct default encoding for INT .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 4: Hold off from merging until the builds are in better shape. -- To

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. IMPALA-6394: Restart HDFS when blocks are under replicated

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-02 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. Patch Set 1: impalad crashes with this patch

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-02 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. IMPALA-3651: [DOCS] Doc for MURMUR_HASH()

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 11: (2 comments)

[Impala-ASF-CR] Revert IMPALA-4835 and dependent changes

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9480 ) Change subject: Revert IMPALA-4835 and dependent changes .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 ) Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL .. Patch Set 1: I am not 100% sure how to best verify the

[Impala-ASF-CR] IMPALA-6585: increase test low mem limit q21 limit

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9449 ) Change subject: IMPALA-6585: increase test_low_mem_limit_q21 limit .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6585: increase test low mem limit q21 limit

2018-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9449 ) Change subject: IMPALA-6585: increase test_low_mem_limit_q21 limit .. IMPALA-6585: increase test_low_mem_limit_q21