[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2018-04-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 8: @Csaba, thanks for your review. I have been

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-04-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: @Gabor and Attila, thanks for your

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 9: Yeah, I needed to

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Fredy Wijaya, Dimitris Tsirogiannis, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9090 to look at the new patch set (#9). Change subject: IMPALA-5903: Inconsistent specification of result set and

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 18: Hi all, this patch is ready to be reviewed. -- To

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-04-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 19: @Alex, thank you for the comment. The problem was

[Impala-ASF-CR] Remove Yarn from minicluster by default. (2nd try)

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9970 ) Change subject: Remove Yarn from minicluster by default. (2nd try) .. Patch Set 1: This is a continuation of

[Impala-ASF-CR] Remove Yarn from minicluster by default. (2nd try)

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9970 Change subject: Remove Yarn from minicluster by default. (2nd try) .. Remove Yarn from minicluster by default. (2nd try) Remove Yarn

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9972 Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

[Impala-ASF-CR] Remove Yarn from minicluster by default. (2nd try)

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9970 ) Change subject: Remove Yarn from minicluster by default. (2nd try) .. Patch Set 1: Build started:

[Impala-ASF-CR] Remove Yarn from minicluster by default. (2nd try)

2018-04-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9970 ) Change subject: Remove Yarn from minicluster by default. (2nd try) .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit

[Impala-ASF-CR] Revert "Remove Yarn from minicluster by default."

2018-04-10 Thread Philip Zeyliger (Code Review)
Hello Michael Brown, Alex Behm, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9969 to review the following change. Change subject: Revert "Remove Yarn from minicluster by default." ..

[Impala-ASF-CR] Remove Yarn from minicluster by default.

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster by default. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Revert "Remove Yarn from minicluster by default."

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has reverted this change. ( http://gerrit.cloudera.org:8080/9969 ) Change subject: Revert "Remove Yarn from minicluster by default." .. Uploaded patch set 1. -- To view, visit

[Impala-ASF-CR](2.x) Updating ignored commits.

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9971 ) Change subject: Updating ignored_commits. .. Patch Set 1: Verified+1 I ran cherry-pick successfully with this. GVO wouldn't do

[Impala-ASF-CR](2.x) Updating ignored commits.

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9971 Change subject: Updating ignored_commits. .. Updating ignored_commits. Cherrypicking was stuck due to two changes needing to have

[Impala-ASF-CR](2.x) Updating ignored commits.

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9971 ) Change subject: Updating ignored_commits. .. Updating ignored_commits. Cherrypicking was stuck due to two changes needing to

[Impala-ASF-CR] IMPALA-6805: Show current database in Impala shell prompt

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. Patch Set 8: Build started:

[Impala-ASF-CR] Remove Yarn from minicluster by default.

2018-04-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster by default. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Revert "Remove Yarn from minicluster by default."

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9969 ) Change subject: Revert "Remove Yarn from minicluster by default." .. Patch Set 1: Verified+1 Code-Review+2 I screwed up and pushed

[Impala-ASF-CR] IMPALA-6805: Show current database in Impala shell prompt

2018-04-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9968 Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215: Removes race when using LibCache. Re-do the previously

[Impala-ASF-CR] Remove Yarn from minicluster by default.

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster by default. .. Remove Yarn from minicluster by default. Turns out that we start

[Impala-ASF-CR] Remove Yarn from minicluster by default.

2018-04-10 Thread Philip Zeyliger (Code Review)
Hello Michael Brown, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9264 to look at the new patch set (#3). Change subject: Remove Yarn from minicluster by default. .. Remove

[Impala-ASF-CR] Revert "Remove Yarn from minicluster by default."

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9969 ) Change subject: Revert "Remove Yarn from minicluster by default." .. Revert "Remove Yarn from minicluster by default." This

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. Patch Set 2: (2 comments)

[Impala-ASF-CR](2.x) Updating ignored commits.

2018-04-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9971 ) Change subject: Updating ignored_commits. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9971 To

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 11: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9972 ) Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6

2018-04-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9983 Change subject: IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6 .. IMPALA-6831: [DOCS] Remove the note about

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 2: Code-Review+1 All the changes looked

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9980 Change subject: IMPALA-6723: [DOCS] Hints for CTAS .. IMPALA-6723: [DOCS] Hints for CTAS - Moved the Hints doc out of the SELECT section.

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-10 Thread Bikramjeet Vig (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9964 to look at the new patch set (#2). Change subject: IMPALA-5814: Remove startup flag to disable admission control

[Impala-ASF-CR] Bump Kudu version to a954418

2018-04-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9982 Change subject: Bump Kudu version to a954418 .. Bump Kudu version to a954418 Change-Id:

[native-toolchain-CR] Bump Kudu version to a954418

2018-04-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9981 Change subject: Bump Kudu version to a954418 .. Bump Kudu version to a954418 Change-Id:

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 1: > Could you add this flag to the

[Impala-ASF-CR] IMPALA-6518,IMPALA-6340: Check that decimal types are compatible in FE

2018-04-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9930 ) Change subject: IMPALA-6518,IMPALA-6340: Check that decimal types are compatible in FE .. Patch Set 1: These choices are mostly modeled

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 21: (6 comments)

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9980 ) Change subject: IMPALA-6723: [DOCS] Hints for CTAS .. IMPALA-6723: [DOCS] Hints for CTAS - Moved the Hints doc out of the SELECT section.

[Impala-ASF-CR] IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6

2018-04-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9983 ) Change subject: IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6 .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Fredy Wijaya, Dimitris Tsirogiannis, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9090 to look at the new patch set (#11). Change subject: IMPALA-5903: Inconsistent specification of result set and

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9968 to look at the new patch set (#3). Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215:

[Impala-ASF-CR] Remove Yarn from minicluster by default. (2nd try)

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9970 ) Change subject: Remove Yarn from minicluster by default. (2nd try) .. Remove Yarn from minicluster by default. (2nd

[Impala-ASF-CR] Remove Yarn from minicluster by default. (2nd try)

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9970 ) Change subject: Remove Yarn from minicluster by default. (2nd try) .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 1: Code-Review+2 (1 comment) carrying Tim's +2

[Impala-ASF-CR] IMPALA-6710: [DOCS] Update the Partition Insert content

2018-04-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9977 Change subject: IMPALA-6710: [DOCS] Update the Partition Insert content .. IMPALA-6710: [DOCS] Update the Partition Insert content Added

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 2: noticed that the test litters the test cluster with

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 3: Code-Review+2 carrying tim's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6805: Show current database in Impala shell prompt

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9927 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. IMPALA-6805: Show current database in

[Impala-ASF-CR] IMPALA-6805: Show current database in Impala shell prompt

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9968 to look at the new patch set (#2). Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215:

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 2: Code-Review+2 carrying tim's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9951 ) Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents() .. IMPALA-6824: Fix crash in

[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 ) Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents() .. Patch Set 3: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6817: Clean up Impala privilege model

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9942 ) Change subject: IMPALA-6817: Clean up Impala privilege model .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6817: Clean up Impala privilege model

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9942 ) Change subject: IMPALA-6817: Clean up Impala privilege model .. IMPALA-6817: Clean up Impala privilege model When we

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 20: Code-Review+2 You'll still be the author of the

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 20: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9947 ) Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 5: Build failed:

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 5: The restarted statestored is stuck in zombie

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 5: > Patch Set 5: > > ok, this is the custom

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 20: Build started:

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. IMPALA-6793: Fix empty metadata after statestore restarts

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9947 ) Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. IMPALA-6820: Remove _impala_builtins from

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9947 ) Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9984 Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. IMPALA-6623: [DOCS] ltrim and rtrim docs updated Change-Id:

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#19) to the change originally created by Quanlong Huang. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. IMPALA-5717:

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 18: I made a couple of changes to the error handling to

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. IMPALA-5903:

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 11: Verified+1 --

[Impala-ASF-CR] IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/9949 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. IMPALA-6822: Add a query option to control

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9947 ) Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. Patch Set 2: > Patch Set 2: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 5: ok, this is the custom cluster issue I

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-10 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9960 to look at the new patch set (#2). Change subject: IMPALA-6120: Add thread timers for reporting codegen time

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215: Removes race when using LibCache. Re-do

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 20: Code-Review+1 LGTM. Thank you Tim! The errors now