[Impala-ASF-CR] IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12021 ) Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue() .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 3: I think this verify job failed due to

[Impala-ASF-CR] IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12021 ) Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue() .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-05 Thread Csaba Ringhofer (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11984 to look at the new patch set (#5). Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

[Impala-ASF-CR] Build parquet-reader earlier in test-with-docker

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12025 ) Change subject: Build parquet-reader earlier in test-with-docker .. Patch Set 3: Build started:

[Impala-ASF-CR] Build parquet-reader earlier in test-with-docker

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12025 ) Change subject: Build parquet-reader earlier in test-with-docker .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-05 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-05 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-05 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12004 to look at the new patch set (#7). Change subject: IMPALA-7889: Write new logical types in Parquet

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-05 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12004 to look at the new patch set (#6). Change subject: IMPALA-7889: Write new logical types in Parquet

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-05 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 6: (14 comments)

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7625: test web pages.py backend tests are failing

2018-12-05 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12024 to look at the new patch set (#4). Change subject: IMPALA-7625: test_web_pages.py backend tests are failing

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 7: Build Successful

[Impala-ASF-CR](asf-site) Download 3.1.0

2018-12-05 Thread Zoltan Borok-Nagy (Code Review)
Hello Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12010 to look at the new patch set (#2). Change subject: Download 3.1.0 .. Download 3.1.0 Updated

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base interface for statement-like AST nodes .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7625: test web pages.py backend tests are failing

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12024 ) Change subject: IMPALA-7625: test_web_pages.py backend tests are failing .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7924: Generate Thrift 11 Python Code

2018-12-05 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12036 Change subject: IMPALA-7924: Generate Thrift 11 Python Code .. IMPALA-7924: Generate Thrift 11 Python Code Upgrades the version of the

[Impala-ASF-CR] IMPALA-7625: test web pages.py backend tests are failing

2018-12-05 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12024 to look at the new patch set (#3). Change subject: IMPALA-7625: test_web_pages.py backend tests are failing

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 6: (1 comment) Any reviews on this

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 6: Build Successful

[Impala-ASF-CR](asf-site) Download 3.1.0

2018-12-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12010 ) Change subject: Download 3.1.0 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12010/1/downloads.html File

[native-toolchain-CR] IMPALA-7924: Add Thrift 0.11.0 to the toolchain

2018-12-05 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12034 Change subject: IMPALA-7924: Add Thrift 0.11.0 to the toolchain .. IMPALA-7924: Add Thrift 0.11.0 to the toolchain Adds Thrift 0.11.0

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 3: Gabor, it is not clear from

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 10: Tim, I can take a look at this one. -- To

[Impala-ASF-CR] IMPALA-7625: test web pages.py backend tests are failing

2018-12-05 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12024 ) Change subject: IMPALA-7625: test_web_pages.py backend tests are failing .. Patch Set 2: (8 comments)

[Impala-ASF-CR](asf-site) Download 3.1.0

2018-12-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12010 ) Change subject: Download 3.1.0 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12010 To unsubscribe,

[Impala-ASF-CR] IMPALA-7924: Generate Thrift 11 Python Code

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12036 ) Change subject: IMPALA-7924: Generate Thrift 11 Python Code .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-05 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12018 to look at the new patch set (#4). Change subject: IMPALA-7914: Base interface for statement-like AST nodes

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 3: This patch touches just one FE unit

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 4: Turns out a base class is even more useful than a

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base interface for statement-like AST nodes .. Patch Set 3: (1 comment) Bharath, thanks for the good

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 7: (1 comment) Bharath, thanks for the additional

[Impala-ASF-CR] IMPALA-7473: fix crash when printing decimal with -v=3

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12029 ) Change subject: IMPALA-7473: fix crash when printing decimal with -v=3 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base interface for statement-like AST nodes .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 5: Build Failed

[Impala-ASF-CR] IMPALA-5605: [DOCS] Document how to increase memory resource limit

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12032 ) Change subject: IMPALA-5605: [DOCS] Document how to increase memory resource limit .. Patch Set 3: Verified+1 Build

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#7). Change subject: IMPALA-7842: Expose physical plan for unit testing

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 7: Code-Review+1 (2 comments) My vote is to

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-05 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12018 to look at the new patch set (#5). Change subject: IMPALA-7914: Base class for statement-like AST nodes

[Impala-ASF-CR] IMPALA-7473: fix crash when printing decimal with -v=3

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12029 ) Change subject: IMPALA-7473: fix crash when printing decimal with -v=3 .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-5973: Provide query plan in JSON format

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11974 ) Change subject: IMPALA-5973: Provide query plan in JSON format .. Patch Set 3: Pranay, turns out it would be very handy indeed to

[Impala-ASF-CR] IMPALA-5605: [DOCS] Document how to increase memory resource limit

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12032 ) Change subject: IMPALA-5605: [DOCS] Document how to increase memory resource limit .. Patch Set 3: Build Started

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 9: (8 comments)

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-05 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11955 to look at the new patch set (#4). Change subject: IMPALA-7844: HAVING clause cannot support ordinals ..

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6955: fix test query concurrency and server startup sequence

2018-12-05 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12019 ) Change subject: IMPALA-6955: fix test_query_concurrency and server startup sequence .. IMPALA-6955: fix test_query_concurrency

[Impala-ASF-CR] Print query id when timing out waiting for state

2018-12-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12039 Change subject: Print query id when timing out waiting for state .. Print query id when timing out waiting for state This makes it

[Impala-ASF-CR] Print query id when timing out waiting for state

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12039 ) Change subject: Print query id when timing out waiting for state .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7473: fix crash when printing decimal with -v=3

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12029 ) Change subject: IMPALA-7473: fix crash when printing decimal with -v=3 .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7473: fix crash when printing decimal with -v=3

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12029 ) Change subject: IMPALA-7473: fix crash when printing decimal with -v=3 .. IMPALA-7473: fix crash when printing decimal

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 11: (9 comments)

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 7: Code-Review-1 (2 comments) Tim,

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 7: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7473: fix crash when printing decimal with -v=3

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12029 ) Change subject: IMPALA-7473: fix crash when printing decimal with -v=3 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6955: fix test query concurrency and server startup sequence

2018-12-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12019 ) Change subject: IMPALA-6955: fix test_query_concurrency and server startup sequence .. IMPALA-6955: fix test_query_concurrency and server

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 7: It'd still be good to do a sanity check

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-6955: fix test query concurrency and server startup sequence

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12019 ) Change subject: IMPALA-6955: fix test_query_concurrency and server startup sequence .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. IMPALA-7842: Expose physical plan for unit

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-7625: test web pages.py backend tests are failing

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12024 ) Change subject: IMPALA-7625: test_web_pages.py backend tests are failing .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7924: Generate Thrift 11 Python Code

2018-12-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12036 ) Change subject: IMPALA-7924: Generate Thrift 11 Python Code .. Patch Set 1: Code-Review+1 (2 comments) Thanks! Only minor stuff

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 10: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5605: [DOCS] Document how to increase memory resource limit

2018-12-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12032 ) Change subject: IMPALA-5605: [DOCS] Document how to increase memory resource limit .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5605: [DOCS] Document how to increase memory resource limit

2018-12-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12032 ) Change subject: IMPALA-5605: [DOCS] Document how to increase memory resource limit .. IMPALA-5605: [DOCS] Document how to

[Impala-ASF-CR] IMPALA-5605: [DOCS] Document how to increase memory resource limit

2018-12-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12032 ) Change subject: IMPALA-5605: [DOCS] Document how to increase memory resource limit .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-12-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-7473: fix crash when printing decimal with -v=3

2018-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12029 ) Change subject: IMPALA-7473: fix crash when printing decimal with -v=3 .. Patch Set 2: Code-Review+1 Carry +1. Anyone want to +2?

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-12-05 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11874 to look at the new patch set (#12). Change subject: IMPALA-7738: Implement timeouts for HDFS open calls

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11967 ) Change subject: IMPALA-1048: show sinks in exec summary .. Patch Set 13: Anyone want to +2? -- To view, visit

[Impala-ASF-CR] IMPALA-7738: Implement timeouts for HDFS open calls

2018-12-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11874 ) Change subject: IMPALA-7738: Implement timeouts for HDFS open calls .. Patch Set 12: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7473: fix crash when printing decimal with -v=3

2018-12-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12029 ) Change subject: IMPALA-7473: fix crash when printing decimal with -v=3 .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5605: [DOCS] Document how to increase memory resource limit

2018-12-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12032 ) Change subject: IMPALA-5605: [DOCS] Document how to increase memory resource limit .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5605: [DOCS] Document how to increase memory resource limit

2018-12-05 Thread Alex Rodoni (Code Review)
Hello Matthew Mulder, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12032 to look at the new patch set (#3). Change subject: IMPALA-5605: [DOCS] Document how to increase memory resource limit

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7625: test web pages.py backend tests are failing

2018-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12024 ) Change subject: IMPALA-7625: test_web_pages.py backend tests are failing .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12033 Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. IMPALA-7927: Enhance Rewritten SQL in test files Makes two changes

[Impala-ASF-CR] IMPALA-5605: [DOCS] Document how to increase memory resource limit

2018-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12032 ) Change subject: IMPALA-5605: [DOCS] Document how to increase memory resource limit .. Patch Set 2: Code-Review+2 (1 comment)

[native-toolchain-CR] IMPALA-7924: Add Thrift 0.11.0 to the toolchain

2018-12-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12034 ) Change subject: IMPALA-7924: Add Thrift 0.11.0 to the toolchain .. Patch Set 1: Code-Review+2 -- To view, visit