[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 16: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Paul Rogers (Code Review)
Paul Rogers has removed Tim Armstrong from this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Removed reviewer Tim Armstrong. -- To view, visit

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 16: Bharath, thanks for kicking off the build. Noticed the

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. Patch Set 6: Build Failed

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 5: (6 comments) Few minor comments, lgtm

[Impala-ASF-CR] WIP: IMPALA-5843: Use page index in Parquet files to skip pages

2018-12-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Paul Rogers (Code Review)
Paul Rogers has removed Fredy Wijaya from this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Removed reviewer Fredy Wijaya. -- To view, visit

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-21 Thread Anonymous Coward (Code Review)
vih...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-21 Thread Anonymous Coward (Code Review)
vih...@cloudera.com has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. IMPALA-7970 : Add support for

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 13: (7 comments)

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 16: Build started:

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 16: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 16: This seems to be the problem. 22:55:24 ]

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-21 Thread Anonymous Coward (Code Review)
vih...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12118 Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. IMPALA-7970 : Add support for

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. IMPALA-7047. Refreshing

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 9: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. Patch Set 7: Build Failed

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2018-12-21 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 ) Change subject: WIP IMPALA-7550 Add documentation to profile counters .. Patch Set 1: It's hard to argue with documenting these.

[Impala-ASF-CR] IMPALA-7980: Fix spinning threads because of buggy handling of num unqueued files .

2018-12-21 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning threads because of buggy handling of num_unqueued_files_. .. Patch Set 1: (9 comments)

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 15: Code-Review+2 Carrying +2. -- To view, visit

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-21 Thread Anonymous Coward (Code Review)
vih...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. Patch Set 8: > Uploaded

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-21 Thread Anonymous Coward (Code Review)
vih...@cloudera.com has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. IMPALA-7970 : Add support for

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-21 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12082 to look at the new patch set (#9). Change subject: IMPALA-7931: fix executor shutdown races

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. Patch Set 8: Build

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 8: (12 comments)

[Impala-ASF-CR] IMPALA-7867 (Part 3): ArrayList cleanup in planner

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12094 ) Change subject: IMPALA-7867 (Part 3): ArrayList cleanup in planner .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7867 (Part 3): ArrayList cleanup in planner

2018-12-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12094 ) Change subject: IMPALA-7867 (Part 3): ArrayList cleanup in planner .. Patch Set 2: Code-Review+2 Thanks for the cleanup. -- To

[Impala-ASF-CR] IMPALA-7867 (Part 3): ArrayList cleanup in planner

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12094 ) Change subject: IMPALA-7867 (Part 3): ArrayList cleanup in planner .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-21 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12082 to look at the new patch set (#10). Change subject: IMPALA-7931: fix executor shutdown races

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7867 (Part 3): ArrayList cleanup in planner

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12094 ) Change subject: IMPALA-7867 (Part 3): ArrayList cleanup in planner .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7867 (Part 3): ArrayList cleanup in planner

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12094 ) Change subject: IMPALA-7867 (Part 3): ArrayList cleanup in planner .. IMPALA-7867 (Part 3): ArrayList cleanup in

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 9: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 8: Code-Review+2 (1 comment)