[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2019-01-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 12: (2 comments) A couple of

[Impala-ASF-CR] IMPALA-6533: Add min-max filter for decimal types on kudu tables.

2019-01-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12113 ) Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. .. Patch Set 13: (15 comments)

[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2019-01-04 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. Patch Set 5: > Patch Set 4:

[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 13: Build started:

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2019-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2019-01-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 12: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 13: (24 comments)

[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2019-01-04 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. IMPALA-6742: Profiles of running queries

[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8026: Fix #rows accounting for NLJ

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12164 ) Change subject: IMPALA-8026: Fix #rows accounting for NLJ .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7917 (Part 1): Decouple Sentry from Impala

2019-01-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala .. Patch Set 6: (7 comments) I just realized I had some pending

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 12: (4 comments) lgtm, just a few nits.

[Impala-ASF-CR] IMPALA-8026: Fix #rows accounting for NLJ

2019-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12164 Change subject: IMPALA-8026: Fix #rows accounting for NLJ .. IMPALA-8026: Fix #rows accounting for NLJ Use the same, much simpler,

[Impala-ASF-CR] IMPALA-8047 Support .proto files in .clang-format

2019-01-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12165 Change subject: IMPALA-8047 Support .proto files in .clang-format .. IMPALA-8047 Support .proto files in .clang-format The .proto

[Impala-ASF-CR] IMPALA-8047 Support .proto files in .clang-format

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12165 ) Change subject: IMPALA-8047 Support .proto files in .clang-format .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. IMPALA-7931: fix executor shutdown races There were two

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 13: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7924: Generate Thrift 11 Python Code

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12036 ) Change subject: IMPALA-7924: Generate Thrift 11 Python Code .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7924: Generate Thrift 11 Python Code

2019-01-04 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12036 to look at the new patch set (#2). Change subject: IMPALA-7924: Generate Thrift 11 Python Code

[Impala-ASF-CR] IMPALA-7924: Generate Thrift 11 Python Code

2019-01-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12036 ) Change subject: IMPALA-7924: Generate Thrift 11 Python Code .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2019-01-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 8: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-04 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. Patch Set 7: Code-Review+1 (1 comment) > Patch Set 6: > > (5

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-04 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 12: (6 comments) Tim, thanks much for your

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2019-01-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 11: (6 comments)

[Impala-ASF-CR] IMPALA-6533: Add min-max filter for decimal types on kudu tables.

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12113 ) Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-7917 (Part 1): Decouple Sentry from Impala

2019-01-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala .. IMPALA-7917 (Part 1): Decouple Sentry from Impala The first part of

[Impala-ASF-CR] IMPALA-7917 (Part 1): Decouple Sentry from Impala

2019-01-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala .. Patch Set 6: Rebased. -- To view, visit

[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2019-01-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. Patch Set 4: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-04 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. IMPALA-8021: Add estimated cardinality to EXPLAIN output

[Impala-ASF-CR] IMPALA-6533: Add min-max filter for decimal types on kudu tables.

2019-01-04 Thread Janaki Lahorani (Code Review)
Janaki Lahorani has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/12113 ) Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. .. IMPALA-6533: Add min-max filter for decimal

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 12: (3 comments)

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2019-01-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. Patch Set 4: > > I would like there to

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2019-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 11: (7 comments)

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 12: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12163 ) Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7917 (Part 1): Decouple Sentry from Impala

2019-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-6533: Add min-max filter for decimal types on kudu tables.

2019-01-04 Thread Janaki Lahorani (Code Review)
Janaki Lahorani has posted comments on this change. ( http://gerrit.cloudera.org:8080/12113 ) Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. .. Patch Set 13: (20 comments) Thanks Tim. All

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale

2019-01-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12163 Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale .. IMPALA-7087: Read Parquet decimal columns with

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2019-01-04 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12082 to look at the new patch set (#12). Change subject: IMPALA-7931: fix executor shutdown races

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. IMPALA-5474: Adding a trivial subquery