[Impala-ASF-CR] Revert "IMPALA-6068: Fix dataload for complextypes fileformat"

2017-11-27 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8653 Change subject: Revert "IMPALA-6068: Fix dataload for complextypes_fileformat" .. Revert "IMPALA-6068: Fix dataload for

[Impala-ASF-CR] Revert "IMPALA-6068: Fix dataload for complextypes fileformat"

2017-11-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8653 ) Change subject: Revert "IMPALA-6068: Fix dataload for complextypes_fileformat" .. Patch Set 1: This is the first time I've done a revert

[Impala-ASF-CR] Revert "IMPALA-6068: Fix dataload for complextypes fileformat"

2017-11-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8653 ) Change subject: Revert "IMPALA-6068: Fix dataload for complextypes_fileformat" .. Patch Set 1: For a point of reference, here is the

[Impala-ASF-CR] Revert "IMPALA-3887: Wait for HDFS replication in data loading"

2017-12-19 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8880 Change subject: Revert "IMPALA-3887: Wait for HDFS replication in data loading" .. Revert "IMPALA-3887: Wait for HDFS replication in data

[Impala-ASF-CR](asf-site) IMPALA-6264: Remove "incubator-" from git links

2017-12-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8712 ) Change subject: IMPALA-6264: Remove "incubator-" from git links .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) IMPALA-6302: "Impala" is not spelled "Impalagg"

2017-12-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8808 ) Change subject: IMPALA-6302: "Impala" is not spelled "Impalagg" .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 12: (2 comments) > Patch Set 10: > > (2 comments) Since

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 12: > Patch Set 12: > > > Patch Set 11: > > > > Fredy, > > >

[Impala-ASF-CR] IMPALA-4464: Remove /bin/remote data load.py

2018-05-14 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10388 ) Change subject: IMPALA-4464: Remove /bin/remote_data_load.py .. IMPALA-4464: Remove /bin/remote_data_load.py This file was started before

[Impala-ASF-CR] Remove /bin/remote data load.py

2018-05-14 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10388 Change subject: Remove /bin/remote_data_load.py .. Remove /bin/remote_data_load.py This file was started before the ASF project was set

[Impala-ASF-CR] IMPALA-4464: Remove /bin/remote data load.py

2018-05-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10388 ) Change subject: IMPALA-4464: Remove /bin/remote_data_load.py .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4464: Remove /bin/remote data load.py

2018-05-14 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10388 ) Change subject: IMPALA-4464: Remove /bin/remote_data_load.py .. IMPALA-4464: Remove /bin/remote_data_load.py This file was

[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload

2018-05-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 ) Change subject: IMPALA-6819: Add new queries to targeted-perf workload .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload

2018-05-09 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9979 ) Change subject: IMPALA-6819: Add new queries to targeted-perf workload .. IMPALA-6819: Add new queries to targeted-perf workload

[Impala-ASF-CR] IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell

2018-05-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10354 ) Change subject: IMPALA-6999: Upgrade to sqlparse-0.1.19 for Impala shell .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 13: Code-Review+2 Thanks for upgrading sqlparse, Fredy! --

[Impala-ASF-CR] IMPALA-6819: Add new performance test workload - tpcds-unmodified used by Impala Performance Tests

2018-05-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9973 ) Change subject: IMPALA-6819: Add new performance test workload - tpcds-unmodified used by Impala Performance Tests .. Patch Set 8:

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 12: (1 comment) > Yeah I think it's a good idea to upgrade

[Impala-ASF-CR] IMPALA-6317: Add -cmake only option to buildall.sh

2018-05-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10455 ) Change subject: IMPALA-6317: Add -cmake_only option to buildall.sh .. Patch Set 3: > Patch Set 3: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6317: Add -cmake only option to buildall.sh

2018-05-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10455 ) Change subject: IMPALA-6317: Add -cmake_only option to buildall.sh .. Patch Set 3: Code-Review+2 Fixed a typo in commit msg, carrying

[Impala-ASF-CR] IMPALA-6317: Add -cmake only option to buildall.sh

2018-05-18 Thread David Knupp (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10455 to look at the new patch set (#3). Change subject: IMPALA-6317: Add -cmake_only option to buildall.sh

[Impala-ASF-CR] IMPALA-6317: Add -cmake only option to buildall.sh

2018-05-18 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10455 Change subject: IMPALA-6317: Add -cmake_only option to buildall.sh .. IMPALA-6317: Add -cmake_only option to buildall.sh It's sometimes

[Impala-ASF-CR] IMPALA-6810, IMPALA-6814: Skip remote tests that expect a local env

2018-05-27 Thread David Knupp (Code Review)
David Knupp has abandoned this change. ( http://gerrit.cloudera.org:8080/9937 ) Change subject: IMPALA-6810, IMPALA-6814: Skip remote tests that expect a local env .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload

2018-05-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 ) Change subject: IMPALA-6819: Add new queries to targeted-perf workload .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Add new performance test workload - tpcds-unmodified used by Impala Performance Tests

2018-05-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9973 ) Change subject: Add new performance test workload - tpcds-unmodified used by Impala Performance Tests .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 11: > Patch Set 11: > > > Do you know if this bug exists in

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 11: > Patch Set 11: > > I just realized we can roll out a

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-03 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 11: > Patch Set 11: > > > Patch Set 11: > > > > If there's a

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

2017-12-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Patch Set 4: Code-Review+2 Carrying +2 after rebase. -- To

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6447: remove Python 2.7 dictionary comprehensions

2018-01-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9150 ) Change subject: IMPALA-6447: remove Python 2.7 dictionary comprehensions .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: > Patch Set 7: > > David, it'd be great if you also had time for a look

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9291

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPAL-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-02-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6570: Support KUDU on SLES12.

2018-02-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9431 ) Change subject: IMPALA-6570: Support KUDU on SLES12. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6570: Support KUDU on SLES12.

2018-02-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9431 ) Change subject: IMPALA-6570: Support KUDU on SLES12. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

2017-12-20 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8896 Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Move symlinked auxiliary tests/* to tests/functional/* The

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

2017-12-20 Thread David Knupp (Code Review)
Hello Matthew Mulder, Michael Brown, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8896 to look at the new patch set (#2). Change subject: Move symlinked auxiliary tests/* to tests/functional/*

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

2017-12-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Patch Set 1: > Patch Set 1: Code-Review+1 > > (1 comment)

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

2017-12-20 Thread David Knupp (Code Review)
Hello Matthew Mulder, Michael Brown, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8896 to look at the new patch set (#3). Change subject: Move symlinked auxiliary tests/* to tests/functional/*

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

2017-12-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 ) Change subject: Move symlinked auxiliary tests/* to tests/functional/* .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 13: This is awesome. I look forward to reviewing this

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11128 ) Change subject: IMPALA-7399: Add script in lib/python to generate junit XML. .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-06 Thread David Knupp (Code Review)
Hello Michael Brown, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11128 to look at the new patch set (#4). Change subject: IMPALA-7399: Add script in lib/python to generate junit XML.

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-07 Thread David Knupp (Code Review)
Hello Michael Brown, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11128 to look at the new patch set (#5). Change subject: IMPALA-7399: Add script in lib/python to generate junit XML.

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-15 Thread David Knupp (Code Review)
Hello Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11235 to look at the new patch set (#4). Change subject: IMPALA-7399: Remove third-party dependencies from junit

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-15 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11235 Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. IMPALA-7399: Remove third-party dependencies from

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-15 Thread David Knupp (Code Review)
Hello Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11235 to look at the new patch set (#3). Change subject: IMPALA-7399: Remove third-party dependencies from junit

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 4: (1 comment) > I don't feel all

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 5: Hmm. I might bat this aside. :-)

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. IMPALA-7399: Remove third-party

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 7: Code-Review+2 Carrying +2 -- To

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 8: Sorry -- forgot to rebase. Carrying

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
Hello Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11235 to look at the new patch set (#7). Change subject: IMPALA-7399: Remove third-party dependencies from junit

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-06 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11128 Change subject: IMPALA-7399: Add script in lib/python to generate junit XML. .. IMPALA-7399: Add script in lib/python to generate junit

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-06 Thread David Knupp (Code Review)
Hello Michael Brown, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11128 to look at the new patch set (#3). Change subject: IMPALA-7399: Add script in lib/python to generate junit XML.

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
Hello Michael Brown, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11128 to look at the new patch set (#7). Change subject: IMPALA-7399: Add script in lib/python to generate junit XML.

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11128 ) Change subject: IMPALA-7399: Add script in lib/python to generate junit XML. .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
Hello Michael Brown, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11128 to look at the new patch set (#6). Change subject: IMPALA-7399: Add script in lib/python to generate junit XML.

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
Hello Michael Brown, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11128 to look at the new patch set (#8). Change subject: IMPALA-7399: Add script in lib/python to generate junit XML.

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
Hello Michael Brown, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11128 to look at the new patch set (#9). Change subject: IMPALA-7399: Add script in lib/python to generate junit XML.

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11128 ) Change subject: IMPALA-7399: Add script in lib/python to generate junit XML. .. IMPALA-7399: Add script in lib/python to

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11128 ) Change subject: IMPALA-7399: Add script in lib/python to generate junit XML. .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11128 ) Change subject: IMPALA-7399: Add script in lib/python to generate junit XML. .. Patch Set 10: Since this code interacts with nothing in

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11128 ) Change subject: IMPALA-7399: Add script in lib/python to generate junit XML. .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7399: Add script in lib/python to generate junit XML.

2018-08-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11128 ) Change subject: IMPALA-7399: Add script in lib/python to generate junit XML. .. Patch Set 10: Carrying Phil's +2 after rebase. -- To

[Impala-ASF-CR] IMPALA-6923: Remove create database.py and perf result datastore.py

2018-08-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 ) Change subject: IMPALA-6923: Remove create_database.py and perf_result_datastore.py .. Patch Set 22: > Patch Set 22: > > Build Failed

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 ) Change subject: tests: ensure consistent logging format across tests .. Patch Set 1: > Patch Set 1: Code-Review+2 > > (1 comment) > >

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-21 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#9). Change subject: IMPALA-7399: Emit a junit xml report when

[Impala-ASF-CR] IMPALA-7399: Sample usage of junit xml reporting

2018-08-21 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#6). Change subject: IMPALA-7399: Sample usage of junit xml reporting

[Impala-ASF-CR] IMPALA-7399: Sample usage of junit xml reporting

2018-08-21 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#7). Change subject: IMPALA-7399: Sample usage of junit xml

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 10: All outstanding comments have been

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-6923: Remove create database.py and perf result datastore.py

2018-08-28 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11315 ) Change subject: IMPALA-6923: Remove create_database.py and perf_result_datastore.py .. Patch Set 1: Code-Review+1 This makes sense to

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#10). Change subject: IMPALA-7399: Emit a junit xml report when

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6923: Remove create database.py and perf result datastore.py

2018-08-31 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11315 ) Change subject: IMPALA-6923: Remove create_database.py and perf_result_datastore.py .. Patch Set 1: Code-Review+2 > Patch Set 1: > >

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-31 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11352 ) Change subject: IMPALA-7508: Add Impala Python GDB module .. Patch Set 4: Code-Review+2 Carrying Phil's +2 from before the addition of

[Impala-ASF-CR] Add bin/jenkins/finalize.sh

2018-08-31 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11322 ) Change subject: Add bin/jenkins/finalize.sh .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11322 To

[Impala-ASF-CR] Fix generate junitxml for python2.6.

2018-09-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11384 ) Change subject: Fix generate_junitxml for python2.6. .. Patch Set 1: Code-Review+2 Thanks for catching this Phil! -- To view, visit

[Impala-ASF-CR] Elaborating error message when incorrect port number is specified in impala-shell.

2018-09-05 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11368 ) Change subject: Elaborating error message when incorrect port number is specified in impala-shell. .. Patch Set 1: Code-Review+2 --

[Impala-ASF-CR] Add bin/jenkins/finalize.sh

2018-08-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11322 ) Change subject: Add bin/jenkins/finalize.sh .. Patch Set 2: Code-Review+1 This looks reasonable to me. +1 for now in case others have

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11352 ) Change subject: IMPALA-7508: Add Impala Python GDB module .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Fix zsh issue in set-pythonpath.sh

2018-07-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10901 ) Change subject: Fix zsh issue in set-pythonpath.sh .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 2: (1 comment)

  1   2   3   4   5   >