[Impala-ASF-CR] IMPALA-6225: Part 1: Query profile date-time strings should have ns precision.

2017-11-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Part 1: Query profile date-time strings should have ns precision. .. Patch Set 8: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8623 to look at the new patch set (#3). Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 5: (14 comments) Sorry for the delay. Some more

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (12 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-11-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()

2017-11-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 ) Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-27 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8623 to look at the new patch set (#2). Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()

2017-11-29 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8689 Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected() .. IMPALA-5940: Avoid stack tracing and log spew

[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()

2017-11-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 ) Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected() .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8623 to look at the new patch set (#4). Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8751 Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. IMPALA-6238: Enhance

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Hello Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8751 to look at the new patch set (#2). Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8751 ) Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. Patch Set 2: Code-Review+2 Carry +2. -- To view,

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8751 ) Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 8: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8782 ) Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8841 ) Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. Patch Set 1: You may want to update it here too:

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Removed reviewer Kudu Jenkins. -- To view,

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Dan Burkert from this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Removed reviewer Dan Burkert. -- To view, visit

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Patch Set 1: (1 comment) Mostly a clean cherry-pick

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Removed reviewer Alexey Serbin. -- To view,

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8875 to review the following change. Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 1: (13 comments)

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8878 to review the following change. Change subject: KUDU-2228: Make Messenger options configurable ..

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Hello Lars Volker, Dan Burkert, Kudu Jenkins, Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8878 to look at the new patch set (#2). Change subject: KUDU-2228: Make Messenger options configurable

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 1: Some number of conflicts in the #include files. Conflicts

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 14: (6 comments) Thanks for updating the interface.

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 10: (8 comments) Looking good.

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8841 ) Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots

2017-12-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 13: (4 comments)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 12: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 11: (7 comments)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: The backport for the fix of KUDU-2228 is being

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow"

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8597 Change subject: IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow" .. IMPALA-6220: Revert "IMPALA-6128:

[Impala-ASF-CR] IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow"

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8597 ) Change subject: IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow" .. IMPALA-6220: Revert

[Impala-ASF-CR] IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow"

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8597 ) Change subject: IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow" .. Patch Set 1: I also did private

[Impala-ASF-CR] IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow"

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8597 ) Change subject: IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow" .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/8610 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Abandoned Dup with https://gerrit.cloudera.org/#/c/8611/

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 2: Code-Review+1 (1 comment) Please

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8610 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 1: As discussed offline, it may be

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 2: As mentioned before, an alternate

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8623 Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. IMPALA-6187: Fix missing conjuncts evaluation with

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 1: May be I missed it somehow but Hbase

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6184: Clean up after ScalarExprEvaluator::Clone() fails

2017-11-16 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8572 to look at the new patch set (#2). Change subject: IMPALA-6184: Clean up after ScalarExprEvaluator::Clone() fails

[Impala-ASF-CR] IMPALA-6184: Clean up after ScalarExprEvaluator::Clone() fails

2017-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8572 ) Change subject: IMPALA-6184: Clean up after ScalarExprEvaluator::Clone() fails .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6184: Clean up after ScalarExprEvaluator::Clone() fails

2017-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8572 ) Change subject: IMPALA-6184: Clean up after ScalarExprEvaluator::Clone() fails .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails

2017-11-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8572 Change subject: IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails .. IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone()

[Impala-ASF-CR] IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails

2017-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8572 ) Change subject: IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 3: (16 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Hello Philip Zeyliger, Sailesh Mukil, Tim Armstrong, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8788 to look at the new patch set (#4). Change subject: IMPALA-6285: Don't print stack trace on RPC errors.

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 8: (10 comments)

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8766 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS be principal is set

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8761 ) Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set .. Patch Set 2:

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Patch Set 2: I would recommend against reverting this

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Patch Set 2: According to the Kudu workaround you

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: The change looks good. Please address the question

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 16: Code-Review+2 Thanks for updating the patch to move

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8788 Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. IMPALA-6285: Don't print stack trace on RPC errors. There is not

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. IMPALA-6285: Don't print stack trace on RPC errors. There is not

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 2: (2 comments) The output messages were confirmed with

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8770 Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. IMPALA-6262: Always initialize runtime profile for DataSink

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Hello Philip Zeyliger, Sailesh Mukil, Tim Armstrong, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8788 to look at the new patch set (#3). Change subject: IMPALA-6285: Don't print stack trace on RPC errors.

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 3: Code-Review+2 Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 4: Code-Review+2 Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 1: Nice catch ! Do we have a similar problem with the

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

  1   2   3   4   5   >