[Impala-ASF-CR] IMPALA-9340: fix bug where max missed heartbeats is off by one

2020-02-11 Thread Riza Suminto (Code Review)
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15201 to look at the new patch set (#2). Change subject: IMPALA-9340: fix bug where max missed heartbeats is off by one

[Impala-ASF-CR] IMPALA-9340: fix bug where max missed heartbeats is off by one

2020-02-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15201 ) Change subject: IMPALA-9340: fix bug where max missed heartbeats is off by one .. Patch Set 2: (2 comments) Patch set 2 submitted.

[Impala-ASF-CR] IMPALA-9340: fix bug where max missed heartbeats is off by one

2020-02-10 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15201 Change subject: IMPALA-9340: fix bug where max missed heartbeats is off by one .. IMPALA-9340: fix bug where max missed heartbeats is

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15308 ) Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled .. Patch Set 2: (1 comment) Patch set 2

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-04 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15308 to look at the new patch set (#2). Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15308 ) Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled .. Patch Set 2: (1 comment) Hi Fang-Yu,

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-03 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15308 ) Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-02-27 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15308 Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled .. IMPALA-8674: fix bug where REMOTE runtime

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-05 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15308 to look at the new patch set (#3). Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-05 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15308 to look at the new patch set (#4). Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15308 ) Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled .. Patch Set 4: (7 comments) Thanks Fang-Yu,

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-06 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15308 to look at the new patch set (#6). Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-06 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15308 to look at the new patch set (#5). Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

[Impala-ASF-CR] IMPALA-9280: Fix parsing of timestamp with dash before TZH

2020-01-29 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15130 to look at the new patch set (#2). Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH

[Impala-ASF-CR] IMPALA-9280: Fix parsing of timestamp with dash before TZH

2020-01-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15130 ) Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH .. Patch Set 2: (3 comments) Thank you for the initial

[Impala-ASF-CR] IMPALA-9280: Fix parsing of timestamp with dash before TZH

2020-01-31 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15130 to look at the new patch set (#5). Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH

[Impala-ASF-CR] IMPALA-9280: Fix parsing of timestamp with dash before TZH

2020-01-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15130 ) Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-9280: Time string with signed TZH token preceded by dash cannot be cast to timestamp

2020-01-30 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15130 to look at the new patch set (#3). Change subject: IMPALA-9280: Time string with signed TZH token preceded by dash cannot be cast to timestamp

[Impala-ASF-CR] IMPALA-9280: Fix parsing of timestamp with dash before TZH

2020-01-30 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15130 to look at the new patch set (#4). Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH

[Impala-ASF-CR] IMPALA-9280: Fix parsing of timestamp with dash before TZH

2020-01-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15130 ) Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH .. Patch Set 2: (4 comments) Thank you Gabor for your

[Impala-ASF-CR] IMPALA-9280: Fix parsing of timestamp with dash before TZH

2020-01-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15130 ) Change subject: IMPALA-9280: Fix parsing of timestamp with dash before TZH .. Patch Set 4: (1 comment) Patch set 4 submitted. I only

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15308 ) Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled .. Patch Set 6: (3 comments) Hi Tim, Thanks

[Impala-ASF-CR] IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled

2020-03-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15308 ) Change subject: IMPALA-8674: fix bug where REMOTE runtime filter always marked disabled .. Patch Set 3: (1 comment) Patch set 3

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 3: Patch Set 3 add new be test,

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15673 to look at the new patch set (#3). Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15673 to look at the new patch set (#4). Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15673 to look at the new patch set (#5). Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 4: (5 comments) Thanks, Tim! Learn new

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-07 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15673 Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. IMPALA-9612: Fix race condition in

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-07 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15673 to look at the new patch set (#2). Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-06 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#11). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 2: > Patch Set 2: > > I should've asked

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 11: Patch Set 11 add improvement for insertion into

[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest

2020-04-13 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15726 Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest .. IMPALA-9650: Fix flakiness in RuntimeFilterTest IMPALA-9612 adds

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-20 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#12). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-20 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 12: New change in Patch Set 12: - Instead of measuring

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-25 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#4). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 4: (6 comments) Patch set 4 submitted. This patch

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-27 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#5). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 5: (1 comment) Patch Set 5 submitted. What is

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-31 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#8). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-31 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#9). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 9: (2 comments) Hi David, thank you for your feedback.

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-30 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#6). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-30 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#7). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 9: (2 comments)

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 10: (5 comments) Patch Set 10 adds several things: -

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-02 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#10). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-30 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15511 to look at the new patch set (#13). Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table.

[Impala-ASF-CR] IMPALA-9650: Fix flakiness in RuntimeFilterTest

2020-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15726 ) Change subject: IMPALA-9650: Fix flakiness in RuntimeFilterTest .. Patch Set 1: > Patch Set 1: > > Build Failed > >

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-22 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15511 Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. WIP IMPALA-9434: Implement Robin Hood Hash Table. Robin hood

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 3: (6 comments) Hi Tim, thanks for your valuable

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-21 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#19). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 19: Patch set 18 failed the first test

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-20 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#17). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-10054: Fix flakiness in test multiple sort run bytes limits

2020-08-06 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16301 Change subject: IMPALA-10054: Fix flakiness in test_multiple_sort_run_bytes_limits .. IMPALA-10054: Fix flakiness in

[Impala-ASF-CR] IMPALA-9851: Truncate long error message.

2020-08-06 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16300 to look at the new patch set (#2). Change subject: IMPALA-9851: Truncate long error message.

[Impala-ASF-CR] IMPALA-9851: Truncate long error message.

2020-08-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10054: Fix flakiness in test multiple sort run bytes limits

2020-08-07 Thread Riza Suminto (Code Review)
Hello Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16301 to look at the new patch set (#2). Change subject: IMPALA-10054: Fix flakiness in test_multiple_sort_run_bytes_limits

[Impala-ASF-CR] IMPALA-10054: Fix flakiness in test multiple sort run bytes limits

2020-08-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16301 ) Change subject: IMPALA-10054: Fix flakiness in test_multiple_sort_run_bytes_limits .. Patch Set 2: (1 comment) Hi Attila, I change

[Impala-ASF-CR] IMPALA-10054: Fix flakiness in test multiple sort run bytes limits

2020-08-07 Thread Riza Suminto (Code Review)
Hello Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16301 to look at the new patch set (#3). Change subject: IMPALA-10054: Fix flakiness in test_multiple_sort_run_bytes_limits

[Impala-ASF-CR] IMPALA-10054: Fix flakiness in test multiple sort run bytes limits

2020-08-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16301 ) Change subject: IMPALA-10054: Fix flakiness in test_multiple_sort_run_bytes_limits .. Patch Set 2: I reran the dockerised test with

[Impala-ASF-CR] IMPALA-9851: Truncate long error message.

2020-08-06 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16300 Change subject: IMPALA-9851: Truncate long error message. .. IMPALA-9851: Truncate long error message. Error message length was

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-30 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#15). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 15: (8 comments) Thank you, Csaba!

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 15: > Patch Set 15: Code-Review+1 > >

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-01 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#16). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 12: (3 comments) Thank you Csaba for

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-26 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#14). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 14: (13 comments)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-26 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#13). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-16 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#12). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 12: (5 comments) Patch Set 12 add

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (7 comments)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-05 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#10). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 10: (9 comments)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-07 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#11). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] WIP IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-03 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15963 Change subject: WIP IMPALA-6692: Trigger sort node run before hitting memory limit. .. WIP IMPALA-6692: Trigger sort node run before

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-03 Thread Riza Suminto (Code Review)
Hello David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#9). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (4 comments)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 11: (4 comments)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 20: Patch set 19 fail the same test,

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-22 Thread Riza Suminto (Code Review)
Hello David Rorke, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15963 to look at the new patch set (#20). Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit.

[Impala-ASF-CR] IMPALA-10112: Remove FpRateTooHigh() check for blom filter

2020-09-23 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16499 Change subject: IMPALA-10112: Remove FpRateTooHigh() check for blom filter .. IMPALA-10112: Remove FpRateTooHigh() check for blom filter

[Impala-ASF-CR] IMPALA-10112: Remove FpRateTooHigh() check for bloom filter

2020-09-24 Thread Riza Suminto (Code Review)
Hello Shant Hovsepian, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16499 to look at the new patch set (#2). Change subject: IMPALA-10112: Remove FpRateTooHigh() check for bloom filter

[Impala-ASF-CR] IMPALA-10112: Remove FpRateTooHigh() check for bloom filter

2020-09-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16499 ) Change subject: IMPALA-10112: Remove FpRateTooHigh() check for bloom filter .. Patch Set 2: (10 comments) Patch set 2 submitted.